Re: [PATCH v9 01/17] graph: rename rte_graph_work as common

[Jerin Jacob <jerinjacobk@gmail.com>]

On Wed, Jun 7, 2023 at 9:29 AM Zhirun Yan <zhirun.yan@intel.com> wrote:
>
> Rename rte_graph_work.h to rte_graph_work_common.h for supporting
> multiple graph worker model.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> Signed-off-by: Cunming Liang <cunming.liang@intel.com>
> Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>

You can keep this TAG in upcoming versions on the patch, if there is no change.

Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  MAINTAINERS                                                 | 3 ++-
>  lib/graph/graph_pcap.c                                      | 2 +-
>  lib/graph/graph_private.h                                   | 2 +-
>  lib/graph/meson.build                                       | 2 +-
>  lib/graph/{rte_graph_worker.h => rte_graph_worker_common.h} | 6 +++---
>  5 files changed, 8 insertions(+), 7 deletions(-)
>  rename lib/graph/{rte_graph_worker.h => rte_graph_worker_common.h} (99%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 48830ae571..34ac499c14 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1716,10 +1716,11 @@ F: doc/guides/prog_guide/bpf_lib.rst
>  Graph - EXPERIMENTAL
>  M: Jerin Jacob <jerinj@marvell.com>
>  M: Kiran Kumar K <kirankumark@marvell.com>
> +M: Nithin Dabilpuram <ndabilpuram@marvell.com>
> +M: Zhirun Yan <zhirun.yan@intel.com>
>  F: lib/graph/
>  F: doc/guides/prog_guide/graph_lib.rst
>  F: app/test/test_graph*
> -M: Nithin Dabilpuram <ndabilpuram@marvell.com>
>  F: examples/l3fwd-graph/
>  F: doc/guides/sample_app_ug/l3_forward_graph.rst
>
> diff --git a/lib/graph/graph_pcap.c b/lib/graph/graph_pcap.c
> index 6c43330029..8a220370fa 100644
> --- a/lib/graph/graph_pcap.c
> +++ b/lib/graph/graph_pcap.c
> @@ -10,7 +10,7 @@
>  #include <rte_mbuf.h>
>  #include <rte_pcapng.h>
>
> -#include "rte_graph_worker.h"
> +#include "rte_graph_worker_common.h"
>
>  #include "graph_pcap_private.h"
>
> diff --git a/lib/graph/graph_private.h b/lib/graph/graph_private.h
> index eacdef45f0..307e5f70bc 100644
> --- a/lib/graph/graph_private.h
> +++ b/lib/graph/graph_private.h
> @@ -13,7 +13,7 @@
>  #include <rte_spinlock.h>
>
>  #include "rte_graph.h"
> -#include "rte_graph_worker.h"
> +#include "rte_graph_worker_common.h"
>
>  extern int rte_graph_logtype;
>
> diff --git a/lib/graph/meson.build b/lib/graph/meson.build
> index 3526d1b5d4..4e2b612ad3 100644
> --- a/lib/graph/meson.build
> +++ b/lib/graph/meson.build
> @@ -16,6 +16,6 @@ sources = files(
>          'graph_populate.c',
>          'graph_pcap.c',
>  )
> -headers = files('rte_graph.h', 'rte_graph_worker.h')
> +headers = files('rte_graph.h', 'rte_graph_worker_common.h')
>
>  deps += ['eal', 'pcapng']
> diff --git a/lib/graph/rte_graph_worker.h b/lib/graph/rte_graph_worker_common.h
> similarity index 99%
> rename from lib/graph/rte_graph_worker.h
> rename to lib/graph/rte_graph_worker_common.h
> index 438595b15c..0bad2938f3 100644
> --- a/lib/graph/rte_graph_worker.h
> +++ b/lib/graph/rte_graph_worker_common.h
> @@ -2,8 +2,8 @@
>   * Copyright(C) 2020 Marvell International Ltd.
>   */
>
> -#ifndef _RTE_GRAPH_WORKER_H_
> -#define _RTE_GRAPH_WORKER_H_
> +#ifndef _RTE_GRAPH_WORKER_COMMON_H_
> +#define _RTE_GRAPH_WORKER_COMMON_H_
>
>  /**
>   * @file rte_graph_worker.h
> @@ -518,4 +518,4 @@ rte_node_next_stream_move(struct rte_graph *graph, struct rte_node *src,
>  }
>  #endif
>
> -#endif /* _RTE_GRAPH_WORKER_H_ */
> +#endif /* _RTE_GRAPH_WORKER_COIMMON_H_ */
> --
> 2.37.2
>