From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4994445A7B;
	Tue,  1 Oct 2024 17:02:07 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1698140268;
	Tue,  1 Oct 2024 17:02:07 +0200 (CEST)
Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com
 [209.85.160.171])
 by mails.dpdk.org (Postfix) with ESMTP id 00F9540151
 for <dev@dpdk.org>; Tue,  1 Oct 2024 17:02:05 +0200 (CEST)
Received: by mail-qt1-f171.google.com with SMTP id
 d75a77b69052e-45815723c87so44674291cf.0
 for <dev@dpdk.org>; Tue, 01 Oct 2024 08:02:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1727794925; x=1728399725; darn=dpdk.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=uFgnLSCQBeaPDPudPBOkdDrq1Ecy0WvtC2YQ36LGqaI=;
 b=Zdd6A9TzqhP2w2WEy6IRUg2xIPoAvW2hut1/djVDK6CD5PJp1BXp+k0cx3KTYYC1Nq
 FlUi4yi3Nxw5TgaNNgly1zQ809dkpE2KJHtKPh0ybQXh/+JoC5HqZrz3jUunfWDbJnMv
 6OYaxPl+vdnZlk6zgkTj4SAaB6CG7ajJ7TBrNCef2XD0FCtQ/4Vz7bP9G0T1yWxGCcLX
 3Xc0hMP9X9RHQxdJobEePAmWXTARpcJux+jf6HkX9Lvtrbm+J7fYZtPdFCuUk2aeRFAS
 vCQHiReC6OFnbPaeqavqBJWHYQyrnkHM1j/PBrG15BbWlbmTokr02eHY/xgvwyrHil4u
 E4+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1727794925; x=1728399725;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=uFgnLSCQBeaPDPudPBOkdDrq1Ecy0WvtC2YQ36LGqaI=;
 b=QMC2VrsEW2Z57J0VYLNMVyyeVu914exn+Sh6cLWRmaR5E+k4Gku0zUWDYcmUO++3Ns
 InMywj5Y2wcIbZvz4BUiESWKmi236SF+ci0kN6cWvxakT86Dj5EOfq9m6VleqCdhEyZ6
 HgLRgMgQyGzK7MJTdzBf4yhyUp6nwZFhFmO4I7OMq1Bhy3pVX6SZ9yB0noi+377uiShI
 gN14AB7b5GZvk058bgcQhG14mJ4SqaBLhr9Gb5GGmMpMn21hb5a9YtQ/C8yX7fufZ0sH
 uzQQkqSEkEaX/ur/WYmwCUW8VOenIy0UKd1gJfN6eDllbjzlviEsQxuoaPJAJ9MXuU76
 7W8w==
X-Forwarded-Encrypted: i=1;
 AJvYcCXj/u1eaUXoc345AF1Ox8qysXxIGGtr5jUmf2fqwDHilIxJY7n11UFPHLOMeSidZP+OYeQ=@dpdk.org
X-Gm-Message-State: AOJu0Yxpd4vWxQs89ggLmErJhE+wuGVqrU2lTKfTWpaM6MHoy2L2YbC4
 daJttH1xUK1yrSTXDY5LCoXdGQ2NSqmk7PTkMqPiYmq1/zFAX/WCMlz3YzbnRaHBOaEby+5KcfC
 FofvzaBTYTI04Tly/QMnIFBuf1D8=
X-Google-Smtp-Source: AGHT+IGfxsADs37tE0wNH5t5RzromRYP4k49zzSKyQaLRCKafYxnbg8bH5h+Iv0mk5wUfKc5tLOCTd4mSTKpZY413C8=
X-Received: by 2002:ac8:7f04:0:b0:458:2e58:46d with SMTP id
 d75a77b69052e-45d73a5e67cmr54820621cf.12.1727794925111; Tue, 01 Oct 2024
 08:02:05 -0700 (PDT)
MIME-Version: 1.0
References: <20240918085551.231015-1-mb@smartsharesystems.com>
 <20240924133957.1505113-1-mb@smartsharesystems.com>
 <CALBAE1MBD0bcLGgsSfBHN867fo_EU7gpvMPp5NzEC+BmD=4G7g@mail.gmail.com>
 <98CBD80474FA8B44BF855DF32C47DC35E9F72A@smartserver.smartshare.dk>
 <CALBAE1MwigJA+Vi=ZUTa_wCoKgWU2d3zzzY7CoUMTY82FsaT_A@mail.gmail.com>
 <98CBD80474FA8B44BF855DF32C47DC35E9F74B@smartserver.smartshare.dk>
 <CALBAE1PXs0iRFxx5WWycDkUB8HQbgqSD+3yxram7O1jhs1H8gg@mail.gmail.com>
 <98CBD80474FA8B44BF855DF32C47DC35E9F74C@smartserver.smartshare.dk>
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F74C@smartserver.smartshare.dk>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Tue, 1 Oct 2024 20:31:37 +0530
Message-ID: <CALBAE1N+GP=QSsN3LPJEfxbN92SOhPm1Q_uLG_3tEWp605H0qQ@mail.gmail.com>
Subject: Re: [PATCH v4] eal: add build-time option to omit trace
To: =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>
Cc: Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,
 dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Oct 1, 2024 at 7:44=E2=80=AFPM Morten Br=C3=B8rup <mb@smartsharesys=
tems.com> wrote:
>
> > From: Jerin Jacob [mailto:jerinjacobk@gmail.com]
> > Sent: Tuesday, 1 October 2024 16.05
> >
> > On Tue, Oct 1, 2024 at 7:19=E2=80=AFPM Morten Br=C3=B8rup <mb@smartshar=
esystems.com>
> > wrote:
> > >
> > > Jerin,
> > >
> > > If you have no further comments, please add review/ack tag, to help
> > Thomas see that the patch has been accepted by the maintainer, and can
> > be merged.
> >
> > There was a comment to make the function as rte_trace_is_enabled() and
> > remove internal. The rest looks good to me. I will Ack in the next
> > version.
>
> Perhaps my reply to that comment was unclear... such a public function al=
ready exists in the previous API:

I see. It was not clear.

> https://elixir.bootlin.com/dpdk/v24.07/source/lib/eal/include/rte_trace.h=
#L36
>
> That function tells if trace enabled at both build time and runtime, and =
returns false if not.
>
> A separate public function to tell if trace is enabled at build time seem=
s like overkill to me. Is that what you are asking for?

No. Just use rte_trace_is_enabled() in app/test instead of
__rte_trace_point_generic_is_enabled() as it is internal.