From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0218542B35; Thu, 18 May 2023 07:53:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E640842B71; Thu, 18 May 2023 07:53:10 +0200 (CEST) Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by mails.dpdk.org (Postfix) with ESMTP id 60DB940E25 for ; Thu, 18 May 2023 07:53:09 +0200 (CEST) Received: by mail-vs1-f42.google.com with SMTP id ada2fe7eead31-434737d7840so483657137.0 for ; Wed, 17 May 2023 22:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684389189; x=1686981189; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vio6AMSKxgnLqay4cIxb63T6cabSBfbZfiwghWUW55A=; b=bQcVkd4U5DgaC4sSqXGc2aforHHz0okOEycznDUKYaH5uftgjCPLgJpYtoRiityroT cXYnFh5KVXPgorzAzrd6t68GcxZ/sd7EjO3Vy2wOoqoF1izU2qEmWULYC4jqS74jqS+Z 683QWYLXkfF2DSlGeRJL6YV0nhtmc7kFug7htmBejGr38N8vPWqjuWtJ6/5ltM2euXz/ zeW+C8vqfDlzTy3gKfF7xT5nYP0oJ4cg0JH/0BNDSco3XXrZkuII7pGgVJ9B/ej0tZlK 8keA+pCF0atxjUZIp6kbSQc23mHAWKGpqBYk48CwbQ2FIru22c2UgYvjcy9WCm1Ahet4 Xziw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684389189; x=1686981189; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vio6AMSKxgnLqay4cIxb63T6cabSBfbZfiwghWUW55A=; b=DBMNe60kg8dMvQ2povNOvWgPYf8keoGEAPbcDonHRM3asH6934uvCpn5rduP0a1LFu IHPXDJIltloirtuW/CRhuCJLrIh810rOM8zBytXeUsny0kkyPxR1sPllQHD3cA1tOBpp sZKjM3XwjidlbWuMduP1KZ5TMoVesZwMNzV63rv3JwVWojsQTcHMwnk0+xBcsTpehswO O+PXn27mHoaPodXuMhXq7bJwrcbDaFScoeTIhoUp+6syhbHV+aUZvI+knVxrAcgPEkSG ZKBmLqapdWkmo6FdtA1oSCwUXJ+jjWoAQcY+AAKaj6LRQqReAhkA7ZAZ3Q5SfxXMgk0a dxlQ== X-Gm-Message-State: AC+VfDzbgTfphq1pnPszL15Cn5tCxLSFhNka/NhP7RQVgIZcoRpVTi4q 5JhQXzXYP4+tnDaHCu8y3tPZ2F6hT/ashESNQvU= X-Google-Smtp-Source: ACHHUZ76JpjsTVfJHThvucY/qurqvmECDgGwkmMLspx3DFdVSWrrgloxd6RNk8tHitQrV4Qk6gdKHczTvLxsyKENBwg= X-Received: by 2002:a05:6102:4a9:b0:437:dfef:6e62 with SMTP id r9-20020a05610204a900b00437dfef6e62mr156446vsa.18.1684389188554; Wed, 17 May 2023 22:53:08 -0700 (PDT) MIME-Version: 1.0 References: <20230411091144.1087887-1-ndabilpuram@marvell.com> <20230411091144.1087887-2-ndabilpuram@marvell.com> In-Reply-To: <20230411091144.1087887-2-ndabilpuram@marvell.com> From: Jerin Jacob Date: Thu, 18 May 2023 11:22:42 +0530 Message-ID: Subject: Re: [PATCH 02/21] common/cnxk: add pool BPID to RQ while using common pool To: Nithin Dabilpuram Cc: Kiran Kumar K , Sunil Kumar Kori , Satha Rao , jerinj@marvell.com, dev@dpdk.org, Shijith Thotton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 11, 2023 at 2:42=E2=80=AFPM Nithin Dabilpuram wrote: > > From: Shijith Thotton > > When RQs of two different traffic classes are using the same mempool, > BPIDs could differ between the RQs and BPID of only one RQ can be > configured per pool. In such cases, a new BPID is configured on both RQs > and pool or pool back-pressure is disabled. > > CN103xx and CN106xx B0 supports configuring multiple BPID per RQ. > > Signed-off-by: Shijith Thotton > --- > drivers/common/cnxk/roc_idev.c | 12 +++ > drivers/common/cnxk/roc_idev.h | 1 + > drivers/common/cnxk/roc_idev_priv.h | 1 + > drivers/common/cnxk/roc_nix.c | 5 + > drivers/common/cnxk/roc_nix.h | 3 + > drivers/common/cnxk/roc_nix_fc.c | 156 ++++++++++++++++------------ > drivers/common/cnxk/roc_npa.c | 48 +++++++++ > drivers/common/cnxk/roc_npa.h | 2 + > drivers/common/cnxk/version.map | 2 + > 9 files changed, 166 insertions(+), 64 deletions(-) > > diff --git a/drivers/common/cnxk/roc_nix.h b/drivers/common/cnxk/roc_nix.= h > index 2737bb9517..188b8800d3 100644 > --- a/drivers/common/cnxk/roc_nix.h > +++ b/drivers/common/cnxk/roc_nix.h > @@ -425,6 +425,8 @@ typedef void (*q_err_get_t)(struct roc_nix *roc_nix, = void *data); > typedef void (*link_info_get_t)(struct roc_nix *roc_nix, > struct roc_nix_link_info *link); > > +TAILQ_HEAD(roc_nix_list, roc_nix); Could you check to remove this global variable?