From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07233A04C5; Thu, 14 Nov 2019 13:57:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F5AF2BBD; Thu, 14 Nov 2019 13:57:58 +0100 (CET) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id A59B12BA8 for ; Thu, 14 Nov 2019 13:57:56 +0100 (CET) Received: by mail-il1-f193.google.com with SMTP id p6so5253178ilp.1 for ; Thu, 14 Nov 2019 04:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V0Qpw3kcepHkAP27zF+SpHgWPz1ayPsSCBgijeotDxg=; b=iObIWpxzUAuB0+xu/esbV0Pd1AggndxNXATsawH4QwyeP++yE1p9PRwm0uejH80MAr htezeDtxO9X36QiC04JCXnzyCtkw3Rvt9L+2f/K6ODWYfD6wuYedtwhqOm+oTrTS7N0u 1yevSdsWPTaKgFiWIRhpk1508weKXGqyJoV7RdcFjcFhEGp7l+XqaF2sN6qS1pc1oEXK 2Wn7fvustcKIb7Hw3+0mWBLxusL60K+igkY9rsWmZYTv2DpPi8xNr7Vj7nOeL4QlQESH mYdM1vDbLM2DxKzGLEiqloHt2qQE9OmFpVOXInQbQBhIzHF5W4vzi6VjD8nFqTr95tW0 1+NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V0Qpw3kcepHkAP27zF+SpHgWPz1ayPsSCBgijeotDxg=; b=TnuWogMv2sL5CeWVMwBIrqxMqz2WO0iUmMPh5/n+QPHn5g306QGJ5/s6NiJ8yMgLvX M9//DbQTdgONOVLiWK0keZCcFOA4OBWYnQFVCPWGTPc/fOHjE6f40TewaVKCcLnov06G BqzAqIKoN3Zu/aF/dOVzyytBkzoe7lyZ2ofkYTrCp1J9QsSYH6ExOBBq/on65rE7A/eO 3KrsUsa38rHxli+5u9bCGgs6okeu9Sx4TSYDo9ZnqWkpYzisogayH3szYr/wgeemgn/A MKJpJqJn3cA2EyN5VHo8JZnyyfAOPszfN0cq+np9Hj726M0C2Zv3smhe2CCVXr17dRz1 I7OQ== X-Gm-Message-State: APjAAAVpF2rFwZuqqECB0q+bXKigThOlwC51TukdpCaHcUe+ETgpjz6t pZCIpWWViuRruO/G2NNX5hxlnHiRXhLdRU4HyZY= X-Google-Smtp-Source: APXvYqyqNHGx1kAjuKDBLoduLcEKC3YYSJlZUcE1He/M2xceV+7dJEYljdwvQoGV69Tex4cd52hWvQxJPd++Ld+Rf2s= X-Received: by 2002:a92:afd5:: with SMTP id v82mr10590136ill.294.1573736275764; Thu, 14 Nov 2019 04:57:55 -0800 (PST) MIME-Version: 1.0 References: <20191106191803.15098-1-pbhagavatula@marvell.com> <20191111131914.16559-1-pbhagavatula@marvell.com> <20191111131914.16559-5-pbhagavatula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Thu, 14 Nov 2019 18:27:39 +0530 Message-ID: To: Ferruh Yigit Cc: Pavan Nikhilesh , Andrew Rybchenko , Jerin Jacob , Thomas Monjalon , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Nithin Dabilpuram , Kiran Kumar K , Rasesh Mody , Shahed Shaikh , Maciej Czekaj , Yong Wang , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 13, 2019 at 11:32 PM Ferruh Yigit wrote: > > On 11/11/2019 1:19 PM, pbhagavatula@marvell.com wrote: > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > > index 30c0379d4..8c1caac18 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -2402,6 +2402,9 @@ ixgbe_dev_configure(struct rte_eth_dev *dev) > > int ret; > > > > PMD_INIT_FUNC_TRACE(); > > + > > + dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH; > > + > > Hi Pavan, Andrew, Jerin, > > This is causing trouble when device is re-configured with its existing data, > because of the check in the ethdev [1]. > > This is for the case device configuration get, a few thing changed and > re-configured case, this is what is done in bonding and it is failing now. > > Do you have any suggestion for the solution? > > We can set this offload in PMDs only if 'ETH_MQ_RX_RSS_FLAG' set but same thing > still can caught us, if the initial configuration was with 'ETH_MQ_RX_RSS_FLAG' > but reconfigure is not. > > Or we can relax the check in 'rte_eth_dev_configure()' to log but not return error? IMO, We can relax the check as it is NOT at all critical for this flag. > > > > [1] > > @@ -1305,6 +1306,17 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t > nb_rx_q, uint16_t nb_tx_q, > goto rollback; > } > > + /* Check if Rx RSS distribution is disabled but RSS hash is enabled. */ > + if (((dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) == 0) && > + (dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_RSS_HASH)) { > + RTE_ETHDEV_LOG(ERR, > + "Ethdev port_id=%u config invalid Rx mq_mode without RSS but %s offload is > requested", > + port_id, > + rte_eth_dev_rx_offload_name(DEV_RX_OFFLOAD_RSS_HASH)); > + ret = -EINVAL; > + goto rollback; > + }