From: Jerin Jacob <jerinjacobk@gmail.com>
To: "Rong, Leyi" <leyi.rong@intel.com>
Cc: David Marchand <david.marchand@redhat.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore
Date: Thu, 5 Nov 2020 12:44:47 +0530 [thread overview]
Message-ID: <CALBAE1N06+S=p+gUeyMqTbDHni8fm95D1EMCBUnF3hr+z4juCQ@mail.gmail.com> (raw)
In-Reply-To: <SN6PR11MB2621BF73388866850C90F914ECEF0@SN6PR11MB2621.namprd11.prod.outlook.com>
On Wed, Nov 4, 2020 at 2:34 PM Rong, Leyi <leyi.rong@intel.com> wrote:
>
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Wednesday, November 4, 2020 4:43 PM
> > To: Rong, Leyi <leyi.rong@intel.com>
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; dev <dev@dpdk.org>
> > Subject: Re: [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore
> >
> > On Wed, Nov 4, 2020 at 9:34 AM Rong, Leyi <leyi.rong@intel.com> wrote:
> > > > -----Original Message-----
> > > > From: David Marchand <david.marchand@redhat.com>
> > > > Sent: Wednesday, November 4, 2020 4:14 PM
> > > > To: Rong, Leyi <leyi.rong@intel.com>
> > > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; dev <dev@dpdk.org>
> > > > Subject: Re: [PATCH] examples/l3fwd: enable multiple Tx queues on a
> > > > lcore
> > > >
> > > > If I count well, this is the v3 of the patch.
> > > > Please version your patches.
> > >
> > > The previous versions are set to superseded. As nothing changes with
> > > content on those versions, can start from this version?
> >
> > The commitlog changes even if the code itself did not change, so this is a
> > different patch.
> > Different patches mean different versions.
> > This shows that some work happened since the v1 submission.
> >
>
> Agreed.
> >
> > > As there always has thoughput limit for per queue, on some performance
> > > test case by using l3fwd, the result will limited by the per queue
> > > thoughput limit. With multiple Tx queue enabled, the per queue thoughput
> > limit can be eliminated if the CPU core is not the bottleneck.
> >
> > Ah interesting.
> > Which nic has such limitations?
> > How much of an improvement can be expected from this?
> >
> >
> > --
> > David Marchand
>
> The initial found was on XXV710 25Gb NIC, but suppose such issue can happen on more NICs
> as the high-end CPU per core boundary is higher than many NICs(except 100Gb and above) per queue performance boundary.
> The improvement can be about 1.8X with that case@1t2q.
As far as I understand, the Current l3fwd Tx queue creation is like this:
If the app has N cores and M ports then l3fwd creates, N x M Tx queues in total,
What will be new values based on this patch?
Does this patch has any regression in case the NIC queues able to cope
up with the throughput limit
from CPU.
>
> Leyi
>
next prev parent reply other threads:[~2020-11-05 7:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 7:28 Leyi Rong
2020-11-04 8:14 ` David Marchand
2020-11-04 8:34 ` Rong, Leyi
2020-11-04 8:43 ` David Marchand
2020-11-04 9:04 ` Rong, Leyi
2020-11-05 7:14 ` Jerin Jacob [this message]
2020-11-05 9:24 ` Rong, Leyi
2021-03-24 17:23 ` Thomas Monjalon
2021-03-25 5:38 ` Rong, Leyi
2021-03-25 8:10 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2020-11-02 8:12 Leyi Rong
2020-11-02 8:44 ` David Marchand
2020-11-02 5:29 Leyi Rong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1N06+S=p+gUeyMqTbDHni8fm95D1EMCBUnF3hr+z4juCQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=leyi.rong@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).