From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52BB0A0565; Mon, 23 Mar 2020 12:08:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BBF141C037; Mon, 23 Mar 2020 12:08:29 +0100 (CET) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id E6B4B1C036 for ; Mon, 23 Mar 2020 12:08:28 +0100 (CET) Received: by mail-il1-f193.google.com with SMTP id r5so7969559ilq.6 for ; Mon, 23 Mar 2020 04:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9XY++0WSecrxLQu8gZ9PdUvi17ohEnxlbMpI1shkBR0=; b=T+Urxh5rMUUT/RRcUZNT7Y8hyU+LhwJFmoTzpqrXSIz1LweyvZgIzQznxdQaf3tLuX h05en0uEWekqAcDHF0/ygn1n0FqpxtbDAb1Rj8Czqrbk3rpv1IXL8/kY8vZwPKqbp8RA wFbCSNvYXfHfvS2Sk76I9pCW/vEof3n+9U/muTl+KDbq3RihmNvGiLfIL/fh+FYresHm W/PLfYds89MZX11NxR/e8cIJXv0gQiRQDKYWgHI3xBmZX5pq2ODshie6pa6NMQN6vkY8 +ULyJm7cUSI/sCarOxFTZ7srKChMu48olYnJ9713BlZttBadXgwLv8YJC1O7kQ+FOsfv KYSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9XY++0WSecrxLQu8gZ9PdUvi17ohEnxlbMpI1shkBR0=; b=EWbPGy2oa2VknspRSQFTP3S8IbISxpUEzcwIi+oTmUV155JhQxLb1jlaNe4SKgNyXx Sm1jcCY8E9UGOIlpPmfPI4qhoQ6YLgKp3Bf+D0ogtLQIofJA7TwVuCuZUBxFWJIJF/qU 1roV7edzmDjaFGy25wbMsg8f5VZ20mCUgeSSJwbMnU6AsGoKdGxAJlY3d78fhtAYw3ZH iRMKy9oCXe6lGwHIJIMRiKcsg/md+T6IFcYdDDVqnXsye1czZeteyxlSZtDyyeQ2VjFa r2cIgc89EshZzQNSyldmZoFUm2VwanbEybSynyolEjEV8P0Zp7vYGPKd02QdSouRkp8N pUEw== X-Gm-Message-State: ANhLgQ1BebMB0+U6GoiUr//cAvDDkCvGWFtdyDOb2w0hYv6UfTlsfjJl 5xI27111TzUfM0QwfLH4N/w0OrowZ59I2Yw2hsI= X-Google-Smtp-Source: ADFU+vvgDbGFuO9O5X53JTzNI2wy5xVQ6fDUcMTxB0/L3qXhd/VnOeIpJINqmnp4+ArnF9j5/K+WPnW3kLHgRUBiuYs= X-Received: by 2002:a05:6e02:90:: with SMTP id l16mr14594455ilm.294.1584961708156; Mon, 23 Mar 2020 04:08:28 -0700 (PDT) MIME-Version: 1.0 References: <20200318190241.3150971-1-jerinj@marvell.com> <20200318190241.3150971-11-jerinj@marvell.com> <98CBD80474FA8B44BF855DF32C47DC35C60EF3@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C60EF3@smartserver.smartshare.dk> From: Jerin Jacob Date: Mon, 23 Mar 2020 16:38:11 +0530 Message-ID: To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Jerin Jacob , Sunil Kumar Kori , dpdk-dev , Thomas Monjalon , "Richardson, Bruce" , David Marchand , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1 10/32] eal/trace: implement debug dump function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 23, 2020 at 4:26 PM Morten Br=C3=B8rup wrote: > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of jerinj@marvell.com > > Sent: Wednesday, March 18, 2020 8:02 PM > > > > From: Jerin Jacob > > > > Implement rte_trace_metadata_dump() and rte_trace_dump() > > functions. Former one used to dump the CTF metadata file and > > the latter one to dump all the registered events and its status. > > > > Signed-off-by: Jerin Jacob > > Signed-off-by: Sunil Kumar Kori > > --- > > lib/librte_eal/common/eal_common_log.c | 9 +-- > > lib/librte_eal/common/eal_common_trace.c | 63 ++++++++++++++++++ > > lib/librte_eal/common/eal_common_trace_ctf.c | 67 ++++++++++++++++++++ > > lib/librte_eal/common/eal_private.h | 3 + > > lib/librte_eal/rte_eal_version.map | 2 + > > 5 files changed, 140 insertions(+), 4 deletions(-) > > > > diff --git a/lib/librte_eal/common/eal_common_log.c > > b/lib/librte_eal/common/eal_common_log.c > > index c0efd5214..d8f7feb32 100644 > > --- a/lib/librte_eal/common/eal_common_log.c > > +++ b/lib/librte_eal/common/eal_common_log.c > > @@ -372,8 +372,8 @@ RTE_INIT_PRIO(rte_log_init, LOG) > > rte_logs.dynamic_types_len =3D RTE_LOGTYPE_FIRST_EXT_ID; > > } > > > > -static const char * > > -loglevel_to_string(uint32_t level) > > +const char * > > +eal_loglevel_to_string(uint32_t level) > > Making this function public, rte_ is probably a better prefix than eal_. Not making it as public function(i.e not updated in .map file). It is an EAL private function, whose scope is limited only to the EAL library. > > There are some functions missing rte_ prefix in eal_private.h, but there'= s no need to add more. > > -Morten