From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B224943BD2; Sun, 25 Feb 2024 16:40:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 513EE402C8; Sun, 25 Feb 2024 16:40:18 +0100 (CET) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by mails.dpdk.org (Postfix) with ESMTP id CE78B402BA for ; Sun, 25 Feb 2024 16:40:16 +0100 (CET) Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-42e78c39ff0so6859881cf.0 for ; Sun, 25 Feb 2024 07:40:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708875616; x=1709480416; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4M9I18OCXTx7u/J4YTq2Smu1l3gl1swj1Yi4HcP1M1o=; b=IeYhH4p5+22QD/JxMyYVBDqDs3WyfpLRHrrMC/sdUx+nN4vR/xJtlQclaHJ0dV2en4 LjZjTAr4Maactrqyy2eGNf8yBiMwHsgPZ92Li5PpBzwHzQuCQMQW3um32NZ6ztw1dZSN 6mrL55ZsOCviGOyqKFzVl+UTYNNpQZvdg8t32JVNxXzWyo0UCsCxTTHdjUdzKSS6XeX1 4uW/ChSDxqUXHbXjUhS/ua3oZSq1l8F3te9vZT9ZbEgUL+SkhjRy8s+Nm3ux3fFiXtCk t7/bI/84ntxw7+cuqG6wHgU+Svrz1rs8Jf4pgJIyJipDj6YRmNeScKOTd5CKTeS2qF8e BAow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708875616; x=1709480416; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4M9I18OCXTx7u/J4YTq2Smu1l3gl1swj1Yi4HcP1M1o=; b=TVawDMzBu7ZYADvl2aAcH6NU0deQ30ilyfpFoLBMks06g9BsFqISnCoeitHoh1N4ul GE1bH4Mn00xw/ZIzf+BOCtrHhFM3DjC+tmeTR8GlvlU7AC9VOBICQUZ2EEri5WVpEAdW DjjTzeL6Lg4Fsdjkn/phvhmwonPGAlqii7j14JIBw6mifkmZ2nBeX/Qo2MxQ/er6otMv cxFg8cijYYU1sZhLUgjRvutByWW67ybiPmTjvTXjzjAfrrg2frbG7+RjCLTQhtkIQqZ0 y/Vlhq682xSM/MO77lOcKFn6l79fquaQ1I0otPwm9silJ1PzhbfCmTNZZZqaQYkiYcrz PTAg== X-Gm-Message-State: AOJu0Yzp7j9IYQTbsRj1sP+hzLSxuhz7InQAwG1xy0fVbO9smSoT8FvD rbbVlMlVPiiBJC/vpFU8SHXlvY8iuPekJuH4YJ6bCVeVDLqE9eZfZSFs3SpY3mAN6uUl+RWAGnL pCpFXldsIDPjjR62F+TYLNR0lxiE= X-Google-Smtp-Source: AGHT+IGPsGHoCGXfUn7jZwREESXzPk2tN9ovpUJs6FXeYb4Ae65t9JqIqs2OR4sHJa51QRvu3pcBTuLprJcPFSZ6dso= X-Received: by 2002:ac8:5783:0:b0:42e:6b2f:e7 with SMTP id v3-20020ac85783000000b0042e6b2f00e7mr7566485qta.26.1708875616040; Sun, 25 Feb 2024 07:40:16 -0800 (PST) MIME-Version: 1.0 References: <20240223153938.1393597-1-vattunuru@marvell.com> In-Reply-To: <20240223153938.1393597-1-vattunuru@marvell.com> From: Jerin Jacob Date: Sun, 25 Feb 2024 21:09:50 +0530 Message-ID: Subject: Re: [PATCH 1/1] net/octeon_ep: use devarg to enable ISM accesses To: Vamsi Attunuru Cc: dev@dpdk.org, jerinj@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 23, 2024 at 9:35=E2=80=AFPM Vamsi Attunuru wrote: > > Adds a devarg option to enable/disable ISM memory accesses > for reading packet count details. This option is disabled > by default, as ISM memory accesses effect throughput of > bigger size packets. > > Signed-off-by: Vamsi Attunuru > --- > doc/guides/nics/octeon_ep.rst | 12 ++++++++ > drivers/net/octeon_ep/cnxk_ep_rx.h | 42 +++++++++++++++++++++----- > drivers/net/octeon_ep/cnxk_ep_tx.c | 42 ++++++++++++++++++++++---- > drivers/net/octeon_ep/cnxk_ep_vf.c | 4 +-- > drivers/net/octeon_ep/otx2_ep_vf.c | 4 +-- > drivers/net/octeon_ep/otx_ep_common.h | 14 +++++++-- > drivers/net/octeon_ep/otx_ep_ethdev.c | 43 +++++++++++++++++++++++++++ > drivers/net/octeon_ep/otx_ep_rxtx.c | 15 ++++++---- > drivers/net/octeon_ep/otx_ep_rxtx.h | 2 ++ > 9 files changed, 153 insertions(+), 25 deletions(-) > > diff --git a/doc/guides/nics/octeon_ep.rst b/doc/guides/nics/octeon_ep.rs= t > index b5040aeee2..befa0a4097 100644 > --- a/doc/guides/nics/octeon_ep.rst > +++ b/doc/guides/nics/octeon_ep.rst > @@ -11,6 +11,18 @@ and **Cavium OCTEON** families of adapters in SR-IOV c= ontext. > More information can be found at `Marvell Official Website > `_. > > +Runtime Config Options > +---------------------- > + > +- ``Rx&Tx ISM memory accesses enable`` (default ``0``) > + > + PMD supports 2 modes for checking Rx & Tx packet count, PMD may read = the packet count directly 2 =E2=86=92 two > + from hardware registers or it may read from ISM memory, this may be s= elected at runtime > + using ``ism_enable`` ``devargs`` parameter. Furthermore, tell why someone needs to choose one vs. others > + > + For example:: > + > + -a 0002:02:00.0,ism_enable=3D1 > 1) Update release notes new PMD feature 2) Missing updates to RTE_PMD_REGISTER_PARAM_STRING for devargs