From: Jerin Jacob <jerinjacobk@gmail.com>
To: Kiran Kumar K <kirankumark@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: set max vtag insertion size
Date: Tue, 29 Sep 2020 13:33:48 +0530 [thread overview]
Message-ID: <CALBAE1N4831GTU6Lk1GcxKNfNAUuwW-fA1Y03HJE=oVr3aAHtw@mail.gmail.com> (raw)
In-Reply-To: <20200821065930.191028-1-kirankumark@marvell.com>
On Fri, Aug 21, 2020 at 12:29 PM <kirankumark@marvell.com> wrote:
>
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> When TX side VTAG insertion is enabled, As we are not setting the max
> vtag insertion size an interrupt has been received. This patch will fix
> the issue by configuring the max vtag insertion size to 8B.
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
Updated git comment to provide more detail while applying:
``
net/octeontx2: set max vtag insertion size
When TX side VTAG insertion is enabled, SMQ should be configured with
the maximum VTAG insertion size to avoid generating NIX_SQINT_SEND_ERR
interrupt. Since the default value is zero, This patch configures the
VTAG insertion size to the max supported value.
Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
``
Applied to dpdk-next-net-mrvl/main. Thanks
> ---
> drivers/net/octeontx2/otx2_tm.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/octeontx2/otx2_tm.c b/drivers/net/octeontx2/otx2_tm.c
> index 8ed059549..b76242a60 100644
> --- a/drivers/net/octeontx2/otx2_tm.c
> +++ b/drivers/net/octeontx2/otx2_tm.c
> @@ -560,8 +560,9 @@ populate_tm_reg(struct otx2_eth_dev *dev,
> * smaller
> */
> reg[k] = NIX_AF_SMQX_CFG(schq);
> - regval[k] = BIT_ULL(50) | NIX_MIN_HW_FRS;
> - regval_mask[k] = ~(BIT_ULL(50) | 0x7f);
> + regval[k] = BIT_ULL(50) | ((uint64_t)NIX_MAX_VTAG_INS << 36) |
> + NIX_MIN_HW_FRS;
> + regval_mask[k] = ~(BIT_ULL(50) | (0x7ULL << 36) | 0x7f);
> k++;
>
> /* Parent and schedule conf */
> --
> 2.25.1
>
prev parent reply other threads:[~2020-09-29 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 6:59 kirankumark
2020-09-29 8:03 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1N4831GTU6Lk1GcxKNfNAUuwW-fA1Y03HJE=oVr3aAHtw@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).