From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2898542CA5; Tue, 13 Jun 2023 17:53:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0195040C35; Tue, 13 Jun 2023 17:53:35 +0200 (CEST) Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by mails.dpdk.org (Postfix) with ESMTP id 1D0DB40A8A for ; Tue, 13 Jun 2023 17:53:34 +0200 (CEST) Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-462e3a806cbso1951186e0c.3 for ; Tue, 13 Jun 2023 08:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686671613; x=1689263613; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VhcSkqvHTeZf8Ry2+Jde4gF1kWae4ucib7GR65UNhbw=; b=qGDwnU47kG+XAaD6InOED+hi2Ko86AENM8sTHx0ZOmYhFaalfQVyEg4w+YBbWu1NwK /CDFL1RU6P6QL8ay82muAysI/yo7kSleBWdHGuSvo7jC9yg3iDYofhyZJb5DX9x9iCPn +JeXqwefe2JYHIONhfZo3dLxIuw9oClXoH36BfSA/ojsrk1UisN91hp14sWL+13ZUtN/ Zwtmqr8yAR0kwlB2WGxzChb6tK6j409eiPtnz7YaHL7RJiygeOxXaneZ/ooPM/pil9q1 roMiqXujF49NI+ocvJM2nBTyQx1ca2Bm3vsG0PCceByYeZKl6ofmiqauoAEp3Ji1oBeH n0SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686671613; x=1689263613; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VhcSkqvHTeZf8Ry2+Jde4gF1kWae4ucib7GR65UNhbw=; b=K007WO4RUvp7cJ4Ckw2vO2WMXoLjgoIyXa7ohH9D6uaE9ib/H1C92001CuhZIUOP21 Q23Y0IJhrq5R/K2XRgJ/kmPdgRQ7IC+co24Lg18+YvxP0OZ2OXZEWaFCrV3QZAYAnKRG kLWpQHv1tgrFx/jPZYMQR2+Waf9Q130v4ad8o3ip+EsvM47Yn8YQuDHYgCkvNTfXcU98 E6RL7sg+yBRNWlwoscHjDvd7Mv1Z5SazVT6gz0syjQrMiHKzhhg2MV9v41v2/2rY6OFA JnBKkEXe9tMXdOWpuC05ivfgVc6+J6Hwf3Z3YqmzeF6GT/kyxAMDQcxsa8k9kZfgfuun eDZQ== X-Gm-Message-State: AC+VfDxE1X8LesTZVHTO+HCIoVC9GTMIGH/f3UFjbSZ4pB1wV7jiHejq gtXgMU7SQtI48ZFDa/sY1HMQ60w8+mS3aS8wfi1Gh+CVq14= X-Google-Smtp-Source: ACHHUZ5IwreXMkmd+2lkoOtYw+fFT9ME7Z9jm+exDi46ns/bLxjFSn7Mey+h05VSQBrxTtlzGLn+5VrBtDMvmr+5gWI= X-Received: by 2002:a1f:bf53:0:b0:46e:1043:fb7d with SMTP id p80-20020a1fbf53000000b0046e1043fb7dmr1415983vkf.2.1686671611844; Tue, 13 Jun 2023 08:53:31 -0700 (PDT) MIME-Version: 1.0 References: <20230420100803.494-1-viacheslavo@nvidia.com> <20230420100803.494-3-viacheslavo@nvidia.com> In-Reply-To: From: Jerin Jacob Date: Tue, 13 Jun 2023 21:23:05 +0530 Message-ID: Subject: Re: [RFC 2/5] common/mlx5: introduce tracepoints for mlx5 drivers To: Slava Ovsiienko Cc: "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 13, 2023 at 9:20=E2=80=AFPM Slava Ovsiienko wrote: > > Hi, > > <..snip..> > > > > > > mlx5_os_interrupt_handler_create; # WINDOWS_NO_EXPORT > > > mlx5_os_interrupt_handler_destroy; # WINDOWS_NO_EXPORT > > > + > > > + __rte_pmd_mlx5_trace_tx_entry; > > > + __rte_pmd_mlx5_trace_tx_exit; > > > + __rte_pmd_mlx5_trace_tx_wqe; > > > + __rte_pmd_mlx5_trace_tx_wait; > > > + __rte_pmd_mlx5_trace_tx_push; > > > + __rte_pmd_mlx5_trace_tx_complete; > > > > No need to expose these symbols. It is getting removed from rest of DPD= K. > > Application can do rte_trace_lookup() to get this address. > > > > > It is not for application, it is for PMD itself, w/o exposing the symbols= build failed. PMD is implementing this trace endpoints, not consuming this trace point. Right? If so, Why to expose these symbols? > > With best regards, > Slava >