Re: [PATCH] dma/cnxk: add higher chunk size support

[Jerin Jacob <jerinjacobk@gmail.com>]

On Wed, May 22, 2024 at 8:15 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Add support to configure higher chunk size by using the new
> OPEN_V2 mailbox, this improves performance as the number of
> mempool allocs are reduced.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> ---
>  drivers/common/cnxk/roc_dpi.c      | 39 ++++++++++++++++++++++++++++++
>  drivers/common/cnxk/roc_dpi.h      |  2 ++
>  drivers/common/cnxk/roc_dpi_priv.h |  1 +
>  drivers/common/cnxk/version.map    |  1 +
>  drivers/dma/cnxk/cnxk_dmadev.c     | 31 ++++++++++++++++--------
>  drivers/dma/cnxk/cnxk_dmadev.h     |  1 +

New feature spotted, please update release note for PMD specific API.

>  6 files changed, 65 insertions(+), 10 deletions(-)

> +
> +int
> +roc_dpi_configure_v2(struct roc_dpi *roc_dpi, uint32_t chunk_sz, uint64_t aura, uint64_t chunk_base)
> +{
> +       struct plt_pci_device *pci_dev;
> +       dpi_mbox_msg_t mbox_msg;
> +       uint64_t reg;
> +       int rc;
> +
> +       if (!roc_dpi) {
> +               plt_err("roc_dpi is NULL");
> +               return -EINVAL;
> +       }
> +
> +       pci_dev = roc_dpi->pci_dev;
> +
> +       roc_dpi_disable(roc_dpi);
> +       reg = plt_read64(roc_dpi->rbase + DPI_VDMA_SADDR);
> +       while (!(reg & BIT_ULL(63)))
> +               reg = plt_read64(roc_dpi->rbase + DPI_VDMA_SADDR);

Is timeout needed?