From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2233CA0093; Mon, 18 May 2020 13:10:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E37FD1D426; Mon, 18 May 2020 13:10:40 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 24ACE1D414 for <dev@dpdk.org>; Mon, 18 May 2020 13:10:39 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id d7so10102116ioq.5 for <dev@dpdk.org>; Mon, 18 May 2020 04:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=53ZCKw7Ba4pxTe7mo0+dhYfKIrU0uD+1MxlcQu9MzB4=; b=dfywWOWarGDtcABHRjURt9hLxsMEKjozs0FEj7I1G+FdRJUyWvhNvdBjuxO+c/8c2m +DlK9rOmJ77w4ds7FzcZZREdG8OHcUh6FxoSkJxYIPE2+wrZbJy8NIBQN/joiOvlfB6Q IPnMBfsGSszejOa8xNa5cg8hlI7rhNjb7duR7cIn40fd4JSHivYmb9eWFBabI/qIz9+Z /Gy9TD8HcMyiX1/RSnK0N9E8tLXHgqDfqEWwfqQAX/BE7faPU8QnnL/Mco8sWFdY/1va v2uF/07d2Dzj08E1FEuwdEmoX6LtyrnrByTtsTFFawiPXpdXsRmtTzy4h9GVQqepy97M DQ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=53ZCKw7Ba4pxTe7mo0+dhYfKIrU0uD+1MxlcQu9MzB4=; b=qzbOwLPFxON2S1gdBufnBm//ZvxcDqVk9g26N69lNbQ1jhT7Swh/swwzBCBZ53auG7 Qg+5EXgTZouGquirT5Gkc2PO4rP4xEieyFJIo6ETsH0skoPAAjPi2j7zBsYpgNlOB9K3 en19v93Pr465iAsBf/JMOvnRqZiEVp7xPegrplZ2xDYOV3yYKoFGqS3BNf+pJrr/ed2B KAj9/441J5jDDEMZlq62tqTHFMs/KcEZ75rSb3YkEs2AHTDcjRpd9IFoTVaGUf0WOsqy 6HecySl7LA8aKeLu2222/Ptc9XCk0KeykbGYG0ZQXuiVfpwqKSuRlkIG3wcOKS8q3rdE erCQ== X-Gm-Message-State: AOAM532QkNVQMxEwSqWLxI37LZRc90INPFMXxkphQiHpz7bDmCzkxStH O3j3LWudi3emIthmyo5L5b0O3tQ1q9sWud2vzfc= X-Google-Smtp-Source: ABdhPJwczYiRh3qKZsSCLRl8LMVo8qipwBv5QEyeKflH5h4VedHKG/oRFjea1Htid9o4uMm6kpjXeip2qr1rK9vrKrg= X-Received: by 2002:a05:6638:217b:: with SMTP id p27mr12523462jak.60.1589800237145; Mon, 18 May 2020 04:10:37 -0700 (PDT) MIME-Version: 1.0 References: <20200419100133.3232316-1-jerinj@marvell.com> <20200422190349.3768487-1-jerinj@marvell.com> <20200422190349.3768487-32-jerinj@marvell.com> <VI1PR0502MB40455E904731B66D1BE8B3F8BFB80@VI1PR0502MB4045.eurprd05.prod.outlook.com> In-Reply-To: <VI1PR0502MB40455E904731B66D1BE8B3F8BFB80@VI1PR0502MB4045.eurprd05.prod.outlook.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Mon, 18 May 2020 16:40:21 +0530 Message-ID: <CALBAE1N4jSydrgJj7Lx2S0n+4LeSvc9Sj5DXNUzeuNvF9vGeLw@mail.gmail.com> To: Fady Bader <fady@mellanox.com> Cc: "jerinj@marvell.com" <jerinj@marvell.com>, Olivier Matz <olivier.matz@6wind.com>, Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>, "skori@marvell.com" <skori@marvell.com> Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7 31/32] mempool: add tracepoints X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Mon, May 18, 2020 at 3:15 PM Fady Bader <fady@mellanox.com> wrote: > > Hi, > I'm trying to build this patch on Windows and I'm getting a compilation error because the sizes of long and size_t vary on Windows (see comments down below). > > > -----Original Message----- > > From: dev <dev-bounces@dpdk.org> On Behalf Of jerinj@marvell.com > > Sent: Wednesday, April 22, 2020 10:04 PM > > To: Olivier Matz <olivier.matz@6wind.com>; Andrew Rybchenko > > <arybchenko@solarflare.com> > > Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; > > bruce.richardson@intel.com; david.marchand@redhat.com; > > mattias.ronnblom@ericsson.com; skori@marvell.com > > Subject: [dpdk-dev] [PATCH v7 31/32] mempool: add tracepoints > > > > From: Sunil Kumar Kori <skori@marvell.com> > > > > Add tracepoints at important and mandatory APIs for tracing support. > > > > Signed-off-by: Sunil Kumar Kori <skori@marvell.com> > > --- > > lib/librte_mempool/Makefile | 3 + > > lib/librte_mempool/mempool_trace_points.c | 108 +++++++++++++ > > lib/librte_mempool/meson.build | 5 +- > > lib/librte_mempool/rte_mempool.c | 16 ++ > > lib/librte_mempool/rte_mempool.h | 13 ++ > > lib/librte_mempool/rte_mempool_ops.c | 7 + > > lib/librte_mempool/rte_mempool_trace.h | 178 > > +++++++++++++++++++++ > > lib/librte_mempool/rte_mempool_trace_fp.h | 116 ++++++++++++++ > > lib/librte_mempool/rte_mempool_version.map | 26 +++ > > 9 files changed, 470 insertions(+), 2 deletions(-) create mode 100644 > > lib/librte_mempool/mempool_trace_points.c > > create mode 100644 lib/librte_mempool/rte_mempool_trace.h > > create mode 100644 lib/librte_mempool/rte_mempool_trace_fp.h > > > > diff --git a/lib/librte_mempool/rte_mempool_trace.h > > b/lib/librte_mempool/rte_mempool_trace.h > > new file mode 100644 > > index 000000000..16b115a69 > > --- /dev/null > > +++ b/lib/librte_mempool/rte_mempool_trace.h > > @@ -0,0 +1,178 @@ > > +RTE_TRACE_POINT( > > + rte_mempool_trace_populate_iova, > > + RTE_TRACE_POINT_ARGS(struct rte_mempool *mempool, void > > *vaddr, > > + rte_iova_t iova, size_t len, void *free_cb, > > + void *opaque), > > + rte_trace_point_emit_ptr(mempool); > > + rte_trace_point_emit_string(mempool->name); > > + rte_trace_point_emit_ptr(vaddr); > > + rte_trace_point_emit_u64(iova); > > + rte_trace_point_emit_long(len); > > Long and size_t have different sizes in 64 bit Windows. Long is 4 bytes > while size_t is 8. I'm trying to make the code compatible for both Linux > and Windows, How do you recommend doing that ? Probably introduce rte_trace_point_emit_size_t. > > > + rte_trace_point_emit_ptr(free_cb); > > + rte_trace_point_emit_ptr(opaque); > > +) > > + > > Regards, > Fady Bader