From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E1EF438A1; Fri, 12 Jan 2024 10:29:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 519CA402AC; Fri, 12 Jan 2024 10:29:34 +0100 (CET) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by mails.dpdk.org (Postfix) with ESMTP id 6099E4028C for ; Fri, 12 Jan 2024 10:29:33 +0100 (CET) Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-dbed729a4f2so5531009276.2 for ; Fri, 12 Jan 2024 01:29:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705051773; x=1705656573; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OTer1zXGkVagCL9o3cCuvdhOtaoJjly23QgsWBQuThs=; b=VXsWJqyKDVASV+qZlWDfQiW+udmZ6Ixmzito+w4Svr/DMNdFrqPqlLcFql1Rjtg22b Gb6EobvspDXAjf+aSr2fTiOBWxdra3FvGb+03UcgApU3XWjgjsNl6tGYsJicoRWMPSqw EOlaGUsYZMxO/6nwM87TKXy4oIcD3Axh2nK9vqt3l+kS9FTayHcuyABVf7sN1gzWXIWB wcV27KoDfLiIqysnszmeeHHOnq1DK90eLI2IUY94zxsiaU7CkCRJrIdXPfBrrQthLHVQ F9u3fK0OyT6vP3FbkyfNtuZ2U79OGqpxCKUsYp3HqWO5HKoSnR/wq1fM65EVEK1AHdgA W8Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705051773; x=1705656573; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OTer1zXGkVagCL9o3cCuvdhOtaoJjly23QgsWBQuThs=; b=UBgw7kbII3ZfJoB2dJuTK/FvR1i9Zjt+ylVPo49Kgimp5W4RS8LJ97ILPDu0bnFtP+ tHlkVJWE7QFv9IeolNPf8Ve3uBEf7u8KZxZVLTEPvHIHABU1Pvr22W/+7M8OSowkIs2j RqSuI96dnKGqYnFOcwHhLBFfv0VfE2TQ81hkfsQvrqExdqPWGAbJoR0XA3nCK1bVvNDG QQj3XyycqIo9lRp277EPTRknY6C6+Fc02VZKrnAZ4c+1alevvCiZrtEt473wPyK3fdkG gAltT2UZ7G6U4Umr699UAW4pT3AMAQrIcvVjtHT+/1PpB3GgW9D9Tod5h24MgzZpHDBV N5wA== X-Gm-Message-State: AOJu0Yw/YLUwsT208P33Mcyj8yBfgjzGTOYR3YlvOaBktDp3o5k8yXfv +ntLbTapydZPP6pELXo0BhoEeYSid6PeHjIKpVM= X-Google-Smtp-Source: AGHT+IG6KjOIpZtLUVdiA5oLgKvoX9/oUg335TNPAduGKkvAv7tKKKa5HRBjS3pICtb5k63l53QuZmTVS95b+Le3EEE= X-Received: by 2002:a25:d7c3:0:b0:dbe:ac11:e0f1 with SMTP id o186-20020a25d7c3000000b00dbeac11e0f1mr412101ybg.40.1705051772559; Fri, 12 Jan 2024 01:29:32 -0800 (PST) MIME-Version: 1.0 References: <20231219172948.3909749-1-jerinj@marvell.com> <20240111151745.3800170-1-jerinj@marvell.com> In-Reply-To: From: Jerin Jacob Date: Fri, 12 Jan 2024 14:59:05 +0530 Message-ID: Subject: Re: [dpdk-dev] [v1] ethdev: support Tx queue used count To: David Marchand Cc: jerinj@marvell.com, dev@dpdk.org, Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , ferruh.yigit@xilinx.com, ajit.khaparde@broadcom.com, aboyer@pensando.io, beilei.xing@intel.com, bruce.richardson@intel.com, chas3@att.com, chenbo.xia@intel.com, ciara.loftus@intel.com, dsinghrawat@marvell.com, ed.czeck@atomicrules.com, evgenys@amazon.com, grive@u256.net, g.singh@nxp.com, zhouguoyang@huawei.com, haiyue.wang@intel.com, hkalra@marvell.com, heinrich.kuhn@corigine.com, hemant.agrawal@nxp.com, hyonkim@cisco.com, igorch@amazon.com, irusskikh@marvell.com, jgrajcia@cisco.com, jasvinder.singh@intel.com, jianwang@trustnetic.com, jiawenwu@trustnetic.com, jingjing.wu@intel.com, johndale@cisco.com, john.miller@atomicrules.com, linville@tuxdriver.com, keith.wiles@intel.com, kirankumark@marvell.com, oulijun@huawei.com, lironh@marvell.com, longli@microsoft.com, mw@semihalf.com, spinler@cesnet.cz, matan@nvidia.com, matt.peters@windriver.com, maxime.coquelin@redhat.com, mk@semihalf.com, humin29@huawei.com, pnalla@marvell.com, ndabilpuram@marvell.com, qiming.yang@intel.com, qi.z.zhang@intel.com, radhac@marvell.com, rahul.lakkireddy@chelsio.com, rmody@marvell.com, rosen.xu@intel.com, sachin.saxena@oss.nxp.com, skoteshwar@marvell.com, shshaikh@marvell.com, shaibran@amazon.com, shepard.siegel@atomicrules.com, asomalap@amd.com, somnath.kotur@broadcom.com, sthemmin@microsoft.com, steven.webster@windriver.com, skori@marvell.com, mtetsuyah@gmail.com, vburru@marvell.com, viacheslavo@nvidia.com, xiao.w.wang@intel.com, cloud.wangxiaoyun@huawei.com, yisen.zhuang@huawei.com, yongwang@vmware.com, xuanziyang2@huawei.com, cristian.dumitrescu@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 12, 2024 at 1:33=E2=80=AFPM David Marchand wrote: > > Hi Jerin, > > On Thu, Jan 11, 2024 at 4:32=E2=80=AFPM wrote: > > > > From: Jerin Jacob > > > > Introduce a new API to retrieve the number of used descriptors > > in a Tx queue. Applications can leverage this API in the fast path to > > inspect the Tx queue occupancy and take appropriate actions based on th= e > > available free descriptors. > > > > A notable use case could be implementing Random Early Discard (RED) > > in software based on Tx queue occupancy. > > > > Signed-off-by: Jerin Jacob > > --- > > doc/guides/nics/features.rst | 10 ++++ > > doc/guides/nics/features/default.ini | 1 + > > lib/ethdev/ethdev_driver.h | 2 + > > lib/ethdev/ethdev_private.c | 1 + > > lib/ethdev/ethdev_trace_points.c | 3 ++ > > lib/ethdev/rte_ethdev.h | 74 ++++++++++++++++++++++++++++ > > lib/ethdev/rte_ethdev_core.h | 7 ++- > > lib/ethdev/rte_ethdev_trace_fp.h | 8 +++ > > lib/ethdev/version.map | 3 ++ > > 9 files changed, 108 insertions(+), 1 deletion(-) > > We need some libabigail suppression rule for the reserved2 field update. > Looking at some previous rules, something like below can do the trick. > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 21b8cd6113..ba240f74d5 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -33,3 +33,6 @@ > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > ; Temporary exceptions till next major ABI version ; > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > +[suppress_type] > + name =3D rte_eth_fp_ops > + has_data_member_inserted_between =3D {offset_of(reserved2), end} Thanks David. will fix in v2. > > -- > David Marchand >