From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B8DBA059B; Fri, 10 Apr 2020 11:05:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1B4C1D416; Fri, 10 Apr 2020 11:05:06 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 51EB61D40F for ; Fri, 10 Apr 2020 11:05:05 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id n20so1162208ioa.4 for ; Fri, 10 Apr 2020 02:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ULMa81lJlFjTbhsVWTdqzH6YOBNX3LQFsPYRtu2C9NQ=; b=VQ/OUYoA3re9g4n1Byljy91PI2kEpvAjBhHrs4SK5FoH+uezCoMui2c51/RV5j5EXt kolNrdFMTvJwewKVvaNW8PpFfr/Qf3N6iXZA4FotDpWTWrPB31ISDJwPU+3YCkGRhyEo Ks+8egPeoUn2MsSm3Sw2cNzGpdlhZhVyDT/+5PqUAbfdynL7t2cQnWz99oDjZnexdLmW zApePAUkEIDhoKVGNfDYfRbZd17xltmvfmSsZRmwmifER6yeR+Gox+fA6sYUZap7GsXL D7UEHbvZjPXHyVOSw1u4dRaOW9vm/rJCMeYg3m9SnH5eEzjA8DP45+51v/7ue+ZrAlbI kHgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ULMa81lJlFjTbhsVWTdqzH6YOBNX3LQFsPYRtu2C9NQ=; b=Rb0G3anbmIBMYLLQwQKuizSxCPzMGsPLHRVKevtMVbFA+leN6NpiLDHM0+YThk7Y3B aXXCmCOpXkvOseeh4EbkX9f1kvzDb9wvQ/e8ajxeFESV+gy8SDh/hHmTC06YEvwppy+s LoNk1QyvgQ3Tfwa1zdp0asdAM0805YbtwkzwqlkeyCYPuWUl6oI/DQUsg8xbK9b7euzc z0wiMY5A+GVsbb+nyfDbx/rdObK0ZgINj9EOoBaW1pH39CzZYDykHZ+cC+KiP90RDDkF iMRoUmeCEonu2/COPjiC2RJJtdQYoKPcdunw9aAWBL1tM9UL0ldLHP26wA0bsraRzQDk AO/w== X-Gm-Message-State: AGi0PubI0T1DrWj4CBhdluMAQ9LJH8+H+YW7sKYAXo4DiMo/CZ50dFfN tbILzyHUabACjoq2XlXFMdP3rid4gMXl2VLp8Qg= X-Google-Smtp-Source: APiQypLVWDOJ3A1Gk1hdtQ8JXJ2bpsZSpMM7pZ9DSfWmMXQXOw7GJS6nb9n5Yf2hxQ8gCZTtSACQpQ4HlG7Uc3UEtnY= X-Received: by 2002:a02:a412:: with SMTP id c18mr3579690jal.113.1586509504581; Fri, 10 Apr 2020 02:05:04 -0700 (PDT) MIME-Version: 1.0 References: <20191025125118.47189-1-ferruh.yigit@intel.com> <5defdf9b-7c1d-f4e2-9bd7-6de55ef452e5@intel.com> <1689523.vCJZsxu672@thomas> In-Reply-To: <1689523.vCJZsxu672@thomas> From: Jerin Jacob Date: Fri, 10 Apr 2020 14:34:48 +0530 Message-ID: To: Thomas Monjalon Cc: Ferruh Yigit , John McNamara , Marko Kovacevic , dpdk-dev , Andrew Rybchenko , Adrien Mazarguil , Ajit Khaparde , Jerin Jacob , Ori Kam Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 10, 2020 at 2:26 PM Thomas Monjalon wrote: > > 10/04/2020 10:44, Ferruh Yigit: > > On 10/25/2019 2:39 PM, Jerin Jacob wrote: > > > On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon wrote: > > >> > > >> 25/10/2019 14:51, Ferruh Yigit: > > >>> "Flow API" is a method/API to implement various filtering features, on > > >>> its own it doesn't give much context on what features are provided. And > > >>> it is not really a feature, so doesn't fit into feature table. > > >>> > > >>> Also since other filtering related APIs, 'filter_ctrl', has been > > >>> deprecated, flow API is the only supported way in the DPDK to implement > > >>> filtering options, if related filter options announced by PMDs, listing > > >>> "Flow API" as implemented is redundant information. > > >> > > >> I fully agree with this explanation. > > >> rte_flow is the only supported API for flow offloads. > > >> That's why we must remove the legacy API. > > >> > > >>> Signed-off-by: Ferruh Yigit > > >>> --- > > >>> --- a/doc/guides/nics/features/default.ini > > >>> +++ b/doc/guides/nics/features/default.ini > > >>> -Flow API = > > >> > > >> Acked-by: Thomas Monjalon > > > > > > # Need to remove "Flow API" from doc/guides/nics/features.rst > > > > +1 > > > > > # Need to remove refference of "Flow API" from "doc/guides/nics/*" as well. > > > > "Flow API" is the implementation of the filtering, it may exist in the nic > > documentation, only it is not a feature on itself. I will scan the docs for usage. > > > > > > > > Not specific to this patch, > > > Probably we need to add a new matrix to enumerate PATTERN and ACTIONS > > > supported by each PMD as a rte_flow feature matrix. > > > That some else can take it up if everyone agrees the semantics. > > > > > > > +1, there needs a way to figure out which filtering is supported by a > > device/driver. It is not documented and it is very hard to got it from the code. > > > > Not sure if a new matrix is the good way to go, but I agree we need some way to > > clarify it. > > I think we should split the matrix. > Adding a new matrix for flow offloads looks the way to go. > I suggest 3 matrices: > - port-level features > - queue-level features > - flow-level features Not sure what will be the details in "flow-level features". IMO, We need to have a separate matrix for subdomain features for rte_flow, rte_tm, rte_mtr, etc which part of ethdev. For instance, rte_flow features can be translated into a matrix of supported PATTERN and ACTIONS. > >