From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E83B2A04EF; Sun, 31 May 2020 15:50:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F5BF1C300; Sun, 31 May 2020 15:50:08 +0200 (CEST) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id 266CC1C2F6 for ; Sun, 31 May 2020 15:50:07 +0200 (CEST) Received: by mail-il1-f193.google.com with SMTP id 9so6849549ilg.12 for ; Sun, 31 May 2020 06:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zsznKBoyXFNaOrQL0YGJFJcw0T8rGk2hsIfNLenpCzE=; b=BS1A72KdZoRGO/sDzIgTYCAmf+NF9/YkYyPRPZJ1HvcQyZG0mLi1nMSgM33RGfNYs7 cLLmUjOBXJa75u4cPE+Bv9ufAqJVxnqtUilnD1I22CsglJaMDnFwbsB88bmRz1QQYmfD J8obqhS0oaV2iZ0y0H8buOAe/Sq3oopCbpXSESZ6AtvnMjKl1XsqrGZYNrZms/qZC4ai AgUfrGsfnvy7ZIAnpIMcxBlf1pJNOvrawedUlScxA57asJ4ksjmzJdpB67yRKihjrEYZ 3VcHL6pX+lsBtTgDRA0rOjdnNsr5e77zHTMTSbfSANkERDetUx/z89tnUtXHT16V4+ph 5XNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zsznKBoyXFNaOrQL0YGJFJcw0T8rGk2hsIfNLenpCzE=; b=cy685WVtH4FEqowNsfjJUYjeIyCqEmyM68wQNMknTKBgUJA5IeRo6Q/p35mdiroNIA O6u+rl+2HcGbeD04bZij1S6pi1yuCBUh8Zu8DxMhnC6+nmln4rmDkci1ziPiA18rHAeG nk8hQoqSaZIPu32LATU8BRDg51/SWmdQPjlKcoqmd/ly80ZuTsupFU6bnnlzgDiwhPvy 0fBo2toB5IrNyh+e/yJMfhF7ivd4ohh7bZLTNMdhOea4gKK62288VqPaXPz9iLvwE1VX /NDARBqrjbRoI8hn50X2nRZJscaui4q6zFdvGQmnvrKzkTagTviB3TnH1Eaclafeewph u2zA== X-Gm-Message-State: AOAM530xyYuY7cC/2Ys0uAUszRYZpuKFAOs9dDJS9kWq+hObVvQa9Yg9 KnE7VxAtQ/f8lxou7QYEG06kaFcFPLCxsA9QuYw= X-Google-Smtp-Source: ABdhPJw7WXJOIXbOCo0CBA9V1mnITj7lO5qrt8V8wl1O/njl8W92xVVa1uLu43JRRAAwVLFzI3m0B5rwgY5H+vvMKiE= X-Received: by 2002:a05:6e02:689:: with SMTP id o9mr17112932ils.294.1590933006379; Sun, 31 May 2020 06:50:06 -0700 (PDT) MIME-Version: 1.0 References: <20200531124151.16848-1-fady@mellanox.com> <20200531124151.16848-2-fady@mellanox.com> In-Reply-To: <20200531124151.16848-2-fady@mellanox.com> From: Jerin Jacob Date: Sun, 31 May 2020 19:19:50 +0530 Message-ID: To: Fady Bader Cc: dpdk-dev , Thomas Monjalon , tbashar@mellanox.com, Tal Shnaiderman , yohadt@mellanox.com, Dmitry Kozlyuk , Olivier Matz , Andrew Rybchenko , Ray Kinsella , Neil Horman Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, May 31, 2020 at 6:12 PM Fady Bader wrote: > > Tracing is not supported for Windows. > Disabled all trace calls in for Windows. What is the current major issue to enable Trace for windows?. Trace does not need to rte_malloc support, it can work with malloc as well incase rte_malloc is not available. If there is not a major issue in enabling trace for windows, we should enable trace instead of introducing conditional compilation stuff. > > Signed-off-by: Fady Bader > --- > lib/librte_mempool/mempool_trace_points.c | 4 ++++ > lib/librte_mempool/rte_mempool.c | 20 ++++++++++++++++++++ > lib/librte_mempool/rte_mempool.h | 22 ++++++++++++++++++++++ > lib/librte_mempool/rte_mempool_ops.c | 8 ++++++++ > lib/librte_mempool/rte_mempool_trace_fp.h | 3 +++ > 5 files changed, 57 insertions(+) >