From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9295F43C46; Sun, 3 Mar 2024 16:34:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 009F040E96; Sun, 3 Mar 2024 16:34:02 +0100 (CET) Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by mails.dpdk.org (Postfix) with ESMTP id 961E740267; Sun, 3 Mar 2024 16:33:59 +0100 (CET) Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-42e8758fd52so28713541cf.1; Sun, 03 Mar 2024 07:33:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709480039; x=1710084839; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qojZjvrsg4AfS2jEpKKTw+q1ho1Gc+lz9PEJCS/pn3s=; b=b9QSTmwOi/BkngtzmtufiZBt004xczOwIuQ0ythvIo8wKFMHs4aMAQTiB3yqnFWgYp m2zD5oMsnLHdaoQBeaSx2J/qN76b2c5j3YWG24y0WpgNGXHBKk2SagrNQx8nWZ/R6HFE PgNSSf1h7sB7wmirdvkY+yvKgV39VhE4k1AS4TAk77wHayEAigPmY2TBnGEvekqVCdaj Ejk02CgvuyahVz5bg65vh/EANgp7yUYRmFSi9NBBbxcw9oklg9HB5kczmEtILSUAy+nb gbP+CslfKPWufmpT6Wq4aGRAcytgCqoQktDku3ldxy+thx4+UvbV3eVaKtV2MnuTOp6M pV/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709480039; x=1710084839; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qojZjvrsg4AfS2jEpKKTw+q1ho1Gc+lz9PEJCS/pn3s=; b=c5YfZrzCK+oH//yYQkCTIKZorab11ycDbmy8GJShcwSYkQktLsfSmC0qhyNpC/yeHy qGbD+9ncJXKceD5dOZA0cBsAXyiHb+K/0QHc1jL8mjfe4F5ag+Jr/cpoIYAoNmNK0oU2 58rO37L0AOPl9SZ0ad6MuL83dNdgAsRm0BKDG/MDjSigD7rIPgLw0fw0EsHEEvKDgdQU V2xRh+3k9GM6rDtY62rFQvrNKFhElyA8iVwlMN0HwN0lV1OL1oUpFjA6qa8EyEElgq4l sqsjKaPHs5wSf3eriDtvc58oAbLl5nqdij//omJhUKd19WSe1qO/0hP5BBcBgjb8MBJ1 Lshg== X-Forwarded-Encrypted: i=1; AJvYcCVskD1/RFfyMEwc5/uQu92rksmme54GzOjfjRLdEEpqMjfEUFy/cqVnT7wvOovzt4CBgUQukI52A2pVaMEEWa8= X-Gm-Message-State: AOJu0YxAONB3YsUyy67vCOcjFsDda3IyhgpJ3DoPNbEoV2hUXBbDoetz DFZWSYjRPilwlwCEPiA8w608VJ90hACYsE3XVP9DvQfMmrXWYfM3shn1tSt90fOWQduOwJh9jlT wabfwiBJy3Bwlv15UFAUsj9d3tAc= X-Google-Smtp-Source: AGHT+IF0gT8yUv3eS2VYZ8xL9slFtbPjLSXsh/SSIgbvJ5di5RZl0A+O4FyMAPkWEMHDepA39F/hNbqkc3VXyLFvSW4= X-Received: by 2002:a05:622a:44a:b0:42e:b9ad:1249 with SMTP id o10-20020a05622a044a00b0042eb9ad1249mr9751902qtx.66.1709480038912; Sun, 03 Mar 2024 07:33:58 -0800 (PST) MIME-Version: 1.0 References: <20240227144247.1562499-1-rbhansali@marvell.com> <20240301031645.1656237-1-rbhansali@marvell.com> In-Reply-To: <20240301031645.1656237-1-rbhansali@marvell.com> From: Jerin Jacob Date: Sun, 3 Mar 2024 21:03:32 +0530 Message-ID: Subject: Re: [PATCH v2] net/cnxk: performance improvement for SW mbuf free To: Rahul Bhansali Cc: dev@dpdk.org, Pavan Nikhilesh , Shijith Thotton , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rakesh Kudurumalla , jerinj@marvell.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 1, 2024 at 8:47=E2=80=AFAM Rahul Bhansali wrote: > > Performance improvement is done for Tx fastpath flag MBUF_NOFF when > tx_compl_ena is false and mbuf has an external buffer. > In such case, Instead of individual external mbuf free before LMTST, > a chain of external mbuf will be created and free all after LMTST. > This not only improve the performance but also fixes SQ corruption. > > CN10k performance improvement is ~14%. > CN9k performance improvement is ~20%. > > Fixes: 51a636528515 ("net/cnxk: fix crash during Tx completion") > Cc: stable@dpdk.org > > Signed-off-by: Rahul Bhansali Applied to dpdk-next-net-mrvl/for-main. Thanks