From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEC08A04DD; Wed, 28 Oct 2020 09:06:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0FDCABC8C; Wed, 28 Oct 2020 09:06:48 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id EAE24BC76 for ; Wed, 28 Oct 2020 09:06:45 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id p7so4424480ioo.6 for ; Wed, 28 Oct 2020 01:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GkW8Hi8OBPmiwat4s5dcG1mNEjX5YbEMOjc0cKnbWBc=; b=PyZeSRRV4Sfk71f1eatgxdxLi1kSF2a43OP0tLu4p+fp/zlRCRF5/fpdy7iRJW+6Il h/zTUw6IiZtUpSpanmdhvxyr4V05JTgsZVzetdOOQTVrKIIKkR6/nbP3c6URFnDFMQ23 Io6bM6B4OzS7vAiTYwU+XSfqGKEc2N+mSooXfk34o/vaDPe6fJeLNMghcFRJuVNLVb0a YTHkQTBCfu46Oj+hv6ckWLahZtJkGV80WFVEz94nAJPGwwEGohm44AO6E0m/uL7Oi8LL KnUIjq8JVgRzX/8VGlrST9zo4mEbNJBQiCypeV0BRZbiYKpLkY4EhudFRHfro3cLgDd9 46jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GkW8Hi8OBPmiwat4s5dcG1mNEjX5YbEMOjc0cKnbWBc=; b=k8KaLpWoInKTW1cqXSeE3Zr6Tg8Abzu78WJSvB258c0RJtK1mwgRGvaX6xzEaM9Z4r VWm6GsGRAdFqE4iMOzrWR/bApafuNDIJah5B6Wl4/sWDevLArJe+Fv3+9Zqsd7dQ8OFo yXH2Fd9daxdxRdNsk16jljzfV6PWMfoPjoQFVPo5fbkX/FW3vxs7LVY298kLE6jpOeXb 34PuF12r6RqcKaYxML+Z/c89H22Kz4u6PdelObyGKmjulyZBkLMJ/DoNLtACJOBDnx17 sw1QxDYJn43T0yiY51WsYPpaZMFFvIvOzykU4sFPmDBRrUtISxnRcnxnh+nWFiPbRVv8 Qf8w== X-Gm-Message-State: AOAM531S+SkbSRLhutoR2f/u/J/LsjrmY0g6IbS9pXHRNwPDJ9J8QXhS RIX77UqGS4/QUvZmCqfCEr/1V2Yi0dP6x2zAvjA= X-Google-Smtp-Source: ABdhPJyyhPzvGet+vu5ErWLPTRo/xtOj33RiYfDVAyvttSBhdWZRIvgHH957yTfrmwGaQQjxDGMCtXGph3W+HxXQQ4Q= X-Received: by 2002:a5d:9615:: with SMTP id w21mr5221720iol.59.1603872404252; Wed, 28 Oct 2020 01:06:44 -0700 (PDT) MIME-Version: 1.0 References: <20201026052105.1561859-1-thomas@monjalon.net> <20201027210115.2529025-13-thomas@monjalon.net> <25061618.yxkc6rsGur@thomas> In-Reply-To: <25061618.yxkc6rsGur@thomas> From: Jerin Jacob Date: Wed, 28 Oct 2020 13:36:28 +0530 Message-ID: To: Thomas Monjalon Cc: Jerin Jacob , "McDaniel, Timothy" , dpdk-dev , Ferruh Yigit , David Marchand , "Richardson, Bruce" , Olivier Matz , Andrew Rybchenko , Akhil Goyal Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 12/15] app/eventdev: switch flow ID to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 28, 2020 at 1:13 PM Thomas Monjalon wrote: > > 28/10/2020 05:54, Jerin Jacob: > > On Wed, Oct 28, 2020 at 2:35 AM Thomas Monjalon wrote: > > > > > > The order test stored the flow ID in the deprecated mbuf field udata64. > > > It is moved to a dynamic field in order to allow removal of udata64. > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > + static const struct rte_mbuf_dynfield flow_id_dynfield_desc = { > > > + .name = "test_event_dynfield_flow_id", > > > + .size = sizeof(flow_id_t), > > > + .align = __alignof__(flow_id_t), > > > + }; > > > + flow_id_dynfield_offset = > > > + rte_mbuf_dynfield_register(&flow_id_dynfield_desc); > > > > > > Since this path used in fastpath, could you move flow_id_dynfield_offset to > > test_order's initial entry as that cache will be warm always. > > I don't understand. Are you talking about the offset value? > This field will be in the second part of mbuf, as udata64 was. > Or are you talking about the storage of the offset variable? Yes. Storage of the offset variable. > > > > + if (flow_id_dynfield_offset < 0) { > > > + evt_err("failed to register mbuf field"); > > > + return -rte_errno; > > > + } > > > + > > > test_order = rte_zmalloc_socket(test->name, sizeof(struct test_order), > > > RTE_CACHE_LINE_SIZE, opt->socket_id); > > > > See above > > You mean the offset should be stored in this struct test_order? Yes. Instead of a global variable flow_id_dynfield_offset > > >