DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: "Lukas Bartosik [C]" <lbartosik@marvell.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	 Anoob Joseph <anoobj@marvell.com>,
	Narayana Prasad Raju Athreya <pathreya@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] event/octeontx2: fix queue removal from Rx adapter
Date: Sat, 2 May 2020 15:16:15 +0530	[thread overview]
Message-ID: <CALBAE1N8xvtHXN4rwHw397507QAciD2m7Lsm5amn24WGT6_vTA@mail.gmail.com> (raw)
In-Reply-To: <BYAPR18MB2518D111025BAD10B948DC04DEAB0@BYAPR18MB2518.namprd18.prod.outlook.com>

On Fri, May 1, 2020 at 4:44 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
> >When eth port queue is removed from Rx adapter using
> >rte_event_eth_rx_adapter_queue_del() it incorrectly
> >initializes CQ context instead of modifying it. This
> >might lead to a crash when CQ context is modified
> >as a part of rte_eth_dev_stop() sequence as CQ will
> >hold invalid entries. This is responsibility of an
> >application to call rte_event_eth_rx_adapter_queue_del()
> >to remove eth port queue from Rx adapter in tear down
> >sequence.
> >
> >Fixes: 37720fc1fba8 ("event/octeontx2: add Rx adapter")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Lukasz Bartosik <lbartosik@marvell.com>
>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>


Applied to dpdk-next-eventdev/master. Thanks.


>
> >---
> > drivers/event/octeontx2/otx2_evdev_adptr.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/event/octeontx2/otx2_evdev_adptr.c
> >b/drivers/event/octeontx2/otx2_evdev_adptr.c
> >index 233cba2..8bdcfa3 100644
> >--- a/drivers/event/octeontx2/otx2_evdev_adptr.c
> >+++ b/drivers/event/octeontx2/otx2_evdev_adptr.c
> >@@ -133,7 +133,7 @@ sso_rxq_disable(struct otx2_eth_dev *dev,
> >uint16_t qid)
> >       aq = otx2_mbox_alloc_msg_nix_aq_enq(mbox);
> >       aq->qidx = qid;
> >       aq->ctype = NIX_AQ_CTYPE_CQ;
> >-      aq->op = NIX_AQ_INSTOP_INIT;
> >+      aq->op = NIX_AQ_INSTOP_WRITE;
> >
> >       aq->cq.ena = 1;
> >       aq->cq.caching = 1;
> >@@ -144,7 +144,7 @@ sso_rxq_disable(struct otx2_eth_dev *dev,
> >uint16_t qid)
> >
> >       rc = otx2_mbox_process(mbox);
> >       if (rc < 0) {
> >-              otx2_err("Failed to init cq context");
> >+              otx2_err("Failed to enable cq context");
> >               goto fail;
> >       }
> >
> >--
> >2.7.4
>

      reply	other threads:[~2020-05-02  9:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16 13:23 [dpdk-dev] [PATCH] " Lukasz Bartosik
2020-04-16 13:25 ` Jerin Jacob
2020-04-16 15:47 ` [dpdk-dev] [PATCH v2] " Lukasz Bartosik
2020-05-01 11:14   ` Pavan Nikhilesh Bhagavatula
2020-05-02  9:46     ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1N8xvtHXN4rwHw397507QAciD2m7Lsm5amn24WGT6_vTA@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=lbartosik@marvell.com \
    --cc=pathreya@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).