From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 621F3A04B4; Sat, 2 May 2020 11:46:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A1B61D65A; Sat, 2 May 2020 11:46:33 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 4C7D51C24A; Sat, 2 May 2020 11:46:32 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id i19so7172403ioh.12; Sat, 02 May 2020 02:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=toBKkOuMke2DjYsWsEq9tovNAh14jxkBTjhURYKfEVM=; b=MaFAu9nM8iUN+17+DRFUu8AY1+GUw/9ez2+VO7VIr+6n3FvYvQpajc2ve2t4DCQjsr qY3n67B6AMxS4A6IvD2lbDc1Q1b9CiLc2Jvk5p43AsTXck5P2tqi+jNYgRHUiMS+sQsZ VWsAcYqKWsNk01QKak1Bl3wD8BU/L1OcxPSt18SiLtLl4ws/xmqtnmgErXSJ5agBHPNk 3ULSYAjxcIz2kmgKycfsDNCphZuJbw0+J5zKg6wnECgquj+zalWlDQE/cvwdBn7o8OQN 93cYTlM1uiHTMIuCCNgFK+Bd5eZicqLqPXQM+rvM/59VP5Oq6EK25spJmLWAk6ZooRai 4uXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=toBKkOuMke2DjYsWsEq9tovNAh14jxkBTjhURYKfEVM=; b=aWGrIEei2O8LnGt6J0P1M+j5ADiu8AyH73M6+jdyy5hWu2tCJvT1zx4V48SsDBBFzd bil4VWuDtWdZdo+EpbFWjZa6InHWFGpKs1wB2WNOa1nwbQYsw0ljnqwfZFCTbAro3P9W iDlncpyxNcrzvU7bga/siZThRQi7a94mQrF8ueZcg+x7HIiaHaQfa08gt6lPPF3YjxCx TWvNrYtXSCi9U4Qjm4cUUIM06GfWUaerHnY7QiqngOJZ+gjXZpcC0nCAo1FBSyGq64ki yT2GHHnke8e5S22yqeanfi6xu1xR3HAEnpWfv91Qy3/fVDhyzLn5FmLBvt09/qgOnPFa I2zQ== X-Gm-Message-State: AGi0PuYw/6fpGW22jEpXJUi5ojIBrSSgOmWktRPUAQYSUUTxcnyHyBk3 T9LvYsOcMF4PzGr76VFkU4VWUXEuW8vyDFLfZgs= X-Google-Smtp-Source: APiQypKzgGNLYUUSMSqA2CW0IURKXfpHS/TMoU6OiJe6wZuz2NHIiOa9eXADxnp1kbU4QRGRk1HiANv7XWCHA5mXs6k= X-Received: by 2002:a5d:8c89:: with SMTP id g9mr7468573ion.1.1588412791489; Sat, 02 May 2020 02:46:31 -0700 (PDT) MIME-Version: 1.0 References: <1587043415-10955-1-git-send-email-lbartosik@marvell.com> <1587052060-22042-1-git-send-email-lbartosik@marvell.com> In-Reply-To: From: Jerin Jacob Date: Sat, 2 May 2020 15:16:15 +0530 Message-ID: To: Pavan Nikhilesh Bhagavatula Cc: "Lukas Bartosik [C]" , Jerin Jacob Kollanukkaran , Anoob Joseph , Narayana Prasad Raju Athreya , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] event/octeontx2: fix queue removal from Rx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 1, 2020 at 4:44 PM Pavan Nikhilesh Bhagavatula wrote: > > >When eth port queue is removed from Rx adapter using > >rte_event_eth_rx_adapter_queue_del() it incorrectly > >initializes CQ context instead of modifying it. This > >might lead to a crash when CQ context is modified > >as a part of rte_eth_dev_stop() sequence as CQ will > >hold invalid entries. This is responsibility of an > >application to call rte_event_eth_rx_adapter_queue_del() > >to remove eth port queue from Rx adapter in tear down > >sequence. > > > >Fixes: 37720fc1fba8 ("event/octeontx2: add Rx adapter") > >Cc: stable@dpdk.org > > > >Signed-off-by: Lukasz Bartosik > > Acked-by: Pavan Nikhilesh Applied to dpdk-next-eventdev/master. Thanks. > > >--- > > drivers/event/octeontx2/otx2_evdev_adptr.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/drivers/event/octeontx2/otx2_evdev_adptr.c > >b/drivers/event/octeontx2/otx2_evdev_adptr.c > >index 233cba2..8bdcfa3 100644 > >--- a/drivers/event/octeontx2/otx2_evdev_adptr.c > >+++ b/drivers/event/octeontx2/otx2_evdev_adptr.c > >@@ -133,7 +133,7 @@ sso_rxq_disable(struct otx2_eth_dev *dev, > >uint16_t qid) > > aq = otx2_mbox_alloc_msg_nix_aq_enq(mbox); > > aq->qidx = qid; > > aq->ctype = NIX_AQ_CTYPE_CQ; > >- aq->op = NIX_AQ_INSTOP_INIT; > >+ aq->op = NIX_AQ_INSTOP_WRITE; > > > > aq->cq.ena = 1; > > aq->cq.caching = 1; > >@@ -144,7 +144,7 @@ sso_rxq_disable(struct otx2_eth_dev *dev, > >uint16_t qid) > > > > rc = otx2_mbox_process(mbox); > > if (rc < 0) { > >- otx2_err("Failed to init cq context"); > >+ otx2_err("Failed to enable cq context"); > > goto fail; > > } > > > >-- > >2.7.4 >