From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D51942B6F; Mon, 22 May 2023 10:26:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B91E410DD; Mon, 22 May 2023 10:26:21 +0200 (CEST) Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by mails.dpdk.org (Postfix) with ESMTP id 414CD410D1 for ; Mon, 22 May 2023 10:26:20 +0200 (CEST) Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-78412128326so2709946241.1 for ; Mon, 22 May 2023 01:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684743979; x=1687335979; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jWKhl9SvGqE+6UAuGsqXR/cn3mWmRSgRtZGb6GvrBBM=; b=ej+NhkSPzPUM+nXtN0by9ZVkzq4DYhINIzOrju6mKYkedtw/sNxWj8P27dvB3xLp5R S7zmUXKFBWUl/OG5WrXpnBrbGkcv62RZmPpCbFn4ZVn/SbOD4chprWpngA/bLrjlZLFA OZp4fFA8/wsOC0o5VcBuYPF1SJKA7ImCRTuk2C+FtGZ/HND0MfqrySrZPMkD8n1Bfq2F eF29TXp0bJxtdQSfCEbAn7CPiKO2SnaGipUk5RqagD44bwke2TA123iexYptdxyyVHvR c4Fjw6GgmnLG+Hiy12I7KPN1SssM/0ze+1b//dN6VohYjCCXr+CR6SxLEPC9jFpgMPkF F3Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684743979; x=1687335979; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jWKhl9SvGqE+6UAuGsqXR/cn3mWmRSgRtZGb6GvrBBM=; b=SBZAZqoMZFfoSrsx0T7H1iDrPN94tYokiVX+QVh9v+vs1dMiRJDUYqsUF0uGGO3hda mus66k6O0vicyeiuUNirUtCmahtrKo5Q1G71bF2WVkVqCW9cBNYCyWv1dhaGDYG+qA1H 5nq24rzi6qCWAyoK2M/VDE50+ZQfpvtW2wE+PtmRzpWUsxsxHHFHlLI3O/Qbx9zSWPb4 BClIa3+sAmR5Jp1J90eZg8rDQmkvNmjkqbCGygP+ARanjcWoZPXGYu/YYFnXf+P5v3Hu SF1o4AWG2T+fn/M2DHJrDA9+u2kKqcQje5VmzbI2X3Ir7AnPj83TW9TJss0ca/SOhAs9 1Isg== X-Gm-Message-State: AC+VfDz2fBAEJNGx0cinoL1DGOeGr82YP4rPVyQUxvGakU+qyj+fiZKh +EK8IHZ5ObQeCBqNKi0teL1sc6BJTWQ3WYIq7pGR6BIit2nnzg== X-Google-Smtp-Source: ACHHUZ4WPOmz+Bp8cavwrzss7F1iT1CeAIMisc8HkAe1LxaBZgiFPBF3WTJ7POqFKfcqEPCXNScPttu1q3m4co2VZLY= X-Received: by 2002:a67:fd6f:0:b0:439:4900:c27 with SMTP id h15-20020a67fd6f000000b0043949000c27mr406741vsa.18.1684743979430; Mon, 22 May 2023 01:26:19 -0700 (PDT) MIME-Version: 1.0 References: <20230331040306.3143693-1-zhirun.yan@intel.com> <20230509060347.1237884-1-zhirun.yan@intel.com> <20230509060347.1237884-2-zhirun.yan@intel.com> In-Reply-To: <20230509060347.1237884-2-zhirun.yan@intel.com> From: Jerin Jacob Date: Mon, 22 May 2023 13:55:53 +0530 Message-ID: Subject: Re: [PATCH v6 01/15] graph: rename rte_graph_work as common To: Zhirun Yan Cc: dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com, ndabilpuram@marvell.com, stephen@networkplumber.org, pbhagavatula@marvell.com, cunming.liang@intel.com, haiyue.wang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 9, 2023 at 11:34=E2=80=AFAM Zhirun Yan w= rote: > > Rename rte_graph_work.h to rte_graph_work_common.h for supporting > multiple graph worker model. I have requested to check the performance with dpdk-test and l3fwd graph in last series. Have you checked the performance? In my testing, there is regression. Please check the performance with dpdk-test and l3fwd graph, there should not be any regression in RTC mode. There is around -300% regression arm64 and x86. Command to mesure: ./build/app/test/dpdk-test -c 0xf00000 -- graph_perf_autotest There is around ~-2% regression in l3fwd-graph. I dont think, there should not be any reason for regression as it is model are separate header file. Please check the common header file in fastpath and fix the regression to accept this series. ./build/examples/dpdk-l3fwd-graph -a 0002:02:00.0 -c 0xc00000 -- -p 0x1 --config=3D"(0, 0, 23)" -P (edited) Old +-------------------------------+---------------+---------------+----------= -----+---------------+---------------+-----------+ |Node |calls |objs |realloc_count |objs/call |objs/sec(10E6) |cycles/call| +-------------------------------+---------------+---------------+----------= -----+---------------+---------------+-----------+ |ip4_lookup |7282757 |1864385584 |1 |256.000 |38.704896 |1770.0000 | |ip4_rewrite |7282758 |1864385840 |1 |256.000 |38.704896 |1431.0000 | |ethdev_tx-0 |7282758 |1864385840 |1 |256.000 |38.704896 |922.0000 | |ethdev_rx-0-0 |14882133 |1864386096 |2 |256.000 |38.704896 |2015.0000 | |pkt_cls |7282760 |1864386352 |1 |256.000 |38.704896 |392.0000 | +-------------------------------+---------------+---------------+----------= -----+---------------+---------------+-----------+ New +-------------------------------+---------------+---------------+----------= -----+---------------+---------------+-----------+ |Node |calls |objs |realloc_count |objs/call |objs/sec(10E6) |cycles/call| +-------------------------------+---------------+---------------+----------= -----+---------------+---------------+-----------+ |ip4_lookup |3002135 |768546560 |2 |256.000 |38.402048 |1770.0000 | |ip4_rewrite |3002136 |768546816 |1 |256.000 |38.402048 |1425.0000 | |ethdev_tx-0 |3002137 |768547072 |2 |256.000 |38.402048 |949.0000 | |ethdev_rx-0-0 |3002138 |768547328 |2 |256.000 |38.402048 |1966.0000 | |pkt_cls |3002138 |768547328 |1 |256.000 |38.402048 |408.0000 | +-------------------------------+---------------+---------------+----------= -----+---------------+---------------+-----------+ NAK for this series till the performance issues fixed. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > --- > diff --git a/MAINTAINERS b/MAINTAINERS > index 8df23e5099..cc11328242 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1714,6 +1714,7 @@ F: doc/guides/prog_guide/bpf_lib.rst > Graph - EXPERIMENTAL > M: Jerin Jacob > M: Kiran Kumar K > +M: Zhirun Yan Thanks for adding as maintainer. Since you are at this change. Could you move up "Nithin Dabilpuram " two lines below and group all together? > F: lib/graph/ > F: doc/guides/prog_guide/graph_lib.rst > F: app/test/test_graph*