From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 442C2A00BE; Thu, 17 Feb 2022 05:35:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA28840150; Thu, 17 Feb 2022 05:35:09 +0100 (CET) Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by mails.dpdk.org (Postfix) with ESMTP id 9048B40042; Thu, 17 Feb 2022 05:35:08 +0100 (CET) Received: by mail-il1-f177.google.com with SMTP id z18so1437263iln.2; Wed, 16 Feb 2022 20:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RDK34Uuczeeh/k57+t+C7bYQe/7DeCTX9msxNyA36Y0=; b=HemeOXQPImpqs2FkmTxGC7/DJs238QzgE8GjDMJXqKX+78oeDNNNphT+m3nHlIHLzo oTxLUuu24k53MJcnxCfGHrCi5qCuCZWzIqVag7kJfznSWPO3lu1z1Lrb0ZQBMv4U1DsQ pSxX9V1IToGK+aKcI4DcMzuEChuof6jN+e3303HPuNhx3v67pDgAwTSi8qEWoFYcqgvj 3ixn0CXjsCljfGtyyHx0dzWAzuscdNXu4sbxVeOkYiVky34t3CvviU6w3bBXNm6iXEPW Fnl9GmzoG33pkATJehKz9b+w/Sdhe5exiD7G1FeDOJ24cpozsuRVXIYbAxt4Uhr8wPqe FiHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RDK34Uuczeeh/k57+t+C7bYQe/7DeCTX9msxNyA36Y0=; b=D1EazjmUYU5mQQr5ogD9kmNw6r785fTLqd7sU0ULpvBXiGzFGIAq5ZHj+r+rYcO+sG ZIEvKXh6LB0ZpCxbr3RHvmarnOvm0hJju9i2M4VV/OUzhIFucu31yJkROBbplwgKGX/+ D6Eq+Lrl5P8u71/xFtnoehEi1gvGqwSw5rAVVJgNIfrgwp50h3ngTZgI4I8z6V/7IN5C bBsiUZxSALy4Uc247e27IPYsuSG7oqIUUGto4ldQNJDCydMShdk/+GdCZfj05QaOwioV 4PJbqLNpFRO9ll5ifBeT9uvzud9u/ZogQMsKtQ1TLRXDTZU/6kG1wbWeX19QP2oXcdpU x6/g== X-Gm-Message-State: AOAM530dvMCVn0J078w1AfBuCIOO3KlYsSie2Gzc30/ThEc3j6Ar9gf1 btddZSu6LKlAfrclkWrbNkaMjj2iEmvlTciNGDQ= X-Google-Smtp-Source: ABdhPJw/I+3hOlE6WvZsNBiyBrwipuu/YgFvSMncMWYOCMbgwww3ysYnbUao5uB5qugrILBxELPhKksTnZHxtCXabsU= X-Received: by 2002:a05:6e02:1846:b0:2bf:d363:ff3c with SMTP id b6-20020a056e02184600b002bfd363ff3cmr861154ilv.318.1645072507901; Wed, 16 Feb 2022 20:35:07 -0800 (PST) MIME-Version: 1.0 References: <20220125041248.905732-1-psatheesh@marvell.com> In-Reply-To: <20220125041248.905732-1-psatheesh@marvell.com> From: Jerin Jacob Date: Thu, 17 Feb 2022 10:04:41 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix missing null check in IPv6 flow parsing To: Satheesh Paul Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dpdk-dev , dpdk stable , Jerin Jacob Kollanukkaran Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 25, 2022 at 9:43 AM wrote: > > From: Satheesh Paul > > Added null check in IPv6 flow pattern parsing. > > Fixes: a55dc02af5 ("common/cnxk: support extensions attributes in IPv6 item") The changeset is not correct. > Cc: stable@dpdk.org > > Signed-off-by: Satheesh Paul > Reviewed-by: Jerin Jacob Kollanukkaran Updated the git commit as follows and Applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: fix null access in IPv6 flow parsing Added null check in IPv6 flow pattern parsing. Fixes: 474e275b1bc6 ("common/cnxk: support extensions attributes in IPv6 item") Cc: stable@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Jerin Jacob > --- > drivers/common/cnxk/roc_npc_parse.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/common/cnxk/roc_npc_parse.c b/drivers/common/cnxk/roc_npc_parse.c > index 1f21693369..302ab66efc 100644 > --- a/drivers/common/cnxk/roc_npc_parse.c > +++ b/drivers/common/cnxk/roc_npc_parse.c > @@ -562,9 +562,11 @@ npc_parse_lc(struct npc_parse_state *pst) > ipv6_spec = pst->pattern->spec; > lid = NPC_LID_LC; > lt = NPC_LT_LC_IP6; > - rc = npc_handle_ipv6ext_attr(ipv6_spec, pst, &flags); > - if (rc) > - return rc; > + if (ipv6_spec) { > + rc = npc_handle_ipv6ext_attr(ipv6_spec, pst, &flags); > + if (rc) > + return rc; > + } > info.len = sizeof(ipv6_spec->hdr); > break; > case ROC_NPC_ITEM_TYPE_ARP_ETH_IPV4: > -- > 2.25.4 >