From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6840D4269F; Tue, 3 Oct 2023 17:18:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17F2C402A2; Tue, 3 Oct 2023 17:18:21 +0200 (CEST) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by mails.dpdk.org (Postfix) with ESMTP id 10AF940262 for ; Tue, 3 Oct 2023 17:18:20 +0200 (CEST) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1c0fcbf7ae4so726201fac.0 for ; Tue, 03 Oct 2023 08:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696346299; x=1696951099; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WCmnSzsyPMl3JJAR8DP8b6DU5Llyevok0YeUhYFhAek=; b=Np0av/8RJqObuPocmdiMWIaLIS2L0nWJQHxqj8jVQ5edTJwgrvijmdCVBgFzv+U83v dQ0dwx5Am1GdEmvtk04QXDxcK0dkczi98rbC2jRZU620ZQplin7F/arjvXR+9scPZy40 ROW296RaerD9vHldnPWmUey/0f/B60oAPqr4pEsCEgiwc+s+EwhZV4OXhlsp0UwkK5PE 2s3dtE7UHMIRvJQ+kOtYCZ0YAhAmKlZPlcK/DWzrN2xGapOGGEDz3FsGn8oYz/M8lUNm +DSlVxft1BXyPAZyCvQ6w10IzL8VxkovYrfXNnPYM1XM6JKpRUEo3zicQC2FKgndDlC3 YcBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696346299; x=1696951099; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WCmnSzsyPMl3JJAR8DP8b6DU5Llyevok0YeUhYFhAek=; b=lIzr1QPWtHCmhQh9zNC4xYP0RUzLOkM3m9O6q7I0Zh5w6YXwW9n1sIIBruA3YWpBzR an1PF/g4QjsAAF3oFI4wzxvbo9w6n3HR6dK/6hAnrebGbI7FofkMXpKkbMyl00Vx58dI 3J92x04KeB+ytO6S9za0s/MV/iWAVRoM0B0LAYDVQAdsMS6mDPTSTX9tBx2j2/0uqGuW iujlhwoGDbxSKErE7vu9pT78KVLjaz9BmXYvjoy5ShwaZRiPeYAnrl6OzgHHI2s9jM4O zw9nOPWWeBiCFAAnHxrUP4pfid/S49KE3c3rMWuk5i3kf9H2pc/dpgOoKwaBXZbmX7T3 dW0w== X-Gm-Message-State: AOJu0YyYiwHX5J+9OLSoCs6J7F1lki14XPp/aCgfy/ypxbDBJTdJEjGR x4Dhdf9vd2KmzB+vhcpS+QURPEjHrBJ+xHE1Nk8= X-Google-Smtp-Source: AGHT+IH32VkF5Wb7Bfe+KKllUcGlMQgQifus+EVf3Z51gwdyYqbU82bsOZqXXIqpH2RqUudwXa88sHdZ/a6KnPm2MPI= X-Received: by 2002:a05:6358:2295:b0:150:70a:417 with SMTP id t21-20020a056358229500b00150070a0417mr8287464rwb.22.1696346299181; Tue, 03 Oct 2023 08:18:19 -0700 (PDT) MIME-Version: 1.0 References: <20231003075109.4309-1-pbhagavatula@marvell.com> <20231003094721.5115-1-pbhagavatula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Tue, 3 Oct 2023 20:47:52 +0530 Message-ID: Subject: Re: [PATCH v6 0/3] Introduce event link profiles To: Bruce Richardson Cc: pbhagavatula@marvell.com, jerinj@marvell.com, sthotton@marvell.com, timothy.mcdaniel@intel.com, hemant.agrawal@nxp.com, sachin.saxena@nxp.com, mattias.ronnblom@ericsson.com, liangma@liangbit.com, peter.mccarthy@intel.com, harry.van.haaren@intel.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com, s.v.naga.harish.k@intel.com, anatoly.burakov@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 3, 2023 at 7:43=E2=80=AFPM Bruce Richardson wrote: > > On Tue, Oct 03, 2023 at 04:06:10PM +0530, Jerin Jacob wrote: > > On Tue, Oct 3, 2023 at 3:17=E2=80=AFPM wrote= : > > > > > > From: Pavan Nikhilesh > > > > > > A collection of event queues linked to an event port can be associate= d > > > with unique identifier called as a link profile, multiple such profil= es > > > can be configured based on the event device capability using the func= tion > > > `rte_event_port_profile_links_set` which takes arguments similar to > > > `rte_event_port_link` in addition to the profile identifier. > > > > > > The maximum link profiles that are supported by an event device is > > > advertised through the structure member > > > > ... > > > > > > > > v6 Changes: > > > > Series applied to dpdk-next-net-eventdev/for-main with following change= s. Thanks > > > > I'm doing some investigation work on the software eventdev, using > eventdev_pipeline, and following these patches the eventdev_pipeline samp= le > no longer is working for me. Error message is as shown below: > > Config: > ports: 2 > workers: 22 > packets: 33554432 > Queue-prio: 0 > qid0 type: ordered > Cores available: 48 > Cores used: 24 > Eventdev 0: event_sw > Stages: > Stage 0, Type Ordered Priority =3D 128 > > EVENTDEV: rte_event_port_profile_unlink() line 1092: Invalid profile_id= =3D0 > Error setting up port 0 > > Parameters used when running the app: > -l 24-47 --in-memory --vdev=3Devent_sw0 -- \ > -r 1000000 -t 1000000 -e 2000000 -w FFFFFC000000 -c 64 -W 500 Following max_profiles_per_port =3D 1 is getting overridden in [1]. I was suggested to take this path to avoid driver changes. Looks like we can not rely on common code. @Pavan Nikhilesh Could you change to your old version(where every driver changes to add max_profiles_per_port =3D 1). I will squash it. diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c index 60509c6efb..5ee8bd665b 100644 --- a/lib/eventdev/rte_eventdev.c +++ b/lib/eventdev/rte_eventdev.c @@ -96,6 +96,7 @@ rte_event_dev_info_get(uint8_t dev_id, struct rte_event_dev_info *dev_info) return -EINVAL; memset(dev_info, 0, sizeof(struct rte_event_dev_info)); + dev_info->max_profiles_per_port =3D 1; [1] static void sw_info_get(struct rte_eventdev *dev, struct rte_event_dev_info *info) { RTE_SET_USED(dev); static const struct rte_event_dev_info evdev_sw_info =3D { .driver_name =3D SW_PMD_NAME, .max_event_queues =3D RTE_EVENT_MAX_QUEUES_PER_DEV, .max_event_queue_flows =3D SW_QID_NUM_FIDS, .max_event_queue_priority_levels =3D SW_Q_PRIORITY_= MAX, .max_event_priority_levels =3D SW_IQS_MAX, .max_event_ports =3D SW_PORTS_MAX, .max_event_port_dequeue_depth =3D MAX_SW_CONS_Q_DEP= TH, .max_event_port_enqueue_depth =3D MAX_SW_PROD_Q_DEP= TH, .max_num_events =3D SW_INFLIGHT_EVENTS_TOTAL, .event_dev_cap =3D ( RTE_EVENT_DEV_CAP_QUEUE_QOS | RTE_EVENT_DEV_CAP_BURST_MODE | RTE_EVENT_DEV_CAP_EVENT_QOS | RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE| RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK | RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | RTE_EVENT_DEV_CAP_NONSEQ_MODE | RTE_EVENT_DEV_CAP_CARRY_FLOW_ID | RTE_EVENT_DEV_CAP_MAINTENANCE_FREE), }; *info =3D evdev_sw_info; } > > Regards, > /Bruce