* [PATCH] common/cnxk: removed stale condition
@ 2023-06-15 6:31 skoteshwar
2023-06-15 8:43 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: skoteshwar @ 2023-06-15 6:31 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao; +Cc: dev
From: Satha Rao <skoteshwar@marvell.com>
Removed condition that doesn't have any effect on code flow.
Coverity issue: 385405
Fixes: 4d00b8c6a331 ("common/cnxk: allocate dynamic BPIDs")
Signed-off-by: Satha Rao <skoteshwar@marvell.com>
---
drivers/common/cnxk/roc_nix_fc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c
index f79baf9..d8ca5f9 100644
--- a/drivers/common/cnxk/roc_nix_fc.c
+++ b/drivers/common/cnxk/roc_nix_fc.c
@@ -750,8 +750,6 @@ enum roc_nix_fc_mode
req->read = 0;
rc = mbox_process(mbox);
- if (rc)
- goto exit;
exit:
mbox_put(mbox);
return rc;
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] common/cnxk: removed stale condition
2023-06-15 6:31 [PATCH] common/cnxk: removed stale condition skoteshwar
@ 2023-06-15 8:43 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2023-06-15 8:43 UTC (permalink / raw)
To: skoteshwar; +Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, dev
On Thu, Jun 15, 2023 at 12:01 PM <skoteshwar@marvell.com> wrote:
>
> From: Satha Rao <skoteshwar@marvell.com>
>
> Removed condition that doesn't have any effect on code flow.
>
> Coverity issue: 385405
> Fixes: 4d00b8c6a331 ("common/cnxk: allocate dynamic BPIDs")
>
> Signed-off-by: Satha Rao <skoteshwar@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/common/cnxk/roc_nix_fc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c
> index f79baf9..d8ca5f9 100644
> --- a/drivers/common/cnxk/roc_nix_fc.c
> +++ b/drivers/common/cnxk/roc_nix_fc.c
> @@ -750,8 +750,6 @@ enum roc_nix_fc_mode
> req->read = 0;
>
> rc = mbox_process(mbox);
> - if (rc)
> - goto exit;
> exit:
> mbox_put(mbox);
> return rc;
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-15 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-15 6:31 [PATCH] common/cnxk: removed stale condition skoteshwar
2023-06-15 8:43 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).