From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7C57A0540; Wed, 8 Jun 2022 19:17:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7FAB40689; Wed, 8 Jun 2022 19:17:20 +0200 (CEST) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by mails.dpdk.org (Postfix) with ESMTP id 5164240042 for ; Wed, 8 Jun 2022 19:17:19 +0200 (CEST) Received: by mail-qt1-f180.google.com with SMTP id hh4so15362640qtb.10 for ; Wed, 08 Jun 2022 10:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eZzTbrKz6NwDCFdZXMXGLyQ51MPS65mggf36cql6Jrw=; b=XRPvItMuqj64Ems6ge6tuCnFIJu8S5yNvBP1bT+zWBkS5yWAslniHTloyK3YXXZz4W Qfx3Iu8tPdyImSvf8xZX3ABGbFkooJYavgcde3yipjDWOgJpfQwDC/dwj+2BLMioFqCG 6AD2osmqUXX4QUizpzeZgFEo+Eo7u8LbBNBTcP86NOBx9pCkPdsVSe0xs2FiJ364876I 8YKgXrVSrOgQioK9Qh8lUH8Ogc6p/+BCYL2N9f3euGW5e5l0mkHXSR8YV1Fk2UrbOgbh qslhe3eEKrVxDizJUMtggVa+CqhncleSYpnYXGoMh430daSHvEKF2zxVqjr55Y778DZ5 VeSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eZzTbrKz6NwDCFdZXMXGLyQ51MPS65mggf36cql6Jrw=; b=498TqvGzZl4yEuA8pP0gLIv3l4NU7wWyjEwpA2bJtCHZ8MYXYDF55ErCtKLEgfQqfw y3aDUryevTdz5FxFfHNQpCn8NKtezS5vW5DMdHnApRpu6+dYxWX3ndZp6JCo3hielyjL ckknI6y2ot0Y2WVRltyotDnuKDZlxwZqWYThI7Gc/vw+tkCdATLdL0cVVHw/EfP7vDY2 53V8WN1+LJKe6YOs73nb+OMlKJGW6eUSe2pU1DkTEvWYOHQeWFjPDgwQF1PK3fB8+xEU 8E/Yfg3bIrRS5Y/Nplg+e9bWdz1vQsIQVCrxZ4txWmGlY3TEGHufilRyTs0V8cEg3Mi/ ARXg== X-Gm-Message-State: AOAM530RSvS8PdHfIIzEvcyKPqT9+BwIrJ/B4N5PVxz+178k1al3Dlj0 SQPKIQ3N1dCOwIjqPOav83NvkSIqyrCALRhvw7E= X-Google-Smtp-Source: ABdhPJxEQ97zT+sf1v2T2cVe8TTmr3l77lqJMD4D9WXSdHIJtsq+3YDrFyf03Pivc/T3Ff1CPtItL3L1/9i6++ZeAlE= X-Received: by 2002:a05:622a:81:b0:304:ea54:ae89 with SMTP id o1-20020a05622a008100b00304ea54ae89mr15294881qtw.172.1654708638649; Wed, 08 Jun 2022 10:17:18 -0700 (PDT) MIME-Version: 1.0 References: <20220602092356.2788089-1-jerinj@marvell.com> <4742743.31r3eYUQgx@thomas> In-Reply-To: <4742743.31r3eYUQgx@thomas> From: Jerin Jacob Date: Wed, 8 Jun 2022 22:46:52 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build To: Thomas Monjalon Cc: Bruce Richardson , Jerin Jacob , dpdk-dev , Ruifeng Wang , Jan Viktorin , David Christensen , Konstantin Ananyev , David Marchand , =?UTF-8?Q?Juraj_Linke=C5=A1?= , fengchengwen Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 8, 2022 at 2:00 PM Thomas Monjalon wrote: > > 08/06/2022 10:22, Jerin Jacob: > > On Thu, Jun 2, 2022 at 5:30 PM Jerin Jacob wrote: > > > > > > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon wrote: > > > > > > > > 02/06/2022 11:43, Jerin Jacob: > > > > > On Thu, Jun 2, 2022 at 3:11 PM Bruce Richardson > > > > > wrote: > > > > > > > > > > > > On Thu, Jun 02, 2022 at 02:53:55PM +0530, jerinj@marvell.com wrote: > > > > > > > From: Jerin Jacob > > > > > > > > > > > > > > By default, ccache is not used for cross build[1]. > > > > > > > Update all cross files to use ccache if it is available > > > > > > > in build machine. > > > > > > > > > > > > > > [1] > > > > > > > https://mesonbuild.com/Machine-files.html > > > > > > > > > > > > > > Signed-off-by: Jerin Jacob > > > > > > > > > > > > Does this still work even if ccache is not available? That's not fully > > > > > > > > > > Yes. > > > > > > > > > > > clear from the docs, but it seems to be that if an array is passed the > > > > > > whole array is used as the command, rather than just one element of the > > > > > > array. That would imply that cross-builds now require ccache. Is that > > > > > > acceptable? > > > > > > > > > > I have removed ccache from the build machine still it works. > > > > > > > > I don't understand why it works without ccache. > > > > > > Meson is detecting valid compiler prefix. ccache is one of them. > > > > > > See > > > https://github.com/fabio-porcedda/meson/commit/44db495f5ece43645ca3994dc95895c76a828530 > > > https://github.com/mesonbuild/meson/issues/1392 > > > > I hope there are no other review comments to fix it for this patch. > > Since it is improving the build time for cross-build. If there is no > > objection to this patch, Please merge it. > > I've tested it now and I see a big blocker. > This patch is breaking the use of devtools/test-meson-builds.sh > so I cannot merge it as-is, sorry. I assume you are referring to fixing the DPDK_TARGET update due to the cross-file update. If so, it is fixed in v2 at http://patches.dpdk.org/project/dpdk/patch/20220608171304.945454-1-jerinj@marvell.com/ Thanks > > >