From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ali Alnubani <alialnu@nvidia.com>
Cc: Hanumanth Pothula <hpothula@marvell.com>,
Jerin Jacob <jerinj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
"hkalra@marvell.com" <hkalra@marvell.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [PATCH v3 1/1] event/octeontx: resolve possible integer overflow
Date: Fri, 25 Oct 2024 15:57:49 +0530 [thread overview]
Message-ID: <CALBAE1NAdUodmRQ54u=gr4sfJwnTUqSKdPfKO06Ka5r9i0_M8g@mail.gmail.com> (raw)
In-Reply-To: <PH7PR12MB917370DFAD55EED770ED8F21DA4E2@PH7PR12MB9173.namprd12.prod.outlook.com>
On Thu, Oct 24, 2024 at 1:27 PM Ali Alnubani <alialnu@nvidia.com> wrote:
>
> > -----Original Message-----
> > From: Hanumanth Pothula <hpothula@marvell.com>
> > Sent: Thursday, October 24, 2024 6:55 AM
> > To: Jerin Jacob <jerinj@marvell.com>
> > Cc: dev@dpdk.org; hkalra@marvell.com; stephen@networkplumber.org;
> > hpothula@marvell.com
> > Subject: [PATCH v3 1/1] event/octeontx: resolve possible integer overflow
> >
> > The last argument passed to ssovf_parsekv() is an
> > unsigned char*, but it is accessed as an integer.
> > This can lead to an integer overflow.
> >
> > Hence, make ensure the argument is accessed as a char
> > and for better error handling use strtol instead of atoi.
> >
Add
Bugzilla ID: 1512
And add Fixes: tag
please start the git commit subject with event/octeontx: fix ...
Good to merge next version
> > Signed-off-by: Hanumanth Pothula <hpothula@marvell.com>
> > ---
> >
> > v2: use strtoul instead of strtol
> > v3: Add value boundry check. Here, value can be either 0 or 1.
> > ---
>
> Confirmed that it resolves https://bugs.dpdk.org/show_bug.cgi?id=1512.
>
> Tested-by: Ali Alnubani <alialnu@nvidia.com>
>
> Thanks,
> Ali
next prev parent reply other threads:[~2024-10-25 10:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 7:59 [PATCH] " Hanumanth Pothula
2024-10-18 16:36 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-10-18 17:35 ` Stephen Hemminger
2024-10-23 7:15 ` [PATCH v2 1/1] " Hanumanth Pothula
2024-10-23 16:16 ` Stephen Hemminger
2024-10-23 20:29 ` [EXTERNAL] " Hanumanth Reddy Pothula
2024-10-24 3:55 ` [PATCH v3 " Hanumanth Pothula
2024-10-24 7:57 ` Ali Alnubani
2024-10-25 10:27 ` Jerin Jacob [this message]
2024-10-25 10:58 ` [PATCH v4 1/1] event/octeontx: fix " Hanumanth Pothula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1NAdUodmRQ54u=gr4sfJwnTUqSKdPfKO06Ka5r9i0_M8g@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=alialnu@nvidia.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=hpothula@marvell.com \
--cc=jerinj@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).