From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE72145BD5; Fri, 25 Oct 2024 12:28:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7479140156; Fri, 25 Oct 2024 12:28:18 +0200 (CEST) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by mails.dpdk.org (Postfix) with ESMTP id F10CA4003C for ; Fri, 25 Oct 2024 12:28:16 +0200 (CEST) Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4608da1bea5so14724851cf.1 for ; Fri, 25 Oct 2024 03:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729852096; x=1730456896; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FqOxo5UZhtdp6XCr+Z/lQ9gbOmm/feepqWxVhK7EdC8=; b=YMgHsNw/zj4idNKT+VG2GLG271s91nEZxgMY2fnSBgQW+KaRMHPU7tFI3S5/IXstRy ibAIVRJ1v88Lm68SfdtLQCQcxdo3Y8JsKu/nkDwteuhFNjwMmAFQc3DeruAxpPqmp3+S tZx9c6BWb/+vpZNGFExwV1Jlh9nkOeOT4jW1ye4DZSq6dO3szpAQf5UGTO8b0yt1SWtl IL9r2Y1/A6p85/9c9FjdnI8jccHKOMV1dWhVsJ+9XBKxGDiZqnb6uJcrWZgeb0qP1DSP RU+e1GGQlcq8i1+jxkkYFeBIZgL5hSgysv7HdxnBvGS8zXwPiMkgbvb9zE42IVfJhzuH vXLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729852096; x=1730456896; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FqOxo5UZhtdp6XCr+Z/lQ9gbOmm/feepqWxVhK7EdC8=; b=tAlfjp0E9v16mRjXeXuGdtGHaP8x+aPUewwQe0Zt96CPPHFw2fRqHZqQksQrJaCMjl J6Zrsw6u5TKADaWDY53h6nR4a2vDIuZIVZcTz10KhY2Enlv8i+7OTKHUTsUoUcea6qxG vC+vO2mZ/Gv8HApWhS/O7J/CKbTG17TicY3dEAdiZDDq85eupRR9vWSWhJUUdzsLi12z GCsUWZLuSfjIAO9ijP7RZe2SV3uiazZtAVvvfJM7o3j+a+ePdlBNRHo3Lqnrf0AqMRg4 oLWvfQM5i9JP1gtlDAGG7BIxGJ2AZc8n0Jz0SMd8jhJOvHROq5XO9aTStjS9rDw5zQeS zlAw== X-Forwarded-Encrypted: i=1; AJvYcCW6ufG7kwD++1U9bFk8xmjVoXdTpkN3bQPiTcFPqg6qbCFzNZuHqJryi/qnzyR/wcMWfso=@dpdk.org X-Gm-Message-State: AOJu0YxKAjS2VZI/r9wprj1g7SJwalQiKbC9lZPAa6ZK4kf+uq8cvwJv HvsQQhjwsM5VLQGyObunFATbiwov9HrOcffukxaAfSZqh7S4d5jIQ8fEx3DiTgO0T2DYkiBQw0z DBUWn8A9SpOPNj8IPMnoD0O9n8Tg= X-Google-Smtp-Source: AGHT+IGBGzCCBtIIEUCNWiRf3McFSnzYb3+3g7hU24fWX012cHi94Y01jf4kdhOiq58a+hfWSd0RrfjGSYIRJa4R1XA= X-Received: by 2002:a05:622a:c9:b0:461:1fc4:1011 with SMTP id d75a77b69052e-4612589f0b1mr66140941cf.7.1729852096135; Fri, 25 Oct 2024 03:28:16 -0700 (PDT) MIME-Version: 1.0 References: <20241023071546.865609-1-hpothula@marvell.com> <20241024035524.1021926-1-hpothula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Fri, 25 Oct 2024 15:57:49 +0530 Message-ID: Subject: Re: [PATCH v3 1/1] event/octeontx: resolve possible integer overflow To: Ali Alnubani Cc: Hanumanth Pothula , Jerin Jacob , "dev@dpdk.org" , "hkalra@marvell.com" , "stephen@networkplumber.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 24, 2024 at 1:27=E2=80=AFPM Ali Alnubani w= rote: > > > -----Original Message----- > > From: Hanumanth Pothula > > Sent: Thursday, October 24, 2024 6:55 AM > > To: Jerin Jacob > > Cc: dev@dpdk.org; hkalra@marvell.com; stephen@networkplumber.org; > > hpothula@marvell.com > > Subject: [PATCH v3 1/1] event/octeontx: resolve possible integer overfl= ow > > > > The last argument passed to ssovf_parsekv() is an > > unsigned char*, but it is accessed as an integer. > > This can lead to an integer overflow. > > > > Hence, make ensure the argument is accessed as a char > > and for better error handling use strtol instead of atoi. > > Add Bugzilla ID: 1512 And add Fixes: tag please start the git commit subject with event/octeontx: fix ... Good to merge next version > > Signed-off-by: Hanumanth Pothula > > --- > > > > v2: use strtoul instead of strtol > > v3: Add value boundry check. Here, value can be either 0 or 1. > > --- > > Confirmed that it resolves https://bugs.dpdk.org/show_bug.cgi?id=3D1512. > > Tested-by: Ali Alnubani > > Thanks, > Ali