From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AFB942606; Thu, 21 Sep 2023 14:32:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFFA9402D2; Thu, 21 Sep 2023 14:32:30 +0200 (CEST) Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by mails.dpdk.org (Postfix) with ESMTP id E599F402C5 for ; Thu, 21 Sep 2023 14:32:29 +0200 (CEST) Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-49040dc5cedso356359e0c.3 for ; Thu, 21 Sep 2023 05:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695299549; x=1695904349; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ADa8dzT26Y5nYH+wR/FSxjRmQz/8zdQScOCUsQ/f1oo=; b=gj+djGHHk5dZjPZ/p+8iKeifRYWgOThN+s9cLVcgBpOxzFs1nzwAPgsNsyd9pauJ6a Njdic38nt+sgL5d/kM0gETHf5aG+SUeeWWER1xhY3fZIiB92Ab1k6Xzh5Oa8H7y/sYNL 6/6WAT1YwzQ2waj47iVCZd1bNw5/9F79cKOLz0Wz3OaltDU7jdqJlIdSVlGqxT8sDezn EKSeIwTLIIk2JYdBoApLUZSd7pBMyvUIEx5FcWIYFsHQIWL5Dgq//WaKJo7sPAkbSY6Z hOsA+HYxiNc4gtpxlC2vN5g0pSyFB07N88/ylj8Avd8z1pBwzktI+iCsiG6K5xHub2Qn H2hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695299549; x=1695904349; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ADa8dzT26Y5nYH+wR/FSxjRmQz/8zdQScOCUsQ/f1oo=; b=SIDIwrqlrLFyIKp4D+Pc0vsBNJURdOzzUNBw27YtHTWTdrKD1CnZI6phWZthSgOOLX otGRebmymFg1mj6iUOUghZfmV6/zSBrxdrnJGjDibbUdALIySLQqWPtYPXZt9o8y9MWo D3Bfzo9/yPoTzPxo1MW6vHBK+2u5GYnnGhDHpkJLMxMqgcuSK2rfw9JRAziNrg+LheZS UiuXTrzhPsfMZ/JiyiLfFqs91tSCOPVukXtllcQYq3QhrZi/ej8OEZasge4JcLdbxSum eOcyXdwJrismXT497hFChJcXmg8vNDVQQFDQfzB10SXsW2R7DgqPJNnC6V9vYZOhZc6y d76Q== X-Gm-Message-State: AOJu0YydElZzYUbZ8QFE3wnAPMD4RSTTH0uvtlz1HA3NEiTnr4dpqfOK taDQAWgfr3/idcGSmWie52swUPilP78vjtydkFO4cU5VQQU= X-Google-Smtp-Source: AGHT+IGDpbqm2QaP8oFwg0CB9LM10wSx/UWbmhm9a2iIEpuypsY3khAlWUNpyVckWDFmM2Ixn87z79u2JTtZUg910dg= X-Received: by 2002:a1f:c7c4:0:b0:495:bf5b:7e49 with SMTP id x187-20020a1fc7c4000000b00495bf5b7e49mr4723778vkf.13.1695299549137; Thu, 21 Sep 2023 05:32:29 -0700 (PDT) MIME-Version: 1.0 References: <20230830155927.3566-1-syalavarthi@marvell.com> <20230830155927.3566-20-syalavarthi@marvell.com> In-Reply-To: <20230830155927.3566-20-syalavarthi@marvell.com> From: Jerin Jacob Date: Thu, 21 Sep 2023 18:02:03 +0530 Message-ID: Subject: Re: [PATCH v1 19/34] ml/cnxk: support config and close of tvmdp library To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 30, 2023 at 9:34=E2=80=AFPM Srikanth Yalavarthi wrote: > > Added support to configure and close TVMDP library based > on ML device configuration options. > > Updated meson build to enable Jansson, TVM runtime, TVMDP > library as build dependencies. If it is optional =E2=80=93 please add optional please update cnxk ml driver documentation on this dependency and example command to build it. See DPDK mlx5 docs for dependency documentation. > > Signed-off-by: Srikanth Yalavarthi > --- > drivers/ml/cnxk/cnxk_ml_ops.c | 15 ++++++++++++ > drivers/ml/cnxk/meson.build | 45 ++++++++++++++++++++++++++++++++++ > drivers/ml/cnxk/mvtvm_ml_ops.c | 44 +++++++++++++++++++++++++++++++++ > drivers/ml/cnxk/mvtvm_ml_ops.h | 15 ++++++++++++ > 4 files changed, 119 insertions(+) > create mode 100644 drivers/ml/cnxk/mvtvm_ml_ops.c > create mode 100644 drivers/ml/cnxk/mvtvm_ml_ops.h > > diff --git a/drivers/ml/cnxk/cnxk_ml_ops.c b/drivers/ml/cnxk/cnxk_ml_ops.= c > index b2eb4bd0d9a..454fec33234 100644 > --- a/drivers/ml/cnxk/cnxk_ml_ops.c > +++ b/drivers/ml/cnxk/cnxk_ml_ops.c > @@ -9,6 +9,10 @@ > > #include "cn10k_ml_ops.h" > > +#ifdef RTE_MLDEV_CNXK_ENABLE_MVTVM > +#include "mvtvm_ml_ops.h" > +#endif > + > #include "cnxk_ml_dev.h" > #include "cnxk_ml_io.h" > #include "cnxk_ml_model.h" > @@ -625,6 +629,12 @@ cnxk_ml_dev_configure(struct rte_ml_dev *dev, const = struct rte_ml_dev_config *co > goto error; > } > > +#ifdef RTE_MLDEV_CNXK_ENABLE_MVTVM If this #ifdef used a lot place in code like this, Please have stub and segregate at once place in header file and avoid ifdef main code like cnxk_ml_dev_configure().