From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 765B9A04B0; Sat, 24 Oct 2020 14:58:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 074E1BBB4; Sat, 24 Oct 2020 14:58:45 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 81E7737B4 for ; Sat, 24 Oct 2020 14:58:43 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id h21so5274983iob.10 for ; Sat, 24 Oct 2020 05:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XkjKj/byKcGf7kFz1E6AWR2xOg/caZ16YSQOImTNwu8=; b=gFyXYDtwTva8pjtZfXypI7RbRFrCuNlr/3F21PGcF7+7rzvOyy9fi7j9O2PboDsZmr fGIzwwCNyqwIgRpW9m4dXDXcKIcEgmQ3ljekD9+q8/4fka+U8l3Lu19OvRQJGHzgh9b5 G/XO4rwytkEN0lKxikEQbnkUlibGGiapZxRyU8QJJ6k0f+jTXU7mPAYa91q2+xnNDwrz 2Jlbtuu7jsyaEXdGpiciVlK31w+YFy0kyxMA74pVlz8twMJjN/ES/M1UqJwQNou86ygi wNgD2bzCrkMyDG7Es2kcGA837ralf7/83PGnTf2i6HpNLIM6FiL8iqgrCpM1olx1hGMz 2mmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XkjKj/byKcGf7kFz1E6AWR2xOg/caZ16YSQOImTNwu8=; b=BQYNCWcmLpYwJ4Tl1Hs6+jdWcsPJ7P6JdZCVWVOaC4PCy3JGjj5Di6Hmv0nOEm6vZW vncDM1uDr8LZ+HH9rvgES8MV1VKL7bTZhGg21hSqFo/yOt2M9HGrakn4vQIsQB5kUOKs TSbqiB/ZQWNmCJVl1Tpxpg7PgwGVAD8xfTxNAZVZ3iWR5leSJAkz2Xay+o1M0dvRdi4a zlL/ljc9cgtchTBZWfP+nlXk5xSKuwYs1W8YDmHLSaW2ElA8ci6I6Wqu93s58FPmI0Jd ZQYA9dxKWpF9JIDRzbYDcjWBkweku5kL7oNlowD+Y4vDr2eKd+OWZBpE9c0J8rVfb6Q8 CZEA== X-Gm-Message-State: AOAM530j1mW0GA3aWi12pgSQFSAGXHU/ND4eZckpIRE3gMIC6mU/2sRI C6vN6xVc/x9bZqk6HkOhbow5HxCbDzpSZkkjAbk= X-Google-Smtp-Source: ABdhPJx9ioPZNu7R0CY2jiol0YQuaJpWudd34so0WHMu+chU5V0f5DOrSva25DWR/U0f2vLammxhnZ92RhSHnuBN4lc= X-Received: by 2002:a05:6638:98:: with SMTP id v24mr5213064jao.113.1603544321585; Sat, 24 Oct 2020 05:58:41 -0700 (PDT) MIME-Version: 1.0 References: <1599855987-25976-2-git-send-email-timothy.mcdaniel@intel.com> <1603477826-31374-1-git-send-email-timothy.mcdaniel@intel.com> <1603477826-31374-2-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1603477826-31374-2-git-send-email-timothy.mcdaniel@intel.com> From: Jerin Jacob Date: Sat, 24 Oct 2020 18:28:25 +0530 Message-ID: To: Timothy McDaniel Cc: Thomas Monjalon , Bruce Richardson , John McNamara , Marko Kovacevic , Ray Kinsella , Neil Horman , dpdk-dev , Erik Gabriel Carrillo , Gage Eads , "Van Haaren, Harry" , Jerin Jacob Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 01/23] event/dlb2: add documentation and meson build infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 23, 2020 at 11:59 PM Timothy McDaniel wrote: > > Adds the meson build infrastructure, which includes > compile-time constants in rte_config.h. DLB2 is > only supported on Linux X86 platforms at this time. > > Signed-off-by: Timothy McDaniel > Reviewed-by: Gage Eads There is the following build error[1] with this patch when testing with the latest dpdk-next-eventdev branch. Timothy, Please check ./devtools/test-meson-builds.sh for each patch before sending the next version of DLB and DLB2 to avoid delay in pulling this series. [1] Message: Disabling mlx5 [drivers/vdpa/mlx5]: missing internal dependency "common_mlx5" drivers/meson.build:179: WARNING: Custom target input '/export/dpdk-next-eventdev/drivers/event/dlb2/version.map' can't be converted to File object(s). This will become a hard error in the future. drivers/meson.build:184: WARNING: Custom target input '/export/dpdk-next-eventdev/drivers/event/dlb2/version.map' can't be converted to File object(s). This will become a hard error in the future. drivers/meson.build:207:3: ERROR: File /export/dpdk-next-eventdev/drivers/event/dlb2/version.map does not exist. > --- > MAINTAINERS | 5 +++ > config/rte_config.h | 7 ++++ > doc/guides/eventdevs/dlb2.rst | 40 +++++++++++++++++= ++++++ > doc/guides/eventdevs/index.rst | 1 + > drivers/event/dlb2/meson.build | 13 ++++++++ > drivers/event/dlb2/rte_pmd_dlb2_event_version.map | 3 ++ > drivers/event/meson.build | 3 +- > 7 files changed, 71 insertions(+), 1 deletion(-) > create mode 100644 doc/guides/eventdevs/dlb2.rst > create mode 100644 drivers/event/dlb2/meson.build > create mode 100644 drivers/event/dlb2/rte_pmd_dlb2_event_version.map > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3b16d7a..f732f28 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1188,6 +1188,11 @@ M: Peter Mccarthy > F: drivers/event/opdl/ > F: doc/guides/eventdevs/opdl.rst > > +Intel DLB2 Eventdev PMD > +M: Timothy McDaniel > +F: drivers/event/dlb2/ > +F: doc/guides/eventdevs/dlb2.rst > + > > Rawdev Drivers > -------------- > diff --git a/config/rte_config.h b/config/rte_config.h > index 0bae630..fd1b3c3 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -131,4 +131,11 @@ > /* QEDE PMD defines */ > #define RTE_LIBRTE_QEDE_FW "" > > +/* DLB2 defines */ > +#define RTE_LIBRTE_PMD_DLB2_POLL_INTERVAL 1000 > +#define RTE_LIBRTE_PMD_DLB2_UMWAIT_CTL_STATE 0 > +#undef RTE_LIBRTE_PMD_DLB2_QUELL_STATS > +#define RTE_LIBRTE_PMD_DLB2_SW_CREDIT_QUANTA 32 > +#define RTE_PMD_DLB2_DEFAULT_DEPTH_THRESH 256 > + > #endif /* _RTE_CONFIG_H_ */ > diff --git a/doc/guides/eventdevs/dlb2.rst b/doc/guides/eventdevs/dlb2.rs= t > new file mode 100644 > index 0000000..e3091c9 > --- /dev/null > +++ b/doc/guides/eventdevs/dlb2.rst > @@ -0,0 +1,40 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright(c) 2020 Intel Corporation. > + > +Driver for the Intel=C2=AE Dynamic Load Balancer (DLB2) > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > + > +The DPDK dlb poll mode driver supports the Intel=C2=AE Dynamic Load Bala= ncer. > + > +Prerequisites > +------------- > + > +Follow the DPDK :ref:`Getting Started Guide for Linux ` to se= tup > +the basic DPDK environment. > + > +Configuration > +------------- > + > +The DLB2 PF PMD is a user-space PMD that uses VFIO to gain direct > +device access. To use this operation mode, the PCIe PF device must be bo= und > +to a DPDK-compatible VFIO driver, such as vfio-pci. > + > +Eventdev API Notes > +------------------ > + > +The DLB2 provides the functions of a DPDK event device; specifically, it > +supports atomic, ordered, and parallel scheduling events from queues to = ports. > +However, the DLB2 hardware is not a perfect match to the eventdev API. S= ome DLB2 > +features are abstracted by the PMD such as directed ports. > + > +In general the dlb PMD is designed for ease-of-use and does not require = a > +detailed understanding of the hardware, but these details are important = when > +writing high-performance code. This section describes the places where t= he > +eventdev API and DLB2 misalign. > + > +Flow ID > +~~~~~~~ > + > +The flow ID field is preserved in the event when it is scheduled in the > +DLB2. > + > diff --git a/doc/guides/eventdevs/index.rst b/doc/guides/eventdevs/index.= rst > index bb66a5e..738788d 100644 > --- a/doc/guides/eventdevs/index.rst > +++ b/doc/guides/eventdevs/index.rst > @@ -11,6 +11,7 @@ application through the eventdev API. > :maxdepth: 2 > :numbered: > > + dlb2 > dpaa > dpaa2 > dsw > diff --git a/drivers/event/dlb2/meson.build b/drivers/event/dlb2/meson.bu= ild > new file mode 100644 > index 0000000..5324043 > --- /dev/null > +++ b/drivers/event/dlb2/meson.build > @@ -0,0 +1,13 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2019-2020 Intel Corporation > + > +if not is_linux or not dpdk_conf.has('RTE_ARCH_X86_64') > + build =3D false > + reason =3D 'only supported on ARCH_X86_64 Linux' > + subdir_done() > +endif > + > +sources =3D files( > +) > + > +deps +=3D ['mbuf', 'mempool', 'ring', 'pci', 'bus_pci'] > diff --git a/drivers/event/dlb2/rte_pmd_dlb2_event_version.map b/drivers/= event/dlb2/rte_pmd_dlb2_event_version.map > new file mode 100644 > index 0000000..4a76d1d > --- /dev/null > +++ b/drivers/event/dlb2/rte_pmd_dlb2_event_version.map > @@ -0,0 +1,3 @@ > +DPDK_21 { > + local: *; > +}; > diff --git a/drivers/event/meson.build b/drivers/event/meson.build > index ebe76a7..1a54de4 100644 > --- a/drivers/event/meson.build > +++ b/drivers/event/meson.build > @@ -5,7 +5,8 @@ if is_windows > subdir_done() > endif > > -drivers =3D ['dpaa', 'dpaa2', 'octeontx2', 'opdl', 'skeleton', 'sw', 'ds= w'] > +drivers =3D ['dlb2', 'dpaa', 'dpaa2', 'octeontx2', 'opdl', 'skeleton', '= sw', > + 'dsw'] > if not (toolchain =3D=3D 'gcc' and cc.version().version_compare('<4.8.6'= ) and > dpdk_conf.has('RTE_ARCH_ARM64')) > drivers +=3D 'octeontx' > -- > 2.6.4 >