DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: jerinj@marvell.com
Cc: Thomas Monjalon <thomas@monjalon.net>,
	dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH 1/2] devtools: support skipping forbid rule check
Date: Fri, 17 Nov 2023 10:04:42 +0530	[thread overview]
Message-ID: <CALBAE1NDkTtt8SYy4j-uOHYdqqKBwbzWuDsbujtF-994bfSMmA@mail.gmail.com> (raw)
In-Reply-To: <20231004122753.3261337-1-jerinj@marvell.com>

On Wed, Oct 4, 2023 at 11:56 PM <jerinj@marvell.com> wrote:
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> In some case, a set of files in directory may need to skip forbid
> rules check.
>
> Added an infrastructure to enable the same using SKIP_FILES variable.
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>

Ping for review

> ---
>  devtools/check-forbidden-tokens.awk | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/devtools/check-forbidden-tokens.awk b/devtools/check-forbidden-tokens.awk
> index 026844141c..90d3a64f8e 100755
> --- a/devtools/check-forbidden-tokens.awk
> +++ b/devtools/check-forbidden-tokens.awk
> @@ -58,8 +58,11 @@ BEGIN {
>         for (i in deny_folders) {
>                 re = "^\\+\\+\\+ b/" deny_folders[i];
>                 if ($0 ~ re) {
> -                       in_file = 1
> -                       last_file = $0
> +                       # Check only if the files are not part of SKIP_FILES
> +                       if (!(length(SKIP_FILES) && ($re ~ SKIP_FILES))) {
> +                               in_file = 1
> +                               last_file = $0
> +                       }
>                 }
>         }
>  }
> --
> 2.42.0
>

      parent reply	other threads:[~2023-11-17  4:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04 12:27 jerinj
2023-10-04 12:27 ` [dpdk-dev] [PATCH 2/2] devtools: forbid rte symbols in cnxk base driver jerinj
2023-11-28 11:54   ` Thomas Monjalon
2023-11-17  4:34 ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1NDkTtt8SYy4j-uOHYdqqKBwbzWuDsbujtF-994bfSMmA@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).