From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 73E88A00C5;
	Sun, 26 Apr 2020 19:42:32 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id B3F9A1C0DA;
	Sun, 26 Apr 2020 19:42:31 +0200 (CEST)
Received: from mail-io1-f66.google.com (mail-io1-f66.google.com
 [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id D4E431BF46
 for <dev@dpdk.org>; Sun, 26 Apr 2020 19:42:30 +0200 (CEST)
Received: by mail-io1-f66.google.com with SMTP id y26so6483497ioj.2
 for <dev@dpdk.org>; Sun, 26 Apr 2020 10:42:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=u2Z4USqtclMlHUlfFDIs9ZuvNIq9VUCpuSa+qCTHsc8=;
 b=t/vKj0mR2tUlVm6K0J39yItrRlHaDXXY3c4CcJiTTrDmRGpkadyxr0EdksbjhSayCo
 ++BqJFNwVOK7mTo4i9Y3WRJgEDHLG2OQELq5dU9SX0l85uIcSS6wphZt/QEwsQgOSBkU
 nHRLA2MqtqPG2ffb+C7NfiqfE8KAhbjhDU0gNxYe/E3xuAISO6IMrcbLDwawu1wMxwJ3
 +OqjXrRub4QQqXUZjd53U90572QlXWCVSpAUwfzevISIj0DON2R2QdJa7DwpLC6FZFKH
 /qAPVa7ATh50UUkJw5ZrdG86UmblXe2zZ6KXUNJe8qEOyEzMCz187ouJ2zLIK3p8vScM
 jwGQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=u2Z4USqtclMlHUlfFDIs9ZuvNIq9VUCpuSa+qCTHsc8=;
 b=mAWC5WX9H+v7sz5vLiun87v5TsL05Idn1MryYGxijrS/YJ/JRkZ3LbvL+srpWZ+sZA
 AHNCmu37q4BIXwzxjXqQYtYVVa1eVDxGbkQCBxPQPufXaa9Ki3TB3/XzwLRIGc1mV6CS
 j2XBHAyquMx6Fnpq+jsfnRPNy5tTj03ywTn8zcrBLXulgovvBy1l5cH8DGc67yyq1a58
 sNtcMIxRNMGLC9sbiBXGjkYaocM6EwWmeAkkdAZTQODLLanAEhbc3TjloYhfRcgySksU
 IvlivOnrfiJoZRfhDY8VH/KtBuirDCa0q1ajYXJL61fdA3s6dhH4wVU+Pk9aY0K7bseT
 aHRg==
X-Gm-Message-State: AGi0PubnQ4TFDh1VR6srA0ZYgYIeKNi9qK/KaijKrz5Ec6PjsoKBI6cE
 inWHV44Rc+Q1Ng9xZttal4KlmUTpXvxdxEmLM/c=
X-Google-Smtp-Source: APiQypJh6aiP1F2bZSp/XtcGi3frWE8OnCXC8c7lu25Tc0SRJfIb9gzghxkU0dKg65t8EzCL5MO7pSr3dCq2fXcruxE=
X-Received: by 2002:a02:9a0d:: with SMTP id b13mr17160322jal.60.1587922949980; 
 Sun, 26 Apr 2020 10:42:29 -0700 (PDT)
MIME-Version: 1.0
References: <20200121080021.2835490-1-jerinj@marvell.com>
 <5378505.1B3tZ46Xf9@xps>
 <CALBAE1MRwkM=Z0AuRq3gnzMb1k5o-s5PvXscSM=1_M5F4zFQnQ@mail.gmail.com>
 <7318372.iedYuu7f5S@thomas>
In-Reply-To: <7318372.iedYuu7f5S@thomas>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Sun, 26 Apr 2020 23:12:14 +0530
Message-ID: <CALBAE1NF86RdFMpdDF9W3881N6bkK_xM_PXDaJAWJsA+5L6H6A@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>, 
 Olivier Matz <olivier.matz@6wind.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute
	minimum
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 06/02/2020 15:36, Jerin Jacob:
> > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 21/01/2020 09:00, jerinj@marvell.com:
> > > > From: Jerin Jacob <jerinj@marvell.com>
> > > >
> > > > Some machines may have a lot of PCI devices, logs from PCI probe
> > > > creates a lot of clutter on boot-up, typically one needs
> > > > to scroll the screen to find other issues in boot-up.
> > > >
> > > > This patch changes the loglevel of PCI probes to `debug`
> > > > to reduce the clutter on default boot-up logs
> > >
> > > I think the PCI probe informations are... informational.
> > > Maybe you are just not interested in info logs.
> > > If this is the case, I suggest to change the log level at runtime.
> >
> > I am wondering, what would be the right balance, Following is DPDK
> > startup output from octeontx2[1]
> > It creates a lot of clutter in the "default" boot up. Why not enable
> > below prints using log level at runtime?
> > I believe it comes as a debug category, i.e information required to
> > debug if something is not working,
> > dpdk bind script already lists what is bound to DPDK.
> >
> > Suggestion to remove clutter?
>
> I suggest using dynamic log level in the PCI driver.
> Unfortunately a lot of old DPDK code is still using the old log macros.
> Some cleanup work is needed here.

Sent an alternative fix to skip probing the devices with RTE_KDRV_NONE.
I think that is the source of the problem.
http://patches.dpdk.org/patch/69351/


>
>