From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A40DA0613 for ; Mon, 23 Sep 2019 10:00:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00F8A1BEFE; Mon, 23 Sep 2019 10:00:34 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 7B01A2C6A for ; Mon, 23 Sep 2019 10:00:32 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id c6so17999321ioo.13 for ; Mon, 23 Sep 2019 01:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HwztfXhcA4kmgmuV7/X/fiuuyaEzOkfG2IcR6sjJWX8=; b=O0jckQCar+LKjGOgQVhKdHagLS6Fn8mP80jCILVpmd4SnBLytMUj2FEQ8Ybc3zA7Dx llXECY91DV19mg6rA/RZ9t8iDCoouRuewuZrDMmFEG6A3SXo9msIyF5sthBTdIApb9JS uGgoxR8avx/HwOv5GrI48iRU8gM9clV47hmSNAhUO/vfe8Jwwdgv6c72T7vlVNPk5e2p ui/2VoPGxg9c/8Tem8aNDQVOlGbx3cCtz//AuHZZ2EA73B708kUC9lB3777fAj3ihvd3 xEgkVZpfgIMoOh6sh7KkcPk9/M0HU7qyutVdEmhYMRcXtgoQcR9+aa0xw+cS1XIaZUnv 67kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HwztfXhcA4kmgmuV7/X/fiuuyaEzOkfG2IcR6sjJWX8=; b=FuLoSyNiIGsA80wOohYW2VEYmLdKtfwKtjf4YMrH5Rmao1g041tZ/4utL21gaSNi/W N61Q8s4rSm7SDwPkFeUL6I4ViHrPEJQJ4AaJfId6mSt6AUZYW1n0xOOX2Z24TK2tUNaT CUYU6Kx1tSCDNz4d2yuFEw7KrKj57fpudbw4wMMs2H19Big7LT/zSxLeyCayh7UkWGow d6+LJxsM45ULI67LUIJrlYkStcU/0i3Qm19DfSC27VGJYMfIdAdXcweMR3HhLsApuVVD cQnTdZizKO7/Ed1noMmY8nHAlkWpdXjWepX92/1TnYZdE8/4D1WMARcJu6tJ6iZl6fBl 6S+w== X-Gm-Message-State: APjAAAVBV9siLqQQuuvfelTy3s2YzQi3cFmSKTdDXhnq/iXPNaUsAa+J +yeK5TBMr8qm4gGCXrY8YbulndIu5nHXh576zpU= X-Google-Smtp-Source: APXvYqzrACY8PclDfq/9dWGcd4n7VHXgTqSWVaYEMlZSCYL37qhDUYZAP5n0Rk3Sh3E0OKi9pig6XZ8XB/qsiNhNzt0= X-Received: by 2002:a02:c8cd:: with SMTP id q13mr34725385jao.133.1569225631622; Mon, 23 Sep 2019 01:00:31 -0700 (PDT) MIME-Version: 1.0 References: <20190816041955.69877-1-ndabilpuram@marvell.com> In-Reply-To: From: Jerin Jacob Date: Mon, 23 Sep 2019 13:30:20 +0530 Message-ID: To: Nithin Dabilpuram Cc: Jerin Jacob , Kiran Kumar K , dev@dpdk.org, Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix port Tx VLAN insertion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 13, 2019 at 8:10 PM Jerin Jacob wrote: > > On Fri, Aug 16, 2019 at 9:50 AM Nithin Dabilpuram > wrote: > > > > This patch fixes configuration for port Tx vlan insertion feature. > > As per latest Tx KEX profile, pf_func should be at > > KW[0](47:32) and not KW[1](63:48). > > > > Fixes: 168c59cfe42b ("net/octeontx2: add flow MCAM utility functions") > > Cc: kirankumark@marvell.com > > Cc: stable@dpdk.org > > > > > Signed-off-by: Nithin Dabilpuram > > Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > > > > --- > > drivers/net/octeontx2/otx2_vlan.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/octeontx2/otx2_vlan.c b/drivers/net/octeontx2/otx2_vlan.c > > index c01089b..2be7671 100644 > > --- a/drivers/net/octeontx2/otx2_vlan.c > > +++ b/drivers/net/octeontx2/otx2_vlan.c > > @@ -468,9 +468,9 @@ nix_vlan_handle_default_tx_entry(struct rte_eth_dev *eth_dev, > > pf_func = (dev->pf_func & 0xff) << 8; > > pf_func |= (dev->pf_func >> 8) & 0xff; > > > > - /* PF Func extracted to KW1[63:48] */ > > - entry.kw[1] = (uint64_t)pf_func << 48; > > - entry.kw_mask[1] = (BIT_ULL(16) - 1) << 48; > > + /* PF Func extracted to KW1[47:32] */ > > + entry.kw[0] = (uint64_t)pf_func << 32; > > + entry.kw_mask[0] = (BIT_ULL(16) - 1) << 32; > > > > nix_set_tx_vlan_action(&entry, type, vtag_index); > > vlan->def_tx_mcam_ent = entry; > > -- > > 2.8.4 > >