From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95FEBA2F67 for ; Fri, 4 Oct 2019 17:49:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3495A1C23A; Fri, 4 Oct 2019 17:49:08 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id B4C6B1BEC0 for ; Fri, 4 Oct 2019 17:49:06 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id c25so14478864iot.12 for ; Fri, 04 Oct 2019 08:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JA73TiEWq3BjG3/EhISDfa287kcBLRYq1tz7l3iV02w=; b=Hm/XqjxZjn+GjLnCr4WqXc9SKzdgzVJ0QeiarndcizQeFNLuQrliJw5JlhvmFbuA7n Dr0ZlBktMj8mMh5Uc3lX5KJ716n/m/cpzhdYNFrNj4ue+AfwlGzLuPlisS8OYxMsMqcp AGY7rUr/CHBUUd4KEeaPmMmXOq0kkJRYLkPhNKlsFxhLZl2B6J98v0O9WrkbgRq5ZdiI QV8OlUXyCSRc5LI6vkVqfval5IU/dKl2hBx0p7w+gJXNfeEDWEtlJbbVxJrQgxrCn2/Q HCTy8AdOUqK0V34ulRvw3zZHY1C0zm2sR1VFUoDWeKn8+1LQPDrFoVNwO9ChV2sEtO2y hf7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JA73TiEWq3BjG3/EhISDfa287kcBLRYq1tz7l3iV02w=; b=CaWrJya03uU3G5RISsoAd5wEVTzvRYDSWyLMR9ZHdPpviQe4muCUA7OQCIKQIaQ4Pr squGE70KtrPyW8DjWvTUvJEVbkslPILU/GQDp7Irdic1B/mLFQFSIi1ip2r5fI3d4W7I GVerF+Sf2SnkLOcQ8EmHAVLLz3DFmek5Xe/cwrk9eu42eFcvmibZ0Rq6T8RfwnGK6/8b zu5SA5uyCPdHAyGHBAOSren9IpwdpQRT3bQYRS4DftL2obiOtYpFtjwgWJ7bicYHt1tq vri+2XUcGny48V9t6XndTHi3bN5wPLMyzNRVwEjvl3s6xBp29+511Hdx8l8J2Pb5lZCQ 3bXg== X-Gm-Message-State: APjAAAWrk7Tetv+S92l5CD4utb6xvEoYiJUoulTk/Fj9RH8x2myXI+5x nv/jsEJzaA/G9XOwZIYD+RTxxUdGbyTiNe5jYNQ= X-Google-Smtp-Source: APXvYqx94gXUdrKtyTej7BLkqSE9CA5FhPw+t0n1QhJlZpT+8+LVwnFbO9iLssAj/DktKR+GPARkMym9WroQ7CNYXVs= X-Received: by 2002:a5d:9f15:: with SMTP id q21mr661227iot.130.1570204145856; Fri, 04 Oct 2019 08:49:05 -0700 (PDT) MIME-Version: 1.0 References: <20190910110324.27861-1-vattunuru@marvell.com> In-Reply-To: <20190910110324.27861-1-vattunuru@marvell.com> From: Jerin Jacob Date: Fri, 4 Oct 2019 21:18:54 +0530 Message-ID: To: Vamsi Attunuru Cc: dpdk-dev , Thomas Monjalon , Jerin Jacob Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1 1/1] mempool/octeontx2: remove minimum chunck size limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 10, 2019 at 4:33 PM wrote: > > From: Vamsi Attunuru > > Memory required for the mempool objects need not be physically > contiguous on octeontx2's HW, mempool pmd supports the minimum chunk > size set by the default handler. Hence discarding the limitation set > by the pmd on the min_chunk_size value. > > Signed-off-by: Vamsi Attunuru Acked-by: Jerin Jacob This patch needs to go through to master repo based on MAINTAINERS file. Changing the "Delegate to" to Thomas in patchwork. > --- > drivers/mempool/octeontx2/otx2_mempool_ops.c | 16 ++-------------- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c > index f5a4fe3..d769575 100644 > --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c > +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c > @@ -713,24 +713,12 @@ static ssize_t > otx2_npa_calc_mem_size(const struct rte_mempool *mp, uint32_t obj_num, > uint32_t pg_shift, size_t *min_chunk_size, size_t *align) > { > - ssize_t mem_size; > - > /* > * Simply need space for one more object to be able to > * fulfill alignment requirements. > */ > - mem_size = rte_mempool_op_calc_mem_size_default(mp, obj_num + 1, > - pg_shift, > - min_chunk_size, align); > - if (mem_size >= 0) { > - /* > - * Memory area which contains objects must be physically > - * contiguous. > - */ > - *min_chunk_size = mem_size; > - } > - > - return mem_size; > + return rte_mempool_op_calc_mem_size_default(mp, obj_num + 1, pg_shift, > + min_chunk_size, align); > } > > static int > -- > 2.8.4 >