From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABEA7A04B8; Tue, 5 May 2020 17:25:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8CB41D610; Tue, 5 May 2020 17:25:54 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id B92531D60D for ; Tue, 5 May 2020 17:25:52 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id u11so2367195iow.4 for ; Tue, 05 May 2020 08:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8KiLn1BlHd0QLLFvi++BIgYT1naVjflbhH1DDkY+iiM=; b=bAAaE7AE7+kb8gxeq5tlCt6S3z04R9D7x8xYLCAkpaNAGKE0cQWA9Kn0dCdQXODeBV B3D0tH3auyc1juVipOjnmMw3S/+K6HPJ8t85kJZHuuOIwIsVPyOykFqKmq5NEa88deu6 AehvPyzExsPLjbw8YlEnkZTzZtu8nVrEEp8JtlbGMdLPfDsSDO4zQr2Wrhfc+Pjjm0qH RWd/nIpvW/J6DZHZPXyUkLkCHT9w24RAB9poQobKQd30UzpTskKsV9aLxEQyJipngdra yGRb7NsRE1TXiMCnQPwIyLFx/Wcl2CmvFv6qXkUlxBD0UtBuiQruvTjrPpcRvvv0q3W6 POUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8KiLn1BlHd0QLLFvi++BIgYT1naVjflbhH1DDkY+iiM=; b=TSIMnYvZcnDN3ERUSu6/ZHqIRonRyKYaRAojOqA9g3jLThOIusx4YYKbEK3ISl4MgT M7o7S7osOkvcDDe3GaJhicUIO7mNrMPfGRZhoYlZOLoW81wZqpMo+a4Lyt/vKkM0VUhT xGFFwgmnEcFp/OrsU+ojidKhvetMketEE06nZ5xlpf3++bdu3y8y8dvwsYp5HvLXJFEy fPnxZoKA+3UFHx2ieaP05QVcf84CP6tZrqDqTLEtfkNyudHnzWewKcVKISJQ6mkBSJ7b 0Sf3KDuLlQXQ98plQkhdIcc1xjrRhx7XUgllPkh8GZGyBZNkCS2khePqoxUCCif6Hu3o wgMg== X-Gm-Message-State: AGi0PuZxPizl0MNJ6p4fgNys7JQaW0/4v4Jqk0CMXSFKKO2bb57JShgp myV12vFtskr/u+JBLUdYASyFSms881q2wdcsV0Y= X-Google-Smtp-Source: APiQypIMIcuWmI5/jEikyF5S8vdkzWXXpBdbNE3pY+hzs46AtF7wUzPs+AhbG5Tbnf65XHv7oqtpjmVEvs9t3gO0Jko= X-Received: by 2002:a5e:9806:: with SMTP id s6mr3941219ioj.59.1588692351847; Tue, 05 May 2020 08:25:51 -0700 (PDT) MIME-Version: 1.0 References: <20200503203135.6493-1-david.marchand@redhat.com> <2596990.BEx9A2HvPv@thomas> <2479551.BddDVKsqQX@thomas> In-Reply-To: From: Jerin Jacob Date: Tue, 5 May 2020 20:55:35 +0530 Message-ID: To: David Marchand Cc: Thomas Monjalon , dpdk-dev , Jerin Jacob , Sunil Kumar Kori , John McNamara , Marko Kovacevic , Declan Doherty , Ferruh Yigit , Andrew Rybchenko , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 5, 2020 at 5:56 PM Jerin Jacob wrote: > > On Tue, May 5, 2020 at 5:06 PM David Marchand wrote: > > > > On Tue, May 5, 2020 at 12:13 PM Jerin Jacob wrote: > > > > > Please share the data. > > > > > > > > Measured time between first rte_trace_point_register and last one with > > > > a simple patch: > > > > > > I will try to reproduce this, once we finalize on the above synergy > > > with rte_log. > > > > I took the time to provide measure but you won't take the time to look at this. > > I will spend time on this. I would like to test with a shared library > also and more tracepoints. > I was looking for an agreement on using the constructor for rte_log as > well(Just make sure the direction is correct). > > Next steps: > - I will analyze the come back on this overhead on this thread. I have added 500 constructors for testing the overhead with the shared build and static build. My results inline with your results aka negligible overhead. David, Do you have plan for similar RTE_LOG_REGISTER as mentioned earlier? I would like to have rte_log and rte_trace semantics similar to registration. If you are not planning to submit the rte_log patch then I can send one for RC2 cleanup. > - Olivier is OK for changing the RTE_LOG_REGSISTER macro, So we could > clean the log as well. > > > > Really nice. > > > > > > > > > -- > > David Marchand > >