From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E15042C58; Thu, 8 Jun 2023 07:34:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 194D040A84; Thu, 8 Jun 2023 07:34:27 +0200 (CEST) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by mails.dpdk.org (Postfix) with ESMTP id 0343440042 for ; Thu, 8 Jun 2023 07:34:25 +0200 (CEST) Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-75d4df773b4so16063085a.0 for ; Wed, 07 Jun 2023 22:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686202465; x=1688794465; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oDYocms2M5W+wRGEf8CCuXn2HEJph4bRRY1XOg1mW7c=; b=BLy+eBYhTA6ENR4YltIQyc41RhkRuA10wvYPipEFmEnVS4t8ObsKreb4K+ROMyF9jK kKGLQ9hOmvCvThfLHOrCSlK3LDU8udcyeeUf13baqYkTQez57sgRb9gf06O4wCFbLIHw /RSrCuJc/7M7dkpsSAQ1tiTRdenC/iRHzuZXjKguTgq00IXh3adqfTBMYSD9w3qUrzZM u9NLSapzTIiDq7IdNaKNPaX3/LBnkEQkGOl21dXBAQj3Q8yl6RppIvo3TdsxWHM5SDOH sbifGCFrjIHh5jy9Nnzk4+aMQLBn8iNH9slAUg1HMQ4dzjqIdWSTN/z/g08m2ZbYqBoi t8jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686202465; x=1688794465; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oDYocms2M5W+wRGEf8CCuXn2HEJph4bRRY1XOg1mW7c=; b=e4OKTJhe4/S6SL6Eo0x52m1vHSMYSi7o945aX+oaTX7TOno1ixkk8GVNM1IapqYY9C RYHfsBtlvLNP4afPYoZxEWP5qX7QWgQ83NPnI8JMOPDbXHxo99J2lSaLes6Gvz9ry891 B2ZX4Zx1qv2BP0rHkhK+B/s9hjeQq/VBbF8Z0h2rT7mn+eQyUUFVvfGx/2FGzqrcITP3 idRarF+iqqBaxZzL54w7VUf0REhCRa9sTgaD6dT/ODG5L44sZ6a6R3RR+atgcmlFWkHc NTe2pQoD4eWTk+FcsfwlomnzvPJDxexs/5/3RLhl5ZsM8m/p7FOnwV/DlX0UXWVKA3jT dktA== X-Gm-Message-State: AC+VfDxV2wOD8tL5b+mUaC/T+NSyCWCEWvq+EO1hY7LzVYScinFcaQKX ciyh+JZQF7a00DwuKrip5zScFQYlrzCKwYmJC9x9tq3EVpigPw== X-Google-Smtp-Source: ACHHUZ6U3SmE6gA5l/A5CVsgBn/YOsO1eGh61V0GqDL+6ypQZjM2HQeyeOJQzTAniyOHjvrMqrl98iEg6U5CHf9FfqU= X-Received: by 2002:a05:620a:845:b0:75b:23a1:438 with SMTP id u5-20020a05620a084500b0075b23a10438mr3777363qku.78.1686202465245; Wed, 07 Jun 2023 22:34:25 -0700 (PDT) MIME-Version: 1.0 References: <20230606144746.708388-1-zhirun.yan@intel.com> <20230607035144.1214492-1-zhirun.yan@intel.com> <20230607035144.1214492-14-zhirun.yan@intel.com> In-Reply-To: From: Jerin Jacob Date: Thu, 8 Jun 2023 11:03:59 +0530 Message-ID: Subject: Re: [PATCH v9 13/17] graph: enable graph multicore dispatch scheduler model To: "Yan, Zhirun" Cc: "dev@dpdk.org" , "jerinj@marvell.com" , "kirankumark@marvell.com" , "ndabilpuram@marvell.com" , "stephen@networkplumber.org" , "pbhagavatula@marvell.com" , "Liang, Cunming" , "Wang, Haiyue" , "mattias.ronnblom" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 8, 2023 at 8:39=E2=80=AFAM Yan, Zhirun w= rote: > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Wednesday, June 7, 2023 9:26 PM > > To: Yan, Zhirun > > Cc: dev@dpdk.org; jerinj@marvell.com; kirankumark@marvell.com; > > ndabilpuram@marvell.com; stephen@networkplumber.org; > > pbhagavatula@marvell.com; Liang, Cunming ; Wan= g, > > Haiyue ; mattias.ronnblom > > > > Subject: Re: [PATCH v9 13/17] graph: enable graph multicore dispatch sc= heduler > > model > > > > On Wed, Jun 7, 2023 at 5:55=E2=80=AFPM Yan, Zhirun wrote: > > > > > > > > > > > rte_graph_walk(struct rte_graph *graph) { > > > > > +#if !defined(RTE_GRAPH_MODEL_SELECT) || > > RTE_GRAPH_MODEL_SELECT > > > > =3D=3D > > > > > +RTE_GRAPH_MODEL_RTC > > > > > > > > Is nt defined instead of !defined? > > > > > > > > > > !defined(XX) means not defined XX. > > > What is nt defined means? > > > > #undef RTE_GRAPH_MODEL_SELECT or not #define > > RTE_GRAPH_MODEL_SELECT anywhere in .c file. > > > > In the implementation, RTE_GRAPH_MODEL_SELECT is only defined once in app > I think #if !define(XX) is a judgement, #undef XX is an action. > Here should be #if !define(XX) > For this impl, I treat not define as default and go into rtc_walk(). > > > So If we treat not defined RTE_GRAPH_MODEL_SELECT as runtime pick. > The #else case should cover: 1. Not defined and 2. Defined other type. > It should be as follow: Ack. We are aligned, You can send the next version. Keep my existing Acked-by on the patches which is already reviewed.. I should be able to give Acked-by on the pending one to complete the review= . > > rte_graph_walk() > { > #if defined(RTE_GRAPH_MODEL_SELECT) && RTE_GRAPH_MODEL_SELECT =3D=3D RTE_= GRAPH_MODEL_RTC ( RTE_GRAPH_MODEL_SELECT =3D=3D RTE_GRAPH_MODEL_RTC) > rte_graph_walk_rtc(); > > #elif defined(RTE_GRAPH_MODEL_SELECT) && RTE_GRAPH_MODEL_SELECT =3D=3D RT= E_GRAPH_MODEL_MCORE_DISPATCH (RTE_GRAPH_MODEL_SELECT =3D=3D RTE_GRAPH_MODEL_MCORE_DISPATCH) > rte_graph_walk_mcore_dispatch(graph); > > #else > const int model =3D; > > switch (model) { switch ( rte_graph_worker_model_no_check_get()) { as model not used anywhere else belwo , model is changing to uint8_t > case RTE_GRAPH_MODEL_MCORE_DISPATCH: > rte_graph_walk_mcore_dispatch(); > break; > default: > rte_graph_walk_rtc(); > } > #endif > } > > > > > > > > Use bracket around RTE_GRAPH_MODEL_SELECT =3D=3D > > RTE_GRAPH_MODEL_RTC. > > > > > > > Ok. > > > > > > > > > > > > rte_graph_walk_rtc(graph); > > > > > +#elif defined(RTE_GRAPH_MODEL_SELECT) && > > RTE_GRAPH_MODEL_SELECT > > > > =3D=3D > > > > > +RTE_GRAPH_MODEL_MCORE_DISPATCH > > > > > > > > Use bracket around RTE_GRAPH_MODEL_SELECT =3D=3D > > > Ok. > > > > > > > > > + rte_graph_walk_mcore_dispatch(graph); > > > > > +#else > > > > > + int model =3D rte_graph_worker_model_get(graph); > > > > > > > > Introduce rte_graph_worker_model_no_check_get() as commented earlie= r. > > > > > > Got it. > > >