From: Jerin Jacob <jerinjacobk@gmail.com>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: dpdk-dev <dev@dpdk.org>,
Vamsi Krishna Attunuru <vattunuru@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v3] eal: add manual probing option
Date: Fri, 25 Oct 2019 18:54:23 +0530 [thread overview]
Message-ID: <CALBAE1NLL0LitzV3bCjtSxOgBpJT_b42G28GHCRrJckSSpDuXg@mail.gmail.com> (raw)
In-Reply-To: <20191025125050.m2zpdhmnakoeq43s@bidouze.vm.6wind.com>
> > > rte_eal_check_module(const char *module_name)
> > > {
> > > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> > > index 7cbf82d37..ccc4ffb21 100644
> > > --- a/lib/librte_eal/rte_eal_version.map
> > > +++ b/lib/librte_eal/rte_eal_version.map
> > > @@ -312,6 +312,14 @@ DPDK_19.08 {
> > >
> > > } DPDK_19.05;
> > >
> > > +DPDK_19.11 {
> > > + global:
> > > +
> > > + rte_eal_manual_probe;
> > > + rte_eal_manual_probe_set;
> >
> > Do we need public API for this? it is only used by eal lib.
> >
>
> I think some PMDs and some applications would need to issue warnings to
> the user if manual probing is not enabled (i.e. a port representor
> parameter was used in a PMD, but probing is automatic --> on some
> platform it would work and others it would fail with the same config).
>
> Some applications would also prefer forcing it enabled without having to
> use the option on the command line.
>
> This motivates the public API. Given that there is a public API, I think
it's better to use it even from within the EAL.
No issue from my side to expose through public API as well.
Please rte_eal_manual_probe_set() when setting in flags in eal as well.
Currently rte_eal_manual_probe_set() not used anywhere.
>
> However I agree that it does not need two separate implementations. I
> could move it to some eal_common_* part probably, maybe bus or dev?
eal should be fine. No strong opinion on the place.
>
> > checkpatch complains the following too.
> > ERROR: symbol rte_eal_manual_probe_set is added in the DPDK_19.11
> > section, but is expected to be added in the EXPERIMENTAL section of
> > the version map
>
> The API is simple enough IMO to make it immediately stable: it will
> allow applications forbidding the use of experimental API to make use of
> it.
>
> This is only for the sake of simplicity for some users. I'm not
> opposed to making it experimental first if it's expected for all new
> APIs.
All new APIs are treated as experimental. I don't think, we need to
make an exception here.
Other these nits, This patch looks good.
>
> --
> Gaėtan Rivet
> 6WIND
next prev parent reply other threads:[~2019-10-25 13:24 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 11:56 [dpdk-dev] [PATCH v1 1/1] bus/pci: probe PCI devices in whitelisted order vattunuru
2019-09-25 6:41 ` Slava Ovsiienko
2019-09-25 9:07 ` Gaëtan Rivet
2019-09-26 4:15 ` Vamsi Krishna Attunuru
2019-09-26 8:04 ` Gaëtan Rivet
2019-09-26 9:39 ` [dpdk-dev] [EXT] " Vamsi Krishna Attunuru
2019-09-30 12:51 ` [dpdk-dev] [PATCH v1] eal: add manual probing option Gaetan Rivet
2019-09-30 17:51 ` Aaron Conole
2019-10-01 7:28 ` Gaëtan Rivet
2019-10-01 12:57 ` Aaron Conole
2019-09-30 18:53 ` Stephen Hemminger
2019-10-01 9:10 ` Gaëtan Rivet
2019-10-01 9:49 ` Jerin Jacob
2019-10-01 14:09 ` Gaëtan Rivet
2019-10-01 14:26 ` Jerin Jacob
2019-10-03 7:58 ` [dpdk-dev] [PATCH v2] " Gaetan Rivet
2019-10-04 12:55 ` [dpdk-dev] [PATCH v3] " Gaetan Rivet
2019-10-07 1:27 ` Vamsi Krishna Attunuru
2019-10-23 8:44 ` Gaëtan Rivet
2019-10-25 11:59 ` Jerin Jacob
2019-10-25 12:50 ` Gaëtan Rivet
2019-10-25 13:24 ` Jerin Jacob [this message]
2019-10-25 14:41 ` [dpdk-dev] [PATCH v4] " Gaetan Rivet
2019-10-25 15:01 ` Jerin Jacob
2019-10-25 15:46 ` [dpdk-dev] [PATCH v5] " Gaetan Rivet
2019-10-25 15:51 ` Jerin Jacob
2020-01-22 16:51 ` Pavan Nikhilesh Bhagavatula
2020-01-23 9:20 ` Gaetan Rivet
2020-01-23 9:58 ` [dpdk-dev] [PATCH v7] " Gaetan Rivet
2020-02-03 5:16 ` Pavan Nikhilesh Bhagavatula
2020-02-03 22:21 ` Thomas Monjalon
2020-02-04 10:03 ` Gaetan Rivet
2020-02-04 11:07 ` Thomas Monjalon
2020-02-04 12:43 ` Gaetan Rivet
2020-02-04 15:06 ` Thomas Monjalon
2020-02-04 16:02 ` Gaetan Rivet
2020-02-10 14:51 ` Jerin Jacob
2020-02-10 15:27 ` Thomas Monjalon
2020-02-10 16:33 ` Jerin Jacob
2020-04-03 3:30 ` [dpdk-dev] [PATCH] [v1 1/1] examples/l2fwd: add cmdline option for forwarding port info vattunuru
2020-04-03 12:51 ` Andrzej Ostruszka [C]
2020-04-05 3:49 ` Vamsi Krishna Attunuru
2020-04-05 3:52 ` [dpdk-dev] [PATCH] [v2 " vattunuru
2020-04-06 9:32 ` Andrzej Ostruszka [C]
2020-04-26 21:19 ` Thomas Monjalon
2020-04-27 7:59 ` [dpdk-dev] [PATCH v3] " pbhagavatula
2020-04-27 9:19 ` Sunil Kumar Kori
2020-04-27 9:36 ` Andrzej Ostruszka [C]
2020-04-27 10:14 ` Sunil Kumar Kori
2020-04-27 16:38 ` Pavan Nikhilesh Bhagavatula
2020-04-27 16:49 ` Sunil Kumar Kori
2020-04-27 18:31 ` [dpdk-dev] [PATCH v4] " pbhagavatula
2020-04-28 5:54 ` Sunil Kumar Kori
2020-05-01 14:00 ` Varghese, Vipin
2020-05-01 15:14 ` Pavan Nikhilesh Bhagavatula
2020-05-02 4:34 ` Varghese, Vipin
2020-05-11 0:23 ` Pavan Nikhilesh Bhagavatula
2020-05-24 16:13 ` Thomas Monjalon
2020-05-25 9:29 ` Bruce Richardson
2020-07-04 13:36 ` Jerin Jacob
2020-07-05 12:23 ` Thomas Monjalon
2020-04-04 16:34 ` [dpdk-dev] [EXT] Re: [PATCH v7] eal: add manual probing option Jerin Jacob Kollanukkaran
2023-06-14 19:33 ` [dpdk-dev] " Stephen Hemminger
2023-06-26 16:12 ` Gaëtan Rivet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1NLL0LitzV3bCjtSxOgBpJT_b42G28GHCRrJckSSpDuXg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=jerinj@marvell.com \
--cc=thomas@monjalon.net \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).