From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB256A32A4 for ; Fri, 25 Oct 2019 15:24:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 985A11C1D4; Fri, 25 Oct 2019 15:24:41 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 818D81C1C7 for ; Fri, 25 Oct 2019 15:24:40 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id a13so1841728ilp.1 for ; Fri, 25 Oct 2019 06:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=IbjBWtbDmyqm8CsKz2xjoXGNKK5DWWMiIX6D+hgk6fU=; b=CPXJSO/r22JCEg/96z8XY+vIR7a5D2CZFTIhQAUcEmAyX8YTLhtn8mfAYzMttYurEz fN3tMTvPmOwgviV25aGwtjuRlL6UBo9C+RaK0eyruh+1Z6Cl6vErF2aGW9xz8nqRDqmp ar/0cuuGwrPMDiPrQddEkzhM3R1uSzqhFezaH8kvKjQFoq6bbcQS+AQYji5sExfz3LGP Q5Jtz7t2g8zVS60J6948z9u0P6tc0e+8ILJqhCuvvHApbQUm2u1oSDkk3mKJ3aVTxCtY Zp08XNdlHDDZRXhVO9xT/dImnaM2Kmk/6vTkiAdWkowAIFV/ODPa1to3PtNMc6+lNDUm aQJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IbjBWtbDmyqm8CsKz2xjoXGNKK5DWWMiIX6D+hgk6fU=; b=rxCp4ZrBkbhRX0uWa8nDcJ8egUdSDwmGLQVbJl5CrkfZs2+82HYBM6+wnXamSUvMZ/ m7ElF5ogcCNEkbABxap0MoZMBQnvdCJyK/J5PqUrCCIfl4RJpX7VfKDbXHu2dMLSmdQ3 cP51y9Cz0GeFFvj4J49Ljp5ja+ZpeK+XXlkxV+w2jsk2Mz8wVg0Ur15MAP6bQSaT8mbR PukmVHeN0yoSlyFSia4jS3SBdeEnDg/nXa1T2oX+H7CTuagYy41UbvEVM9KfxikYxghT 6Z0xO+Whixm/Uesk4xtXHlZqwZb+Usj/QnZ14FdBQuV8Uxbmd0i9R1OvKsrBsWcynInT BiAg== X-Gm-Message-State: APjAAAX0KUVKoVwdaDd2xZbTSue+x/GRzcy0Sv4joLwY5R6RGgj47CO4 IkIzTOEk/2kpC65J7jQCglp0tJNnVbtIdjuNzOE= X-Google-Smtp-Source: APXvYqyJlIJGeb5cDSCBFq3gS6boc24hCBsdPzHEX8PLuVSIGPU+VuaWYMKY9l9Jmbi2AqUOJ/q1X40Fv1e6qdJ6uhA= X-Received: by 2002:a92:ce12:: with SMTP id b18mr4343990ilo.130.1572009879607; Fri, 25 Oct 2019 06:24:39 -0700 (PDT) MIME-Version: 1.0 References: <6fff088fbca661b574b5cf27ebb924a690ed7d51.1570089310.git.gaetan.rivet@6wind.com> <5b8ee6827c26356cc009b0b3ff5b8d142b009fa7.1570193349.git.gaetan.rivet@6wind.com> <20191025125050.m2zpdhmnakoeq43s@bidouze.vm.6wind.com> In-Reply-To: <20191025125050.m2zpdhmnakoeq43s@bidouze.vm.6wind.com> From: Jerin Jacob Date: Fri, 25 Oct 2019 18:54:23 +0530 Message-ID: To: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= Cc: dpdk-dev , Vamsi Krishna Attunuru , Ferruh Yigit , Anatoly Burakov , Thomas Monjalon , Jerin Jacob Kollanukkaran , David Marchand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3] eal: add manual probing option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > rte_eal_check_module(const char *module_name) > > > { > > > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_= eal_version.map > > > index 7cbf82d37..ccc4ffb21 100644 > > > --- a/lib/librte_eal/rte_eal_version.map > > > +++ b/lib/librte_eal/rte_eal_version.map > > > @@ -312,6 +312,14 @@ DPDK_19.08 { > > > > > > } DPDK_19.05; > > > > > > +DPDK_19.11 { > > > + global: > > > + > > > + rte_eal_manual_probe; > > > + rte_eal_manual_probe_set; > > > > Do we need public API for this? it is only used by eal lib. > > > > I think some PMDs and some applications would need to issue warnings to > the user if manual probing is not enabled (i.e. a port representor > parameter was used in a PMD, but probing is automatic --> on some > platform it would work and others it would fail with the same config). > > Some applications would also prefer forcing it enabled without having to > use the option on the command line. > > This motivates the public API. Given that there is a public API, I think it's better to use it even from within the EAL. No issue from my side to expose through public API as well. Please rte_eal_manual_probe_set() when setting in flags in eal as well. Currently rte_eal_manual_probe_set() not used anywhere. > > However I agree that it does not need two separate implementations. I > could move it to some eal_common_* part probably, maybe bus or dev? eal should be fine. No strong opinion on the place. > > > checkpatch complains the following too. > > ERROR: symbol rte_eal_manual_probe_set is added in the DPDK_19.11 > > section, but is expected to be added in the EXPERIMENTAL section of > > the version map > > The API is simple enough IMO to make it immediately stable: it will > allow applications forbidding the use of experimental API to make use of > it. > > This is only for the sake of simplicity for some users. I'm not > opposed to making it experimental first if it's expected for all new > APIs. All new APIs are treated as experimental. I don't think, we need to make an exception here. Other these nits, This patch looks good. > > -- > Ga=C4=97tan Rivet > 6WIND