From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 16A87A0032;
	Tue, 28 Sep 2021 11:57:09 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8D19740E3C;
	Tue, 28 Sep 2021 11:57:08 +0200 (CEST)
Received: from mail-il1-f174.google.com (mail-il1-f174.google.com
 [209.85.166.174])
 by mails.dpdk.org (Postfix) with ESMTP id D9C7E40DF6
 for <dev@dpdk.org>; Tue, 28 Sep 2021 11:57:06 +0200 (CEST)
Received: by mail-il1-f174.google.com with SMTP id y15so1518396ilu.12
 for <dev@dpdk.org>; Tue, 28 Sep 2021 02:57:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=t5UlTgEbYqn/wq8vYIVOZQLn0PBt17x0HoJNhr8W0m0=;
 b=CtieHHipRd+u6jo26GGXraE36zppwJjfvDoII5OZsK8HXU9BF2Rm1L8ZRAhPbOHnZf
 ArUMorX5geJ72Uv1VttV7kd/BwEYFYV5PM4PPV2FXaCgoJzRHOtmh43mkmVxDTsL1V5E
 65D55y3Mk1sd87rhtW38mUINX3r8Se9BnVnO8YYezHVsb4uilED9wZLNa8n0lvihBmTf
 ezsfzB5wf4pxqgoT/e1+bvqUcQluYMqPkyktNPZPdDNiczW3Ca37D6maTV+Lj4Tv4739
 k/nkIa/4q8zto1o3QjeXvFkWed4v6TesUyXkz6ymf5X1JPPtgaIFYOyZoas5V5LGTDj/
 EsUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=t5UlTgEbYqn/wq8vYIVOZQLn0PBt17x0HoJNhr8W0m0=;
 b=BIHn5DW3MXJvowz3eIxA2qpE9AdwpFpfUJEj18GiepM+AzSS9O6AA6gCZvnM8D4S8P
 Zg773JdqDCifeuRcfdAdbkkkGFJl9xi5Vhz9sLpAssXC4fXlzXXELdhq7bKM3La3ZGAf
 FQSVEKWmXI6KlFXDT8HSZOSU/PYgV/Qp+7lFhKxyYmbHBrD4an9KwI+LjgEUiw4ZWPxi
 rFk98kdmNORlqUi87SK8pa+h/JwopBiXlI1lNr9zjyx59M8/Sjq9uMWWw3ZYPh8COWqQ
 2GB9SBteKeCLHcVnEL0jzO5Qj1wsZY7rJX95fMP252pHgGV4/exffnaPWwEeLd6Vmel5
 MTxQ==
X-Gm-Message-State: AOAM530yMnVcgN+5y9DY5oNZ1Cg7SLDVH12WGnZDEbqRzQruVo6mo7Tc
 GM9MDBRrmCsQxwnC8pI6PORrkw/XkNStrETAzuw=
X-Google-Smtp-Source: ABdhPJxBKTZNpvRGSxXkXwas10qrcDbe9tm/CjeWSdV49vF6WUUU9dVTF8Gyr1W+2IK8I2o6r/GVfrSQEJTjX7xz6Io=
X-Received: by 2002:a05:6e02:ef4:: with SMTP id
 j20mr3923252ilk.294.1632823026218; 
 Tue, 28 Sep 2021 02:57:06 -0700 (PDT)
MIME-Version: 1.0
References: <20210823194020.1229-1-pbhagavatula@marvell.com>
In-Reply-To: <20210823194020.1229-1-pbhagavatula@marvell.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Tue, 28 Sep 2021 15:26:40 +0530
Message-ID: <CALBAE1NLomw_pS4Xs8U1Efe2NUuBuNkdu81kvPgn-7LsfbgqbA@mail.gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, Shijith Thotton <sthotton@marvell.com>, 
 Timothy McDaniel <timothy.mcdaniel@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>, 
 Nipun Gupta <nipun.gupta@nxp.com>,
 =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>, 
 Liang Ma <liangma@liangbit.com>, Peter Mccarthy <peter.mccarthy@intel.com>, 
 Harry van Haaren <harry.van.haaren@intel.com>, 
 Abhinandan Gujjar <abhinandan.gujjar@intel.com>, Ray Kinsella <mdr@ashroe.eu>, 
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, dpdk-dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [RFC 01/15] eventdev: make driver interface as
 internal
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Aug 24, 2021 at 1:10 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Mark all the driver specific functions as internal, remove
> `rte` prefix from `struct rte_eventdev_ops`.
> Remove experimental tag from internal functions.
> Remove `eventdev_pmd.h` from non-internal header files.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>


Seems like ethdev side there is conscious with
https://patches.dpdk.org/project/dpdk/list/?series=19084
Could you respin the version similar to
https://patches.dpdk.org/project/dpdk/list/?series=19084 or the next
version v3 from Konstantin.
Since eventdev does not have a callback, largely this series aligns
with expected output. But please align function and structure name
etc with ethdev for next series. Marking as "Changes Requested".
Thanks for the rework.