From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B013FA00C3; Wed, 15 Dec 2021 13:31:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37C2340688; Wed, 15 Dec 2021 13:31:52 +0100 (CET) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mails.dpdk.org (Postfix) with ESMTP id 770D940041 for ; Wed, 15 Dec 2021 13:31:50 +0100 (CET) Received: by mail-io1-f45.google.com with SMTP id z18so29799651iof.5 for ; Wed, 15 Dec 2021 04:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mZOxduwk3r2vNQRF/ix1+uZxOYnTnck8ok5Mcb3Y9sQ=; b=B24/Ng6ev+JxUqCUL77jwSs3xlWyyh4Rm+ZmnBaGljqHsjbIlAjehknuH61gppZLSO Y49dr2Qg5o2uzXekoMFayNVuaRF4/eemVF7TF999Q35GpBx7xEW4+wwOFQbGuUzsZZ7C CgSidPwiTv6XDpzzADk0MJZP/pF0GHYLlev0JCpo8l2eipTF8dvWlKP7qiEmDvxQl1ke rjn+8rQKRybnGEY7YDallGNK7Z7U67xDMx9MkPvxNYN6e9fYBN0+AmhWQQmNMTR/vmTt ub5h5NNPVIEmmotNimFXSMok5QMH8JCUjPCfcLsVdytiB96G+ULnbyjOZ1hMO4bx79mE j0uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mZOxduwk3r2vNQRF/ix1+uZxOYnTnck8ok5Mcb3Y9sQ=; b=D0jD6+sFZx0wmX7zICvIUHx//f4y/ucSVlJo1TXubKJZW+dNc6Ua9GAL01rwRrMntd gMhWNFI+y353hbGS6W+NgtqixNbZ97mL/zBIunzQXgLBElIb0vYSuV1Frv4nvkjoUgCd D90fJ4EnJMVE/Slg3oQAUvZOjX9ygPSzd/EaaqGo0VB3csLO6Igq2u8zAm0JYFpYBUwr zQtCa+MNOcEwy2tDVE5yoTQYl5G7xbrEkz4Qhn2QFcctaWDB6Ta66C3UgBIboZx8TzX+ xaEgqjmFkvbdjKBFBNr+dH/qvwW2oc8KEj6bxtO2FV7ZVbvWDHUrh1PsHoY5sNH4DcFW rqjg== X-Gm-Message-State: AOAM531AoKfcm4bz9OjkYFRXS0cHyZ9nlU56pJe//xEGaGvmYIi82bW1 rNPYzGGjGnvHvSJSuijVYgSUodmNwtfO3dAUL0k= X-Google-Smtp-Source: ABdhPJwHqoWXPmFoXG/clvkE0tlGRnxq6nmG2EWtUOl9XAvqJ0kaigNfwc8A02SSBLxLFM1Jqmm8OJ/BWp6DS9/n6Ig= X-Received: by 2002:a02:1901:: with SMTP id b1mr5673682jab.592.1639571509788; Wed, 15 Dec 2021 04:31:49 -0800 (PST) MIME-Version: 1.0 References: <20211214141242.3383831-1-ronan.randles@intel.com> In-Reply-To: <20211214141242.3383831-1-ronan.randles@intel.com> From: Jerin Jacob Date: Wed, 15 Dec 2021 18:01:23 +0530 Message-ID: Subject: Re: [PATCH 00/12] add packet generator library and example app To: Ronan Randles Cc: dpdk-dev , "Van Haaren, Harry" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 14, 2021 at 7:42 PM Ronan Randles wrote: > > This patchset introduces a Gen library for DPDK. This library provides an easy > way to generate traffic in order to test software based network components. > > This library enables the basic functionality required in the traffic generator. > This includes: raw data setting, packet Tx and Rx, creation and destruction of a > Gen instance and various types of data parsing. > This functionality is implemented in "lib/gen/rte_gen.c". IPv4 parsing > functionality is also added in "lib/net/rte_ip.c", this is then used in the gen > library. > > A sample app is included in "examples/generator" which shows the use of the gen > library in making a traffic generator. This can be used to generate traffic by > running the dpdk-generator generator executable. This sample app supports > runtime stats reporting (/gen/stats) and line rate limiting > (/gen/mpps,) through telemetry.py. > > > lib/gen/rte_gen.h | 114 +++++++ Please check Doxygen syntax across the file. rte_gen_create(), rte_gen_destroy(), rte_gen_packet_parse_string() etc missing proper doxygen synax.