DPDK patches and discussions
 help / color / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dpdk-dev <dev@dpdk.org>,
	junx.w.zhou@intel.com, maox.jiang@intel.com,
	 dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/eventdev_pipeline: fix 32-bit coremask logic
Date: Mon, 29 Jun 2020 22:09:32 +0530
Message-ID: <CALBAE1NNB4rBdux-68YVNGp02v_KWNHwU5xoENHics_o8U+B8g@mail.gmail.com> (raw)
In-Reply-To: <20200616165603.61456-1-harry.van.haaren@intel.com>

On Tue, Jun 16, 2020 at 10:24 PM Harry van Haaren
<harry.van.haaren@intel.com> wrote:
>
> This commit fixes a bug in 32-bit environments when a core mask greater
> than 32-bits is requested. The fix is to convert the bitmask logic to
> 64 bits, aligning 64 and 32 bit implementations.
>
> Fixes: adb5d548 ("examples/eventdev_pipeline_sw_pmd: add sample app")
> Cc: stable@dpdk.org
>
> Reported-by: Jun Zhou <junx.w.zhou@intel.com>
> Suggested-by: Mao Jiang <maox.jiang@intel.com>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied to dpdk-next-eventdev/master. Thanks.



> ---
>  examples/eventdev_pipeline/main.c            | 10 +++++-----
>  examples/eventdev_pipeline/pipeline_common.h |  8 ++++----
>  2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/examples/eventdev_pipeline/main.c b/examples/eventdev_pipeline/main.c
> index 21958269f..4ac582153 100644
> --- a/examples/eventdev_pipeline/main.c
> +++ b/examples/eventdev_pipeline/main.c
> @@ -81,7 +81,7 @@ parse_coremask(const char *coremask)
>                 val = xdigit2val(c);
>                 for (j = 0; j < BITS_HEX && idx < MAX_NUM_CORE; j++, idx++) {
>                         if ((1 << j) & val) {
> -                               mask |= (1UL << idx);
> +                               mask |= (1ULL << idx);
>                                 count++;
>                         }
>                 }
> @@ -232,10 +232,10 @@ parse_app_args(int argc, char **argv)
>                 usage();
>
>         for (i = 0; i < MAX_NUM_CORE; i++) {
> -               fdata->rx_core[i] = !!(rx_lcore_mask & (1UL << i));
> -               fdata->tx_core[i] = !!(tx_lcore_mask & (1UL << i));
> -               fdata->sched_core[i] = !!(sched_lcore_mask & (1UL << i));
> -               fdata->worker_core[i] = !!(worker_lcore_mask & (1UL << i));
> +               fdata->rx_core[i] = !!(rx_lcore_mask & (1ULL << i));
> +               fdata->tx_core[i] = !!(tx_lcore_mask & (1ULL << i));
> +               fdata->sched_core[i] = !!(sched_lcore_mask & (1ULL << i));
> +               fdata->worker_core[i] = !!(worker_lcore_mask & (1ULL << i));
>
>                 if (fdata->worker_core[i])
>                         cdata.num_workers++;
> diff --git a/examples/eventdev_pipeline/pipeline_common.h b/examples/eventdev_pipeline/pipeline_common.h
> index c7245f7f0..6a4287602 100644
> --- a/examples/eventdev_pipeline/pipeline_common.h
> +++ b/examples/eventdev_pipeline/pipeline_common.h
> @@ -51,10 +51,10 @@ struct fastpath_data {
>         bool rx_single;
>         bool tx_single;
>         bool sched_single;
> -       unsigned int rx_core[MAX_NUM_CORE];
> -       unsigned int tx_core[MAX_NUM_CORE];
> -       unsigned int sched_core[MAX_NUM_CORE];
> -       unsigned int worker_core[MAX_NUM_CORE];
> +       uint64_t rx_core[MAX_NUM_CORE];
> +       uint64_t tx_core[MAX_NUM_CORE];
> +       uint64_t sched_core[MAX_NUM_CORE];
> +       uint64_t worker_core[MAX_NUM_CORE];
>         struct setup_data cap;
>  } __rte_cache_aligned;
>
> --
> 2.17.1
>

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16 16:56 Harry van Haaren
2020-06-29 16:39 ` Jerin Jacob [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1NNB4rBdux-68YVNGp02v_KWNHwU5xoENHics_o8U+B8g@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=junx.w.zhou@intel.com \
    --cc=maox.jiang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox