From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C4A941C5D; Fri, 10 Feb 2023 09:08:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6933542BAC; Fri, 10 Feb 2023 09:08:30 +0100 (CET) Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by mails.dpdk.org (Postfix) with ESMTP id 2EF82410D0; Fri, 10 Feb 2023 09:08:29 +0100 (CET) Received: by mail-ua1-f46.google.com with SMTP id v5so383911uat.5; Fri, 10 Feb 2023 00:08:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FDqHcYmwapkGGsJuGcRQ1pHwRiCQSyVGqY7qNU6Rbks=; b=paTjEos7l3GUnwy3fxyRacmEffow51loYXeiHHYCJocYcMle9Ie27/HhyajuHplRZh PrPnExQzEqFbv+VAOQW0Ld8qZfG0hgizoBopN64dyfBigHkhIc+RT/Jk3KVoCzSDMAYP ZPzVcSduLRh8GhUO+9VBYqMYnfIz4PKyMcd4Q/mtiWOVmn1fIlC0xQqI8xQSqXxAxaUg 0rqBmmJVQB3+JRJ+V7JRTrKRplguJ1Kf8n1g7LgZS0Fl3lud8bCcIQEK6y97eoJ7lGYr qgLPkidmh6VGN6r59csBKO7iMEVgZek7Om/cH62tZQm19rtuzKpiqECNUCcziVe0gztG IrjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FDqHcYmwapkGGsJuGcRQ1pHwRiCQSyVGqY7qNU6Rbks=; b=rRdj+dwMHGr5QDiCvhqM6gPtpCFlataHMYhZ0D5ZJ5yx8vwcRypLTFLE6l6Nlph0qu mwCzMA+8cmbAriilgPyanY6F/pPSQt1X1C/iE55xbHV4tDFYC8c4UwJ8hvd6GNXFWW9Y bsKyDDN19vnryC2v+Cf9mhakq1vhNXIJv/z/lDss0bhygfUYWrhiKQkx/mOlL0FSbzbD RpYvjANU5h8yJm81t/fhkUmR4wrIqsGJjJbpUCYPUYWRRn8bVJF30lH5KxkujWD/KCBj 116wOOuBWSEmPJ8icxglYxw6yIXJVX21jU/af+mhzSshjpyXHKbkV0+Eb8coXR1VBUxi w5uw== X-Gm-Message-State: AO0yUKUhB6pxsoZjIkqFVMtAfgiCvD7Tkwy37uWt3CCBFrf6jfJi/y+d tgvbx+46gwAtgL0DUXUkA6h1y2eSBZZdFMgpX/us/Uw2/f8= X-Google-Smtp-Source: AK7set+BJ4/wTIbWq3rgcjFzSuJUhWfIxmrsetpIAtyeJFyyPlSSRRBh8cJBY4lVQZoNo6S+8gXTmtfasHVAAD087d8= X-Received: by 2002:ab0:73c8:0:b0:683:9609:1551 with SMTP id m8-20020ab073c8000000b0068396091551mr3124252uaq.42.1676016508536; Fri, 10 Feb 2023 00:08:28 -0800 (PST) MIME-Version: 1.0 References: <20230210042121.3013558-1-psatheesh@marvell.com> In-Reply-To: <20230210042121.3013558-1-psatheesh@marvell.com> From: Jerin Jacob Date: Fri, 10 Feb 2023 13:38:02 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces To: psatheesh@marvell.com Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 10, 2023 at 9:51 AM wrote: > > From: Satheesh Paul > > Fix channel mask of SDP interfaces on CN10K. > > Fixes: f137566333 ("common/cnxk: support setting channel mask for SDP interfaces") > Cc: stable@dpdk.org > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar K Please run ./devtools/check-git-log.sh -n 3 and ./devtools/checkpatches.sh -n 3 before pushing the patches to fix below issues. WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("")' - ie: 'Fixes: f13756633330 ("common/cnxk: support setting channel mask for SDP interfaces")' #8: Fixes: f137566333 ("common/cnxk: support setting channel mask for SDP interfaces") total: 0 errors, 1 warnings, 24 lines checked ### [PATCH] common/cnxk: fix printing IPsec flow rules WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 1aa86a170e27 ("drivers: support IPsec rule reservation scheme")' #8: Fixes: 1aa86a170e ("drivers: support IPsec rule reservation scheme") total: 0 errors, 1 warnings, 224 lines checked ### [PATCH] common/cnxk: fix inline IPsec rule creation WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 1aa86a170e27 ("drivers: support IPsec rule reservation scheme")' > --- > drivers/common/cnxk/roc_npc.c | 9 +++++++-- > drivers/common/cnxk/roc_npc_priv.h | 3 +++ > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c > index c872548230..9edccb5258 100644 > --- a/drivers/common/cnxk/roc_npc.c > +++ b/drivers/common/cnxk/roc_npc.c > @@ -1380,8 +1380,13 @@ roc_npc_flow_create(struct roc_npc *roc_npc, const struct roc_npc_attr *attr, > /* By default set the channel and mask to cover > * the whole SDP channel range. > */ > - npc->sdp_channel = (uint16_t)NIX_CHAN_SDP_CH_START; > - npc->sdp_channel_mask = (uint16_t)NIX_CHAN_SDP_CH_START; > + if (roc_model_is_cn10k()) { > + npc->sdp_channel = (uint16_t)CN10K_SDP_CH_START; > + npc->sdp_channel_mask = (uint16_t)CN10K_SDP_CH_MASK; > + } else { > + npc->sdp_channel = (uint16_t)NIX_CHAN_SDP_CH_START; > + npc->sdp_channel_mask = (uint16_t)NIX_CHAN_SDP_CH_START; > + } > } > } > > diff --git a/drivers/common/cnxk/roc_npc_priv.h b/drivers/common/cnxk/roc_npc_priv.h > index 2a7d3137fb..aa27228354 100644 > --- a/drivers/common/cnxk/roc_npc_priv.h > +++ b/drivers/common/cnxk/roc_npc_priv.h > @@ -77,6 +77,9 @@ > #define NPC_LFLAG_LC_OFFSET (NPC_LTYPE_OFFSET_START + 6) > #define NPC_LTYPE_LC_OFFSET (NPC_LTYPE_OFFSET_START + 8) > > +#define CN10K_SDP_CH_START 0x80 > +#define CN10K_SDP_CH_MASK 0xF80 > + > struct npc_action_vtag_info { > uint16_t vlan_id; > uint16_t vlan_ethtype; > -- > 2.35.3 >