From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33A7CA0C45; Tue, 21 Sep 2021 18:25:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B4F24114F; Tue, 21 Sep 2021 18:25:19 +0200 (CEST) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by mails.dpdk.org (Postfix) with ESMTP id 9A9F740DF8 for ; Tue, 21 Sep 2021 18:25:18 +0200 (CEST) Received: by mail-io1-f48.google.com with SMTP id n71so8595965iod.0 for ; Tue, 21 Sep 2021 09:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bIrUDEHb1RD8qbK5RKo3M327uvBvlqzfYG66LKpefzI=; b=TpZKBbD7CuQnlH+yMGwKXlqNksHuiQMjXP+nvdsSqZvJLBBo20A/wV6csdDPhgAPH8 LSSWneuDO+DIwD5KwGQQig4P0AMhcUGiQ5y30ukEj+RHgq1GUzyv2QRNLB9Vr78+YxsL 7UltKJAIWfZ4f7bZKpjvao+OGU5uV3Ihi5BQkhOf92/RgOVi6uuRI9ZoExFIxxcVmO8p Ww7AIDTdcpQfuhIQ3dzYVHVWyO5tbV8TVq8ls/gfLVAKrpzdKVsqtZuG6G/zHKU5L8vu auZdrFOS2QzrZ4KanIy3Jznv8wJb49pcxuzbnii5R9zm//vw7dDWAYGFjOjDuHDMTU79 W5BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bIrUDEHb1RD8qbK5RKo3M327uvBvlqzfYG66LKpefzI=; b=coFk0IfoYuhvco46YNM6+eKi1sN/85fOb3HzekXBJOlJ4Iq+NBAOystL7Wt8usXsCT L9103P+wXJhmqfCwoel5M2LJ0WuD9yiWs1p8Ul1Ey1ggoMQg5Bg/bXEZFw53YHVKKj/B DlNkRxPGSr5jy32OupqFXG1DAelsIJ0O95SYC0Q2P6XB/Cv9lzyx6b2RfX8W3/EGCYpw qYkg49aaS/OjR9IfAx1Nvg44NsH2l8BtvuW9oCBJNInT937UzaW+yHaCY5AQqApj3Had zuNfaqclo0Pjt+GTX1UuhAzRC/A9sQNd44ZDPTGssI1aanQobejAQ44Fo/lTv9YDMEU5 jwbw== X-Gm-Message-State: AOAM5330tih8sSW6NIJ3Wt7w/b+xsIBxBC04RJIgBp4NN+cOLqbX0b6p AhUFXoClInukAOKYvAiC7okt2f/MiECIQAsgqqI= X-Google-Smtp-Source: ABdhPJxclyISXKRsS+ItvivmukV+4s3HdRd9qIorN8SCV8d4YOcHUR0wCQzICURXxAP/idl0NTU3q8BsDmeDm9KxGu0= X-Received: by 2002:a5d:88d7:: with SMTP id i23mr707955iol.38.1632241517858; Tue, 21 Sep 2021 09:25:17 -0700 (PDT) MIME-Version: 1.0 References: <20210918131140.3543317-1-s.v.naga.harish.k@intel.com> <20210921092146.1778421-1-s.v.naga.harish.k@intel.com> <20210921092146.1778421-3-s.v.naga.harish.k@intel.com> In-Reply-To: <20210921092146.1778421-3-s.v.naga.harish.k@intel.com> From: Jerin Jacob Date: Tue, 21 Sep 2021 21:54:50 +0530 Message-ID: To: Naga Harish K S V Cc: Jerin Jacob , "Jayatheerthan, Jay" , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per queue event buffer configure support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 21, 2021 at 2:52 PM Naga Harish K S V wrote: > > To configure per queue event buffer size, applications sets > ``rte_event_eth_rx_adapter_params::use_queue_event_buf`` flag > as true and is passed to ``rte_event_eth_rx_adapter_create_with_params`` > api. > > The per queue event buffer size is populated in > ``rte_event_eth_rx_adapter_queue_conf::event_buf_size`` and passed > to ``rte_event_eth_rx_adapter_queue_add`` api. > > Signed-off-by: Naga Harish K S V Fix check-git-log issues Wrong headline format: eventdev/rx_adapter:add per queue event buffer configure support Wrong headline case: "test/event: add unit test for event buffer size config api": api --> API Wrong headline case: "test/eventdev: add per rx queue event buffer unit": rx --> Rx Headline too long: eventdev/rx_adapter: add support to configure event buffer size eventdev/rx_adapter:add per queue event buffer configure support Invalid patch(es) found - checked 5 patches > --- > .../prog_guide/event_ethernet_rx_adapter.rst | 19 ++++++++++++------- > lib/eventdev/rte_event_eth_rx_adapter.h | 4 ++++ > 2 files changed, 16 insertions(+), 7 deletions(-) > > diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > index dd753613bd..333e6f8192 100644 > --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > @@ -62,12 +62,14 @@ service function and needs to create an event port for it. The callback is > expected to fill the ``struct rte_event_eth_rx_adapter_conf structure`` > passed to it. > > -If the application desires to control the event buffer size, it can use the > -``rte_event_eth_rx_adapter_create_with_params()`` api. The event buffer size is > -specified using ``struct rte_event_eth_rx_adapter_params::event_buf_size``. > -The function is passed the event device to be associated with the adapter > -and port configuration for the adapter to setup an event port if the > -adapter needs to use a service function. > +If the application desires to control the event buffer size at adapter level, > +it can use the ``rte_event_eth_rx_adapter_create_with_params()`` api. The event > +buffer size is specified using ``struct rte_event_eth_rx_adapter_params:: > +event_buf_size``. To configure the event buffer size at queue level, the boolean > +flag ``struct rte_event_eth_rx_adapter_params::use_queue_event_buf`` need to be > +set to true. The function is passed the event device to be associated with > +the adapter and port configuration for the adapter to setup an event port > +if the adapter needs to use a service function. > > Adding Rx Queues to the Adapter Instance > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > @@ -79,7 +81,9 @@ parameter. Event information for packets from this Rx queue is encoded in the > ``ev`` field of ``struct rte_event_eth_rx_adapter_queue_conf``. The > servicing_weight member of the struct rte_event_eth_rx_adapter_queue_conf > is the relative polling frequency of the Rx queue and is applicable when the > -adapter uses a service core function. > +adapter uses a service core function. The applications can configure queue > +event buffer size in ``struct rte_event_eth_rx_adapter_queue_conf::event_buf_size`` > +parameter. > > .. code-block:: c > > @@ -90,6 +94,7 @@ adapter uses a service core function. > queue_config.rx_queue_flags = 0; > queue_config.ev = ev; > queue_config.servicing_weight = 1; > + queue_config.event_buf_size = 1024; > > err = rte_event_eth_rx_adapter_queue_add(id, > eth_dev_id, > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h > index a7881097b4..b9f0563244 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.h > +++ b/lib/eventdev/rte_event_eth_rx_adapter.h > @@ -199,6 +199,8 @@ struct rte_event_eth_rx_adapter_queue_conf { > * Valid when RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR flag is set in > * @see rte_event_eth_rx_adapter_queue_conf::rx_queue_flags. > */ > + uint16_t event_buf_size; > + /**< event buffer size for this queue */ > }; > > /** > @@ -265,6 +267,8 @@ struct rte_event_eth_rx_adapter_params { > /**< size of event buffer for the adapter. > * the size is aligned to BATCH_SIZE and added (2 * BATCH_SIZE) > */ > + bool use_queue_event_buf; > + /**< flag to indicate that event buffer is separate for each queue */ > }; > > /** > -- > 2.25.1 >