From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74535A0577; Mon, 6 Apr 2020 07:48:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 818722B96; Mon, 6 Apr 2020 07:48:54 +0200 (CEST) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 54F2A2B86 for ; Mon, 6 Apr 2020 07:48:53 +0200 (CEST) Received: by mail-il1-f195.google.com with SMTP id 7so13532104ill.2 for ; Sun, 05 Apr 2020 22:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G+TWHtq3uqv0Y1eRivWK6vDnq2Y3nfKYqh2BGt0cWlE=; b=XGHiNzFeG2gADXbU49lmCebr7roH/673HtWXHIYs8WtcWXQ9q3iT2KeTXgMU5zWGaS no2USE3Kqqf8GBC/fERVOHE1Mb2n4sb7jjb4OKe8sgzIh2jAPP7pZQOrhnx7fAEgKjss nJm00tzHThGdda788KW8jmPEZM8CqfWIH1VpR6JBadQ9CoRhCr6PF1lxANSf990KF+gB 1TCGR3s7tsofK0Wvyf2pj4Q2Sk5pDaNZpuF88zKStq5wBtKTPliB40uFVyMHKUF+FZMn EmfJQ8c3fgJElHwlh84TbG/gFBWUTKDbfGqMc3YW6y+IPedS86Mts1TFvn58m9r5hCFx f6ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G+TWHtq3uqv0Y1eRivWK6vDnq2Y3nfKYqh2BGt0cWlE=; b=D9fhxHiuaupF190wwaBCi0TwwFEx8ThS3N4LPabsW81FO3MvjuJR/IYa1tdWzwlpy6 dw95Nm7kRYcn49aJGhhzRkFp/MafViz3fBNFs6DJ8dh74BPKVEspw0bffG468jdaEFAs RjLtmSrqrHLsASB4FlQ2btiw9Gh2k461tHYcvTnGvkn6hUABFfC+M30LoM9JTfkI7s3u jlCe0XduibtHoxMk4czNqHKWK7TKrzMikAc4HMKh1rWnXcFpGoA4sISgq2aErmvA6ytb 0+7lPA0xTv9ySk0uXvfxtF3w0mWQcOgt7lcHHifKUEA48yxzM5r5v3BWIjYKHLucOM7/ Zc9Q== X-Gm-Message-State: AGi0PubTxRnnNlHqCMq8NyONIvssIOBWfd/z7wgzioO2+Iv8qC2crHjg XUR2TGFH6gFTV7wOovb1iUXy1zCB7lVs/9/sSlU= X-Google-Smtp-Source: APiQypK+9vPw1pi0AQ31CFDxR/w2e0U/NVKfaoagRyCiedFYG2BI4l7Z9WXFQtTmXgX2Z8PdFkTa+Gy88hHuSt7EqJk= X-Received: by 2002:a05:6e02:90:: with SMTP id l16mr20429653ilm.294.1586152132461; Sun, 05 Apr 2020 22:48:52 -0700 (PDT) MIME-Version: 1.0 References: <20200312111907.31555-1-ndabilpuram@marvell.com> <20200403085216.32684-1-nithind1988@gmail.com> <20200403085216.32684-12-nithind1988@gmail.com> In-Reply-To: <20200403085216.32684-12-nithind1988@gmail.com> From: Jerin Jacob Date: Mon, 6 Apr 2020 11:18:36 +0530 Message-ID: To: Nithin Dabilpuram Cc: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , John McNamara , Marko Kovacevic , dpdk-dev , Krzysztof Kanas Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 11/11] net/octeontx2: add tm capability callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 3, 2020 at 2:24 PM Nithin Dabilpuram wrote: > > From: Krzysztof Kanas > > Add Traffic Management capability callbacks to provide > global, level and node capabilities. This patch also > adds documentation on Traffic Management Support. > > Signed-off-by: Nithin Dabilpuram > Signed-off-by: Krzysztof Kanas After fixing the below issues(inlined) Series applied to dpdk-next-net-mrvl/master. Thanks. > --- > > diff --git a/doc/guides/nics/features/octeontx2.ini b/doc/guides/nics/features/octeontx2.ini > index 473fe56..fb13517 100644 > --- a/doc/guides/nics/features/octeontx2.ini > +++ b/doc/guides/nics/features/octeontx2.ini > @@ -31,6 +31,7 @@ Inline protocol = Y > VLAN filter = Y > Flow control = Y > Flow API = Y > +Rate limitation = Y Definition this "Rate limitation" and TM rate limitation functionally the same. But the interface is different. Following is the interface for the above "Rate limitation" feature. So, Above "Y" is not applicable. Rate limitation --------------- Supports Tx rate limitation for a queue. * **[implements] eth_dev_ops**: ``set_queue_rate_limit``. * **[related] API**: ``rte_eth_set_queue_rate_limit()`` > Jumbo frame = Y > Scattered Rx = Y > VLAN offload = Y > diff --git a/doc/guides/nics/octeontx2.rst b/doc/guides/nics/octeontx2.rst > index 60187ec..6b885d6 100644 > --- a/doc/guides/nics/octeontx2.rst > +++ b/doc/guides/nics/octeontx2.rst > @@ -39,6 +39,7 @@ Features of the OCTEON TX2 Ethdev PMD are: > - HW offloaded `ethdev Rx queue` to `eventdev event queue` packet injection > - Support Rx interrupt > - Inline IPsec processing support > +- :ref:`Traffic Management API ` tmapi ref is pointing to mvpp2 driver index. > > Prerequisites > ------------- > @@ -213,6 +214,20 @@ Runtime Config Options > parameters to all the PCIe devices if application requires to configure on > all the ethdev ports. > > +Traffic Management API > +---------------------- > + > +OCTEON TX2 PMD supports generic DPDK Traffic Management API which allows to > +configure the following features: > + > +1. Hierarchical scheduling > +2. Single rate - two color, Two rate - three color shaping Use #. to auto enumerate. > + > +Both DWRR and Static Priority(SP) hierarchial scheduling is supported. > +Every parent can have atmost 10 SP Children and unlimited DWRR children. > +Both PF & VF supports traffic management API with PF supporting 6 levels > +and VF supporting 5 levels of topology. > + > Limitations > ----------- > > diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst > index 000bbf5..47a9825 100644 > --- a/doc/guides/rel_notes/release_20_05.rst > +++ b/doc/guides/rel_notes/release_20_05.rst > @@ -62,6 +62,14 @@ New Features > > * Added support for matching on IPv4 Time To Live and IPv6 Hop Limit. > > +* **Updated Marvell OCTEON TX2 ethdev driver.** > + > + Updated Marvell OCTEON TX2 ethdev driver with traffic manager support with > + below features. > + > + * Hierarchial Scheduling with DWRR and SP. > + * Single rate - two color, Two rate - three color shaping. Alignment is not correct wrt to other items.