From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DE5942D0E; Wed, 21 Jun 2023 07:01:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E817540DFB; Wed, 21 Jun 2023 07:01:17 +0200 (CEST) Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by mails.dpdk.org (Postfix) with ESMTP id 945C740DDC for ; Wed, 21 Jun 2023 07:01:16 +0200 (CEST) Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-471740b7e00so1609408e0c.1 for ; Tue, 20 Jun 2023 22:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687323676; x=1689915676; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=j2rFSBV+Wi4MUj1pgjwV286BDYzxsbcCmmPUAE81X1w=; b=hAKWsKTnlH2MEEjH02B7YzZcAPcDOVEPm6WWOjdpeKPJHQ0zAE9v26j6fdvvy2rjrf AdP9/Lonv3tTETifneSKhmw1d+L22J38uVFE3flMYlMycxMsNHi2B+ePj+na7IOZbXQR 5DMl+ebFxDnxPq+4OQuTN5+wEmwtSyztT77VfgZaSk/BW1CILXLk5m4RTg3RA9Ucog+h wdSFBzDK/HcfIB9yTOKSAiFXXpJfRs6g5XSSPWNiYHK5zvtlinpIMI0LsEwq0EklUE8j V525WBkS6NtVBPxjHpErP+bO8ZJm4k4Fk4gUCB5YzEmdhxvFglJ9NOfLiX1zhMjREity NplA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687323676; x=1689915676; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j2rFSBV+Wi4MUj1pgjwV286BDYzxsbcCmmPUAE81X1w=; b=jchweviyVCb22wgdfEtRi1TCKzAWhYMMWSvvSo5eqGuaYCRcHpqRFFcsFSu//43Y69 O79ECSrAk8rkumMoZfLbehAxvyo7BmQ00aYAwye+9dK9fFdfaoT5ilKXZKGw+McjNPtb cGPlkoTBonwHZflryrpY84NRPBE6lYYAsmNEtVGDRoKS/QyfeMgGl+UVjpH9T/KNB2m3 bn/nsFlMBbQcA9yhjd9dLwLQeNo23eOHdzVL8a22rg7noiQYn9+ui3FtYuSfgLv+4Oq/ 6VOO6UM2tkHwNZ3CYJCpI/I6vgLxSFOR/fa2nu8m0JLhd8NiL6MV2Mmp9JY5KWg4SJSO +oVA== X-Gm-Message-State: AC+VfDxVgtoJzmOmimX7vnJFSzVNl0PLlsdUXdXauTmv0+7LghFzed2s A785/SBRQ3bcmEj1EPP86bmcefZ/UqGTa+EAfy6UhwM2gfn/rdnc X-Google-Smtp-Source: ACHHUZ6mgDXzLBjx9vH8mDo+PTspflMZjnoAoiIL+HoM583fDS/K5cayd5AIT/OZHMPl2IkzsW7UFN48ZXORxO/G6DU= X-Received: by 2002:a1f:c843:0:b0:463:12f:d38e with SMTP id y64-20020a1fc843000000b00463012fd38emr5998253vkf.1.1687323675781; Tue, 20 Jun 2023 22:01:15 -0700 (PDT) MIME-Version: 1.0 References: <20230620093950.3127383-1-thierry.herbelot@6wind.com> <20230620094337.3127595-1-thierry.herbelot@6wind.com> In-Reply-To: From: Jerin Jacob Date: Wed, 21 Jun 2023 10:30:49 +0530 Message-ID: Subject: Re: [EXT] [PATCH v3] common/cnxk/roc_npa: unlock mbox in error cases To: Ashwin Sekhar T K Cc: Thierry Herbelot , "dev@dpdk.org" , Thomas Monjalon , Nithin Kumar Dabilpuram , Satha Koteswara Rao Kottidi , Jerin Jacob Kollanukkaran Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 21, 2023 at 10:17=E2=80=AFAM Ashwin Sekhar T K wrote: > > Acked-by: Ashwin Sekhar T K > > > -----Original Message----- > > From: Thierry Herbelot > > Sent: Tuesday, June 20, 2023 3:14 PM > > To: dev@dpdk.org > > Cc: Thierry Herbelot ; Thomas Monjalon > > ; Nithin Kumar Dabilpuram > > ; Satha Koteswara Rao Kottidi > > ; Jerin Jacob Kollanukkaran > > > > Subject: [EXT] [PATCH v3] common/cnxk/roc_npa: unlock mbox in error > > cases > > > > External Email > > > > ---------------------------------------------------------------------- > > In npa_aura_pool_fini and in npa_aura_fini, Unlock mbox when an error i= s > > detected. > > > > Fixes: ea4d70cc4f0b46d5 ('common/cnxk: add NPA aura create/destroy ROC > > APIs') > > Signed-off-by: Thierry Herbelot Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: fix mbox unlocking in error cases Fix mbox unlock issues in npa_aura_pool_fini() and in npa_aura_fini(), when an error is detected. Fixes: ea4d70cc4f0b ("common/cnxk: add NPA aura create/destroy ROC API"= ) Cc: stable@dpdk.org Signed-off-by: Thierry Herbelot Acked-by: Ashwin Sekhar T K > > -- > > V2: also patch npa_aura_pool_fini > > V3: add missing space > > --- > > drivers/common/cnxk/roc_npa.c | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/common/cnxk/roc_npa.c > > b/drivers/common/cnxk/roc_npa.c index 377439c2baaf..3b9a70028ba2 > > 100644 > > --- a/drivers/common/cnxk/roc_npa.c > > +++ b/drivers/common/cnxk/roc_npa.c > > @@ -197,8 +197,10 @@ npa_aura_pool_fini(struct mbox *m_box, uint32_t > > aura_id, uint64_t aura_handle) > > off =3D mbox->rx_start + pool_rsp->hdr.next_msgoff; > > aura_rsp =3D (struct npa_aq_enq_rsp *)((uintptr_t)mdev->mbase + > > off); > > > > - if (aura_rsp->hdr.rc !=3D 0 || pool_rsp->hdr.rc !=3D 0) > > - return NPA_ERR_AURA_POOL_FINI; > > + if (aura_rsp->hdr.rc !=3D 0 || pool_rsp->hdr.rc !=3D 0) { > > + rc =3D NPA_ERR_AURA_POOL_FINI; > > + goto exit; > > + } > > > > /* Sync NDC-NPA for LF */ > > ndc_req =3D mbox_alloc_msg_ndc_sync_op(mbox); @@ -245,8 > > +247,10 @@ npa_aura_fini(struct mbox *m_box, uint32_t aura_id) > > if (rc < 0) > > goto exit; > > > > - if (aura_rsp->hdr.rc !=3D 0) > > - return NPA_ERR_AURA_POOL_FINI; > > + if (aura_rsp->hdr.rc !=3D 0) { > > + rc =3D NPA_ERR_AURA_POOL_FINI; > > + goto exit; > > + } > > > > /* Sync NDC-NPA for LF */ > > ndc_req =3D mbox_alloc_msg_ndc_sync_op(mbox); > > -- > > 2.39.2 >