From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 173B1A2EFC for ; Mon, 14 Oct 2019 18:17:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F3881C1BB; Mon, 14 Oct 2019 18:17:04 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id C3D741C192 for ; Mon, 14 Oct 2019 18:17:02 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id n26so39055189ioj.8 for ; Mon, 14 Oct 2019 09:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sI2ocOXxzm+VsWZQdBJaKMG0aJszWQJ6/pUxyAgzVoM=; b=W3NFUr6vM+NUwWV8v0IaPp+Y65K6PtQAwwxD+17dTT8wlYTKdKKYm50x4Vdbdw6V1p Yc560HW5w891xJ214u6ArqZkF8Xas/Tf5eDjkRzugGTzVC07DTmsIgmKlsl1icj/c/RK z1xuBjR1j13dLA0uMlaZK4gMDB3x0menbcB26/S8NLQZLI7qMZGMiEGxxOFU7Z5pj4Jq fwi3+kjShPasLzZLrJRggirEwMkbAdVNnPhovrPSCiBLq2MShnPmXZ+YWD2zpZokxrvX KKk+S6cPlEEhCY7nh6tUopT9l53a5hyDvyPxxlhwcpQTtBg4pBhRMyMuEGTGKQIpUpRp hSSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sI2ocOXxzm+VsWZQdBJaKMG0aJszWQJ6/pUxyAgzVoM=; b=VU4tJOf1o7wefEiDTcDDmW5l7gif40J1UbtWbjQ8Z/m3NOKjmqtzPzVTcI6bPePkjz jSYgImggeGporYWquzTW9vrwa+WB5XW/lpo2ZgtmJbgX8+w1gC2GExhk3wWpfA09lJDi igEJe7cBLPRMNCn1LMUrxABZpBRpATBbsWzlsQn89OEtrdzPU7NPQrmAmL0oLZdekrk5 IvWKZQID2v0gL6cTvkiFFUwgLMg6zyOFoMvKcOH8QMaoD8YZGegc4/1PBKbr83gnSO+G qedsJVUjKHZ8KYo+aiSNDIbvbax5Uh8xO4AWMBSKvmBpPy6dmZezJqAr48CBv3RMKWbE SJLw== X-Gm-Message-State: APjAAAVIti/GETgTnYoKrGZJPBmczjU2hQJrwnosHFNVsCzkutQEn5vR EMaqlHjoconKC5bZ+PDaBMdAuwl66R1P3gEnmGo= X-Google-Smtp-Source: APXvYqzAbpaOmmDUGRVRwnCg2oviNePIOEjfo9zBe7JKmTYkmoWRNHECYdcnoZyJGZ9MCzj4mpmLEl6EAhvau/BtKOg= X-Received: by 2002:a6b:740b:: with SMTP id s11mr38818492iog.294.1571069821813; Mon, 14 Oct 2019 09:17:01 -0700 (PDT) MIME-Version: 1.0 References: <20191014113448.7442-1-bruce.richardson@intel.com> <20191014113448.7442-5-bruce.richardson@intel.com> In-Reply-To: <20191014113448.7442-5-bruce.richardson@intel.com> From: Jerin Jacob Date: Mon, 14 Oct 2019 21:46:50 +0530 Message-ID: To: Bruce Richardson Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 4/8] examples/performance-thread: rename directory to standard X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 14, 2019 at 5:05 PM Bruce Richardson wrote: > > In other places in DPDK, e.g. EAL, the architecture-specific files for arm > are just stored in a folder called "arm". Rename the "arm64" folder for > performance thread example to align to this naming. > > Signed-off-by: Bruce Richardson > --- > examples/performance-thread/common/arch/{arm64 => arm}/ctx.c | 0 > examples/performance-thread/common/arch/{arm64 => arm}/ctx.h | 0 > examples/performance-thread/common/arch/{arm64 => arm}/stack.h | 0 > examples/performance-thread/common/common.mk | 2 +- > 4 files changed, 1 insertion(+), 1 deletion(-) > rename examples/performance-thread/common/arch/{arm64 => arm}/ctx.c (100%) This code only works for arm64 as it is storing and restoring arm64 registers. armv7 registers are different so this code does not work for the generic arm. arm64 specific code, we always named as arm64 F: lib/librte_hash/rte*_arm64.h F: lib/librte_efd/rte*_arm64.h F: lib/librte_table/rte*_arm64.h IMO, If armv7 support adds in future then we can change the directory as arch/arm and have ctx_64.c and ctx_32.c etc. I think, for now, technically it is correct to call the directory as arm64