From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB939423FA; Tue, 17 Jan 2023 09:52:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D95040151; Tue, 17 Jan 2023 09:52:43 +0100 (CET) Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by mails.dpdk.org (Postfix) with ESMTP id 59BD2400D4 for ; Tue, 17 Jan 2023 09:52:42 +0100 (CET) Received: by mail-vs1-f50.google.com with SMTP id q125so19742117vsb.0 for ; Tue, 17 Jan 2023 00:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=22kVF9d6NjRytw+N7bYgjxaW/gd5JdRCCeSYVx89G7w=; b=Usr23CaM6Bn2ALEvinmTXXD9AHcErj74AWib06MWSbYxhBaiWfG3EM17aw8zZXlQy6 Aqgg7wM708flsFwypsUVVdTFoKHCw4Xv61Tup/H4y75yNabpgPI3o4+9so5XTAcjsmuv jAxB3hc9gq17ek4BIAS6C9NMNcM9viLRcAVdcLLII1LY0tBRdlpOE3jA+YJk32hUey6C J+AkcJKE5HUg9HFezbYtvnRjcrssdI7CnFTSAJuvMEESQUyxgqbXWR4N7cHJ0QD0hPHe RkbGqvWse2+/dnPVRCmTEWYayXI5RCILO9PO8Ha8NPi30g9HqHu9MbPgGN9GFxWLjPhT nB6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=22kVF9d6NjRytw+N7bYgjxaW/gd5JdRCCeSYVx89G7w=; b=wU3WdNWwn+UDc3frXbLLTRRJvbnr6nLn0drBWWzHfCDlEmr6y/2IpMoMoYYgGwY2Ou gfFihSQo1kDqyw6iAD08RDTzBG0Y2etVnmTHAmrswAdV9A6aJIFpRGkcywXumqKz+QyC w4a2FMcEr147NCsmRhpBfoLwLEAS1xd7bk/8EF1rj2MzFvU1Bh3P2jKIODfnyRNul4st gruMH6beGWpSySp9RySfDxVqzvnHusYv2/rBG4/by38fbGdkfsnxYNtrk2FI+nt1XT2p F1RcVanenB3x+C8pz/sq00GMzgbI5XblVcNhRkO5OgutmgA4EHWLigIf3dKbK38Hyww8 5wRA== X-Gm-Message-State: AFqh2ko+x18H04g0KQgDjQCdXn9h3hK+Ju2nsS7UWA/ozp9XwSZ7Tc4Y Ek5kG6Frt9sE+zw+11rAKetQicHNc7ka3wUWGiU= X-Google-Smtp-Source: AMrXdXuQ3kvhLDOyyWkNtNC0gr6ubIE/M2khs0IEwAypN7rZ5+COwIH4MYDAWx0lNgs7fCweQiYwzsLukYgHikDpHdw= X-Received: by 2002:a67:ea8f:0:b0:3d0:ee83:9599 with SMTP id f15-20020a67ea8f000000b003d0ee839599mr285945vso.45.1673945561476; Tue, 17 Jan 2023 00:52:41 -0800 (PST) MIME-Version: 1.0 References: <20221221091549.967801-1-rbhansali@marvell.com> <20221221091549.967801-2-rbhansali@marvell.com> In-Reply-To: <20221221091549.967801-2-rbhansali@marvell.com> From: Jerin Jacob Date: Tue, 17 Jan 2023 14:22:14 +0530 Message-ID: Subject: Re: [PATCH 2/4] net/cnxk: restructure for cn10k datapath To: Rahul Bhansali Cc: dev@dpdk.org, Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , jerinj@marvell.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 21, 2022 at 2:46 PM Rahul Bhansali wrote: > > Restructure for separate cn10k datapath functionality to reduce > recompilation time in case of any changes in control path. > > New cnxk_ethdev_dp.h and cn10k_rxtx.h files are created to have > macros, functions as required for datapath with minimal dependency > on roc changes. > > Signed-off-by: Rahul Bhansali > index 422d2e4e1c..94ffcb74a8 100644 > --- a/drivers/net/cnxk/tx/cn10k/tx_96_111_vec.c > +++ b/drivers/net/cnxk/tx/cn10k/tx_96_111_vec.c > @@ -2,9 +2,12 @@ > * Copyright(C) 2022 Marvell. > */ > > diff --git a/drivers/net/cnxk/tx/cn10k/tx_96_111_vec_mseg.c b/drivers/net/cnxk/tx/cn10k/tx_96_111_vec_mseg.c > index dbefae02e0..ad1d124968 100644 > --- a/drivers/net/cnxk/tx/cn10k/tx_96_111_vec_mseg.c > +++ b/drivers/net/cnxk/tx/cn10k/tx_96_111_vec_mseg.c > @@ -2,9 +2,12 @@ > * Copyright(C) 2022 Marvell. > */ > > -#include "cn10k_ethdev.h" > #include "cn10k_tx.h" > > +#ifdef _ROC_API_H_ > +#error "roc_api.h is included" > +#endif 1) There is build error[1], Please rebase to next-net-mrvl and fix the issue 2) Change 3/4 patch git comment subject to align with other patches 3)Is above 3 lines need to be added in everyfile, How about a)Include this on parent file . Say cn10k_rx.h ? b)Add a macro for this [1] FAILED: drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_rx_cn10k_rx_112_127_vec_mseg.c.o ccache gcc -Idrivers/libtmp_rte_net_cnxk.a.p -Idrivers -I../drivers -Idrivers/net/cnxk -I../drivers/net/cnxk -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/ eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/e t -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/cryptodev -I../lib/cryptodev -Ilib/rcu -I../lib/rcu -Ilib/eventdev -I../lib/eventdev -Ilib/hash -I../lib/hash -Ilib/timer -I../lib/timer -Ilib/security -I../lib/security -Idrivers/common/cnxk -I../drivers/common/cnxk -Idrivers/mempool /cnxk -I../drivers/mempool/cnxk -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -O2 -g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declaration s -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-zero-length -bounds -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -flax-vector-conversions -Wno-strict-aliasing -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.cnxk -MD -MQ drivers/libtmp_rte_net_cnxk.a.p/net_ cnxk_rx_cn10k_rx_112_127_vec_mseg.c.o -MF drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_rx_cn10k_rx_112_127_vec_mseg.c.o.d -o drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_rx_cn10k_rx_112_127_vec_mseg.c.o -c ../drivers/net/cnxk/rx/cn10k/rx_112_127_ve c_mseg.c ../drivers/net/cnxk/rx/cn10k/rx_112_127_vec_mseg.c:8:2: error: #error "roc_api.h is included" 8 | #error "roc_api.h is included" > + > #define T(name, sz, flags) \ > NIX_TX_XMIT_VEC_MSEG(cn10k_nix_xmit_pkts_vec_mseg_##name, sz, flags) > > -- > 2.25.1 >