From: Jerin Jacob <jerinjacobk@gmail.com>
To: Tomasz Duszynski <tduszynski@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dpdk-dev <dev@dpdk.org>, Jakub Palider <jpalider@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] raw/cnxk_bphy: fix device lookup
Date: Tue, 28 Sep 2021 18:50:22 +0530 [thread overview]
Message-ID: <CALBAE1NTVW6JuzPOqr3v3tsL-k=PUmgTxLmByxQG_V5RnE6fWw@mail.gmail.com> (raw)
In-Reply-To: <20210815231202.1192974-2-tduszynski@marvell.com>
On Mon, Aug 16, 2021 at 4:43 AM Tomasz Duszynski <tduszynski@marvell.com> wrote:
>
> Name needs to be prepared before the lookup otherwise
> PMD will not be released.
>
> Fixes: 24d9c5d59d5d ("raw/cnxk_bphy: add baseband PHY skeleton driver")
>
> Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
> Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Series applied to dpdk-next-net-mrvl/for-next-net. Thanks.
> ---
> drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c
> index 9cb3f8d332..8a0d2224c0 100644
> --- a/drivers/raw/cnxk_bphy/cnxk_bphy.c
> +++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c
> @@ -306,14 +306,13 @@ bphy_rawdev_remove(struct rte_pci_device *pci_dev)
> return -EINVAL;
> }
>
> + bphy_rawdev_get_name(name, pci_dev);
> rawdev = rte_rawdev_pmd_get_named_dev(name);
> if (rawdev == NULL) {
> plt_err("invalid device name (%s)", name);
> return -EINVAL;
> }
>
> - bphy_rawdev_get_name(name, pci_dev);
> -
> return rte_rawdev_pmd_release(rawdev);
> }
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-09-28 13:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-15 23:11 [dpdk-dev] [PATCH 0/3] support reading NPA/SSO PF function Tomasz Duszynski
2021-08-15 23:12 ` [dpdk-dev] [PATCH 1/3] raw/cnxk_bphy: fix device lookup Tomasz Duszynski
2021-09-28 13:20 ` Jerin Jacob [this message]
2021-08-15 23:12 ` [dpdk-dev] [PATCH 2/3] common/cnxk: support reading NPA/SSO PF function Tomasz Duszynski
2021-08-15 23:12 ` [dpdk-dev] [PATCH 3/3] raw/cnxk_bphy: " Tomasz Duszynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1NTVW6JuzPOqr3v3tsL-k=PUmgTxLmByxQG_V5RnE6fWw@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=jpalider@marvell.com \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).