From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69CDDA0548; Wed, 15 Jun 2022 19:10:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AF28427EB; Wed, 15 Jun 2022 19:10:47 +0200 (CEST) Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by mails.dpdk.org (Postfix) with ESMTP id 8C5E6410D0 for ; Wed, 15 Jun 2022 19:10:45 +0200 (CEST) Received: by mail-qv1-f44.google.com with SMTP id t6so7932712qvh.1 for ; Wed, 15 Jun 2022 10:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Pivb5OIwpgfoXsYoQImu/wSuiUBANq2pQ8v7Tg38HQY=; b=ALm0cqW3L19ukgi2EtJa9q4b8VP+hHMN1MIXdF8n3qHRLAHXb+CoKf6UhtwJzL3q0K 5bnk5F2bSD1If0DeVCFSP1w1KoSVOkC81yvCmfxnfno+LvS+xVQbnRhHmBzQ4pCggpnj BaAbkfwSpqaCUnzy9VWBbmcc2DxChUTltoJznuol46nzYX4Jo/xgBvZzjuh1n1jq6sHH 7sHQ7MdqysPfaXDYWh/noKBNHBXGMHFxaBLM/YPMLMJLKWmASKtzdO44P65ZgNohGXp4 CdgPsJMVmfbyo7T+ZR85YbMJc4M/DDaSGNbagKL3i0dc2xjH4+ra40UyysDt34+ZiKjJ B+Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pivb5OIwpgfoXsYoQImu/wSuiUBANq2pQ8v7Tg38HQY=; b=KSWNm058ZM2+9/MHYRjscFLpNiJ/Wa/Nb+t2u0HchhX++FVdxH8G4L69E8Ecz//HBg nKUoAA0vOot2rHt5qsEeU3BUdKz4o8RWKl/lgIzhARLZmQQxhXiGCZPvzuRPufWVMFz0 HWiCAA7jOGmKJMb5cAjp0GRwtTaCWkIC0arrrFtsU7IGi4ZjGAG8+3kDPure5kcjO/Wo lkVSYkHSjLL3qAq1epYxnVhtYlVZoVVc2KgU2An/2vX6ormB384hgirTAQRIrzLs5jP8 V1DrO/D5tDUO2HN7ugiUKFH2LrWkINwh91JIabnUo2ew7OnpFUKH3LVt4FUig/CKAnvY 8ktw== X-Gm-Message-State: AJIora8OBEWcNi+emk/TN+dmeABNjXln9L8BrGip8RM/ruQ3Nbw/VqrO wzBTnBN0vu1j2BTohKJZQmgq8mAKpR8CnP1PjEY= X-Google-Smtp-Source: AGRyM1up2bLRzq4V60zhua87qAZSZaSSTyna2m6QeYSzuqNZionX+A+etegWIs9XH52213bGF6he3t0L4dyJ8mHdRwU= X-Received: by 2002:ad4:5de4:0:b0:46b:be32:797e with SMTP id jn4-20020ad45de4000000b0046bbe32797emr581621qvb.16.1655313044800; Wed, 15 Jun 2022 10:10:44 -0700 (PDT) MIME-Version: 1.0 References: <20220609151953.83802-1-sedara@marvell.com> In-Reply-To: <20220609151953.83802-1-sedara@marvell.com> From: Jerin Jacob Date: Wed, 15 Jun 2022 22:40:19 +0530 Message-ID: Subject: Re: [PATCH] net/octeontx_ep: updated ethdev ops To: Sathesh B Edara Cc: Satananda Burla , Jerin Jacob , Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 9, 2022 at 8:50 PM Sathesh B Edara wrote: > > Updated ethdev ops support for link_update(), > stats_get() and stats_reset() a) Split as two patches (Suggested heading) 1) net/octeontx_ep: support basic stats 2) net/octeontx_ep: support link status b) Update doc/guides/nics/features/octeontx_ep.ini See doc/guides/nics/features.rst > > Signed-off-by: Sathesh B Edara Since this is your first path, you may consider changing to "Sathesh Edara " > +static int > +otx_ep_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete) > +{ > + struct rte_eth_link link; > + > + RTE_SET_USED(wait_to_complete); > + > + if (!eth_dev->data->dev_started) > + return 0; > + > + link.link_speed = RTE_ETH_SPEED_NUM_10G; Isn't this RTE_ETH_SPEED_NUM_NONE? as its speed is "Not defined" >