From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17902423C1; Fri, 13 Jan 2023 12:23:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACAF742D53; Fri, 13 Jan 2023 12:23:27 +0100 (CET) Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by mails.dpdk.org (Postfix) with ESMTP id 67870410EF for ; Fri, 13 Jan 2023 12:23:26 +0100 (CET) Received: by mail-vs1-f42.google.com with SMTP id q125so10180316vsb.0 for ; Fri, 13 Jan 2023 03:23:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zEf30HBtV6T1Bb3pQiwtR56lP89poqIDeW31C+/ThqE=; b=a2hVBZpX0K2F3rs5+SrCBTX/voHCgk5EmdEAT2NwCSVsfm0STT6qXrsUDorNZTe8xn LBy6Ii2pj9FueFQYLlYO72Ub3HHsWTDksHWvJBt/nUZWs+RZVjwZy5rfxxHPYXthvHMA k/ObX1yV2G2aAz9MmnFsJwYJLn6ZYN68YdeAHBcjIkqwmhmZS1tA13EfC1NA4pDcmFxm cOsIVt7zXRIEOPOTUT9vCzImIwE9mHmSYyVXGh+/JnkIvU/L4nWdTJbUrDZDuOFoMdj5 6cE2bUhsiP7E/YEPxF4mAQdWUMPDEGFEWjw8Z2D6DscnHrM/2eqvLRMt50D+2wJ3MU3A v6vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zEf30HBtV6T1Bb3pQiwtR56lP89poqIDeW31C+/ThqE=; b=w2LUKhYApg3VAb6dy0LV/Yx/IPlM2KNAAqlsRm0xEZRp42uy+UfW0DXvG8MFnuVuwf uzYtfGisaiQodY8vd9awiL4y4M0WC+tSVfINIS9VjX1wnVSfQURiWr4uCQEnLFAcQym2 DxbSJgo5Hoc075G/A1Z4rRGxWs+2QG1VRACDDJINXOtDwGuPZoZ2qP9LkVtVf9dpJUGr GGy2LkaG4fln3JXc/pdYT2MpWT1tJzW2pbpXLTy4BcXdpWaRndi/Z4vzC0B+yHevmrRa c7RoRUMkDxzvzE3oj7JrPRlFWT2QIFZCbl8pVmpnWeM4GuDWfI0Fznty16em48a6SaGx kn7w== X-Gm-Message-State: AFqh2krgwwnpRrMYKyyIiueEDE7JUWd2AFurzJqxLWeR+su3lBvd81Cn 1nMoqb1V4y1E2x/mlAJkVsyDYx2/YPjhIIYVieo= X-Google-Smtp-Source: AMrXdXvDyWhXfWfde53zkdrE7vS2436uvvmdhadA5Z2X95Vfkx7JvUriuHNRgY3vM2usQwnekEEvm5a0TE/v8lHGqSk= X-Received: by 2002:a67:ae45:0:b0:3d0:c96e:25ac with SMTP id u5-20020a67ae45000000b003d0c96e25acmr1858614vsh.73.1673609005530; Fri, 13 Jan 2023 03:23:25 -0800 (PST) MIME-Version: 1.0 References: <20220929102936.5490-1-adwivedi@marvell.com> <7a06cfd9-f9de-2df5-d172-44aef97b7529@amd.com> <2036238.VLH7GnMWUR@thomas> <98CBD80474FA8B44BF855DF32C47DC35D87666@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87666@smartserver.smartshare.dk> From: Jerin Jacob Date: Fri, 13 Jan 2023 16:52:59 +0530 Message-ID: Subject: Re: trace point symbols To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Thomas Monjalon , Ferruh Yigit , jerinj@marvell.com, bruce.richardson@intel.com, dev@dpdk.org, Ankur Dwivedi , orika@nvidia.com, ferruh.yigit@xilinx.com, chas3@att.com, humin29@huawei.com, linville@tuxdriver.com, ciara.loftus@intel.com, qi.z.zhang@intel.com, mw@semihalf.com, mk@semihalf.com, shaibran@amazon.com, evgenys@amazon.com, igorch@amazon.com, chandu@amd.com, irusskikh@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, mczekaj@marvell.com, sthotton@marvell.com, srinivasan@marvell.com, hkalra@marvell.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, hyonkim@cisco.com, liudongdong3@huawei.com, yisen.zhuang@huawei.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, simei.su@intel.com, wenjun1.wu@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, rosen.xu@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, lironh@marvell.com, zr@semihalf.com, radhac@marvell.com, vburru@marvell.com, sedara@marvell.com, matan@nvidia.com, viacheslavo@nvidia.com, sthemmin@microsoft.com, longli@microsoft.com, spinler@cesnet.cz, chaoyong.he@corigine.com, niklas.soderlund@corigine.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, g.singh@nxp.com, apeksha.gupta@nxp.com, sachin.saxena@nxp.com, aboyer@pensando.io, rmody@marvell.com, shshaikh@marvell.com, dsinghrawat@marvell.com, andrew.rybchenko@oktetlabs.ru, jiawenwu@trustnetic.com, jianwang@trustnetic.com, jbehrens@vmware.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, steven.webster@windriver.com, matt.peters@windriver.com, mtetsuyah@gmail.com, grive@u256.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, jgrajcia@cisco.com, david.marchand@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 12, 2023 at 3:13 PM Morten Br=C3=B8rup wrote: > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Thursday, 12 January 2023 10.11 > > > > > > I would like to see a policy regarding trace symbols. > > If we decide option 1 is not so useful, > > then we should not export trace symbols at all and document this > > policy. > > Also there are some trace symbols which could be cleaned up. I can send a patch to remove existing exposed symbols for option 1 in DPDK repo. But, Is n't an ABI break? The only downside, I can think of, is that a few more entries in version.map file. I don't have a strong option one way, either. Let me know what you think? If we decided to remove then, In https://doc.dpdk.org/guides/prog_guide/trace_lib.html, There is NOTE section as following, I can remove that as well. -- The RTE_TRACE_POINT_REGISTER defines the placeholder for the rte_trace_point_t tracepoint object. The user must export a __ symbol in the library .map file for this tracepoint to be used out of the library, in shared builds. For example, __app_trace_string will be the exported symbol in the above example. --- > > +1 for not exposing trace point symbols at all. > > The trace point symbols are only used internally by DPDK, so they should = not be part of DPDK's public API. > > It might also make it easier for Bruce to move the trace library out of E= AL. > > I'm not familiar with the CTF format, but I assume that if we don't expos= e the trace point symbols, the trace points can still be identified when pa= rsing the trace file. Yes. It won't impact. The only use case for option 1 is to avoid named look= up. >