From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04E4AA0545; Tue, 11 Oct 2022 16:16:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8FE142DE1; Tue, 11 Oct 2022 16:16:47 +0200 (CEST) Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by mails.dpdk.org (Postfix) with ESMTP id E4F3442B7D; Tue, 11 Oct 2022 16:16:45 +0200 (CEST) Received: by mail-qk1-f176.google.com with SMTP id t25so1457042qkm.2; Tue, 11 Oct 2022 07:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0hpghnPlvS8YTi7EDsA2pbLcZSRIa/7wcUDKlReefPM=; b=A/iJwYZcLi5/9hxhlIPqwrihChFA/yNRV0ryCv/1TfEz7DxunFhIrEOmzIvGuhQgFQ kSzMRZNDD6j9zNAP9wL3A/GYAgU9snPU6ydW6Aeq7BHt4gNZetaXYvPTZi8V5QpHC8cz KmjyaTadiSi6pqig1wz7xdRpn/b0Es4yLlnm39lmswhCFy1dSDyF1R8qGEcIB1ZwuM6w seIvytefF+qUgpCalwXSrIme7EBQfEnuH86m4pCnG9QjYh5q/NrBsGAhJW60AKvb2Lzi yQ4CjKQQzdQp2AUEFz0CWoBSR3L4CdrJuE59PdUvVhog4tcRrr5C8FT7aFthpj/yEw00 p6pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0hpghnPlvS8YTi7EDsA2pbLcZSRIa/7wcUDKlReefPM=; b=l4P0luy78JM1tmA/ijsURXKJRXz2ANGkQgZ19Iz1f31aJvLLNal3lxaLQsQzRO1n0Z VlB7fZs18ff1A6GzOZcNwShsxFAM+A4SYSTzDySb88ed1KxOmnzNK6B44ftvzcLHQWeV e/haxLOYMUbfUPfYyN/h0P6gW0aauzJefPJbbAaFC+oAbFplUxfuVLrnzfmXUK5q+cTO v6QWD0K0FYpC/m6JEOaw0hXctJFUGG7KyaBg4WOC5WjmaP52y5P1aQfmtBC5VwnCulIy X6JHVVmux9+A2sNk1XEVnzR1GJl/e0B3W6ZiKsytCFy9tDYDQ9W2p5jIRH7tZ+GvOWzy 6Rcg== X-Gm-Message-State: ACrzQf1JWMHiZhWR0xxfV5et28ujh3mfqidO/6JBkLiG8BuznapX77QA zQqTECFJFFNc/naVOqxZ9nNlQbD6GE7kzRD+Gxs= X-Google-Smtp-Source: AMsMyM7+tiBOPAH2dVUa8LWJTuY6JsBHp/SL1lZFIn2ljUTkfqmQdtlDh2mLLTvxrFYSmou7lwC6psok8hJ3qdbL3wE= X-Received: by 2002:a05:620a:4842:b0:6ee:8c09:d7cf with SMTP id ec2-20020a05620a484200b006ee8c09d7cfmr967146qkb.662.1665497805323; Tue, 11 Oct 2022 07:16:45 -0700 (PDT) MIME-Version: 1.0 References: <20220921120359.2201131-1-david.marchand@redhat.com> <20221004094418.196544-1-david.marchand@redhat.com> <20221004094418.196544-2-david.marchand@redhat.com> In-Reply-To: <20221004094418.196544-2-david.marchand@redhat.com> From: Jerin Jacob Date: Tue, 11 Oct 2022 19:46:19 +0530 Message-ID: Subject: Re: [PATCH v2 1/9] trace: fix mode for new trace point To: David Marchand Cc: dev@dpdk.org, skori@mavell.com, jerinj@marvell.com, stable@dpdk.org, Sunil Kumar Kori Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 4, 2022 at 3:14 PM David Marchand wrote: > > If an application registers trace points later than rte_eal_init(), > changes in the trace point mode were not applied. > > Fixes: 84c4fae4628f ("trace: implement operation APIs") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Acked-by: Jerin Jacob > --- > lib/eal/common/eal_common_trace.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c > index f9b187d15f..d5dbc7d667 100644 > --- a/lib/eal/common/eal_common_trace.c > +++ b/lib/eal/common/eal_common_trace.c > @@ -512,6 +512,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name, > /* Form the trace handle */ > *handle = sz; > *handle |= trace.nb_trace_points << __RTE_TRACE_FIELD_ID_SHIFT; > + trace_mode_set(handle, trace.mode); > > trace.nb_trace_points++; > tp->handle = handle; > -- > 2.37.3 >