From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BCEB4596A; Thu, 12 Sep 2024 09:35:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4ED4440B94; Thu, 12 Sep 2024 09:35:37 +0200 (CEST) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mails.dpdk.org (Postfix) with ESMTP id 95F3A40B94 for ; Thu, 12 Sep 2024 09:35:36 +0200 (CEST) Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4581d15c3e3so5302971cf.0 for ; Thu, 12 Sep 2024 00:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726126536; x=1726731336; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6M+wk2y4z+UqBr1fhsyx3A/ukePfNiGj6D7YB/dmyRg=; b=gXw74xlexDv4N5xib5FFFlzOkmw6StzkPtcgIa4umzQwPBKDo4hwPp19U2LDmlLNIM 2QeGS7olYRk5dsRyHfAfX2/4IFXX3ec+JI7G0I1WNdx9E1I1YcSLTOROo1HAt/rbWusL Q5eAwYWw+Xu8v5PsRuxazm16keQgFsHcTRq4LVm7dizZYjj2XZn8L3s9hSFe/02Q457z zhYXY0xtBpF5yQZHPrqH8rDH1AnHG3uvZF+T+gJ96dS5sM3L6kuKj8DyswMidtakoSfI dhFB3VoE7x4dxbBT62j96c1qX8x5ipOJogT4HM7Sp12FI/NMQl1XOBhA2UczFNf0cLv2 xQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126536; x=1726731336; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6M+wk2y4z+UqBr1fhsyx3A/ukePfNiGj6D7YB/dmyRg=; b=ukntbg8DBwmccu3Xb5cFW5GbbjrYfUixhi8P7tqzHRrDLi7A4kO2kglcArEmxanSiV Fho3WSMkS1uMrK3h4g2f2OImFaAgTfKlZW3z1UJ4oQ3LTWHzQQdEurh9fzRD/97cjJ9P 3pys2iPI2yY0pb15HWXzJ66JTfWptkG27tTN0PymfZSgbPvtmwxOno9gACFlpXKR8oYP qUnmtqjOlYq2h490lI3JTULsEg0FbOzgv9Lp8ODy3T24yRVsjVC36ivWGDBZJyBBRAHK 46cxYAW++G2HB2QXk7ieAUr9BzQD0b7zoJQdSnDhGbPj3aIg+T7Js1eaIhCI47+7NWgZ 8WKw== X-Gm-Message-State: AOJu0YwCtv1bri0ExKkMSari7itC905wP3Dam0NcZOBqbTQdFJUyHPWV SUmFBtV062Etp6jgJxMV5CEcsg4bfMsgjuBoL6Og4TxWX1pIMfUqxA7a9Gg5UFwMB2OtRQmDCvC 0onoYR5HCLVpqvx33xi5E1Yn5JJw= X-Google-Smtp-Source: AGHT+IEQR1fvBQpEpnScidbXIJAIcLn99tgzE8GzKGL8H2s7WQyuEk7lCBkRflPiGniuKCUjdb7oprxzFfhL0w1jpVk= X-Received: by 2002:a05:622a:587:b0:458:51ea:e36b with SMTP id d75a77b69052e-458602ac723mr26428431cf.5.1726126535703; Thu, 12 Sep 2024 00:35:35 -0700 (PDT) MIME-Version: 1.0 References: <20240910070344.699183-2-mattias.ronnblom@ericsson.com> <20240911170430.701685-1-mattias.ronnblom@ericsson.com> <20240911170430.701685-3-mattias.ronnblom@ericsson.com> In-Reply-To: <20240911170430.701685-3-mattias.ronnblom@ericsson.com> From: Jerin Jacob Date: Thu, 12 Sep 2024 13:05:09 +0530 Message-ID: Subject: Re: [PATCH v2 2/6] eal: add lcore variable test suite To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: dev@dpdk.org, hofors@lysator.liu.se, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Stephen Hemminger , Konstantin Ananyev , David Marchand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 11, 2024 at 11:08=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > > Add test suite to exercise the API. > > Signed-off-by: Mattias R=C3=B6nnblom > Acked-by: Morten Br=C3=B8rup > > -- > > RFC v5: > * Adapt tests to reflect the removal of the GET() and SET() macros. > > RFC v4: > * Check all lcore id's values for all variables in the many variables > test case. > * Introduce test case for max-sized lcore variables. > > RFC v2: > * Improve alignment-related test coverage. > --- > app/test/meson.build | 1 + > app/test/test_lcore_var.c | 432 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 433 insertions(+) > create mode 100644 app/test/test_lcore_var.c > > diff --git a/app/test/meson.build b/app/test/meson.build > index e29258e6ec..48279522f0 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -103,6 +103,7 @@ source_file_deps =3D { > 'test_ipsec_sad.c': ['ipsec'], > 'test_kvargs.c': ['kvargs'], > 'test_latencystats.c': ['ethdev', 'latencystats', 'metrics'] + sampl= e_packet_forward_deps, > + 'test_lcore_var.c': [], > 'test_lcores.c': [], > 'test_link_bonding.c': ['ethdev', 'net_bond', > +} > + > +REGISTER_FAST_TEST(lcore_var_autotest, true, false, test_lcore_var); IMO, Good to add one perf test suite for the operations like other library calls. It may be compared with TLS on same operation. So that end users can decide to use the scheme based on their use case, and we get performance test case to avoid future regression for this library. It may not show any difference in numbers, but once we have self monitoring performance counters[1] it can in the future. [1[] https://patches.dpdk.org/project/dpdk/patch/20230201131757.1787527-1-tduszy= nski@marvell.com/ > -- > 2.34.1 >