From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFBF541CEC; Mon, 20 Feb 2023 14:38:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B04E43043; Mon, 20 Feb 2023 14:38:44 +0100 (CET) Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by mails.dpdk.org (Postfix) with ESMTP id F20CC40395 for ; Mon, 20 Feb 2023 14:38:42 +0100 (CET) Received: by mail-vk1-f172.google.com with SMTP id o14so943577vkf.12 for ; Mon, 20 Feb 2023 05:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ewighfHbSsD9OTHzEkBkObFLX3QHmWybIwSIFKfNH8o=; b=mwVP7xrGU0iP92V3wRwoccAKMF1xXdbp+SsyYzEAVmKla979sCTp6ckTuDEBf3R2Zn hKFG4i8d03v4vIEnyZj9ji5QzzZVg6cwHejiWdVLs+eddjrXOGq+rnymjkzF8CQKSCgW GF4eNCB4CjqvsFl8H4ZlGKNaQDSdb9NC9SPkflZwnq4JolWKNgH0DFibhLgdJ+Y77u7B qavX1XdfRKefbuH64Wf6kaptCe1BNdSgnGVEW+VOeA8NFUHmEJyY3EzFuCTWpEUCMW1C DwB20O4xkCfN0HBFVQyCxlwclRedmqSuBSC2Xgy3wzRTGJuVpdj6Jjm4pzzd725TpkTS ktCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ewighfHbSsD9OTHzEkBkObFLX3QHmWybIwSIFKfNH8o=; b=Vsun3i4O3GVvK5tZXXFoRoNPaecyTIjnxEQayvrnAyTJPhJdvclj0ffQg0b7p1jNw5 SxFHtpvQDT9LGeFv8mRtIXSTut/kdAWdKwh9ct2kWcfRAu1iRwuUSFo2tfxloawOE6Vn lJC3Y/VLcgw88piLO03TliuJD8xxoVkWLFCOwK+uHJRrphww2yDZ/OBjNDukE4FxTcBD JwxQix/iQ65wHgssxLV06MkHNXHCSnd6wxUPZ+PndR/ynArFvl+2GfKkb5Dvmk+8dqM+ HJ5+7oi7+eeYZNt44qRTdatXWVsub2VfwbUibg67ndMrh6Mlyq1prn0+99Jcu0scwP3l AAOw== X-Gm-Message-State: AO0yUKWtSDWJJjlChldb6dr/6KsBA2VjsNx+4pQYC+e+ImNZdWNnATeu fB0Q5tByrciAW65r+achEwZV/ayjBD5O4hHov3I= X-Google-Smtp-Source: AK7set9zFDUTMfAx3agEDjOJ0wo8wEkjLcO2zVwpcbvzqk8twO4/597kiTp3M4D2CIxnVIBn79uSWyu/u7ynHxtXBqM= X-Received: by 2002:a1f:a3c8:0:b0:40b:9:82fd with SMTP id m191-20020a1fa3c8000000b0040b000982fdmr464392vke.18.1676900322194; Mon, 20 Feb 2023 05:38:42 -0800 (PST) MIME-Version: 1.0 References: <20221117050926.136974-1-zhirun.yan@intel.com> <20221117050926.136974-2-zhirun.yan@intel.com> In-Reply-To: <20221117050926.136974-2-zhirun.yan@intel.com> From: Jerin Jacob Date: Mon, 20 Feb 2023 19:08:15 +0530 Message-ID: Subject: Re: [PATCH v1 01/13] graph: split graph worker into common and default model To: Zhirun Yan Cc: dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com, ndabilpuram@marvell.com, cunming.liang@intel.com, haiyue.wang@intel.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 17, 2022 at 10:39 AM Zhirun Yan wrote: > > To support multiple graph worker model, split graph into common > and default. Naming the current walk function as rte_graph_model_rtc > cause the default model is RTC(Run-to-completion). There CI issues with this series. Please check https://patches.dpdk.org/project/dpdk/patch/20221117050926.136974-2-zhirun.yan@intel.com/ # Please make sure each patch builds with devtools/test-meson-builds.sh # Please make sure each patch dont any issue with app/test/test_graph.c test # This series dont have perf issues with app/test/test_graph_perf.c # Both RTC and new mode runs with l3fwd_graph without any performance regression # Please Introduce model concept in documentation at doc/guides/prog_guide/graph_lib.rst and details for this generic mode. Also update the maintainers files for new model files. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > --- > lib/graph/rte_graph_model_rtc.h | 57 ++++ > lib/graph/rte_graph_worker.h | 498 +--------------------------- > lib/graph/rte_graph_worker_common.h | 456 +++++++++++++++++++++++++ Use git mv to avoid loosing history and reduce the diff.